forked from OSchip/llvm-project
99b7b41edf
Currently when LLDB has enough data in the debug information to import the `std` module, it will just try to import it. However when debugging libraries where the sources aren't available anymore, importing the module will generate a confusing diagnostic that the module couldn't be built. For the fallback mode (where we retry failed expressions with the loaded module), this will cause the second expression to fail with a module built error instead of the actual parsing issue in the user expression. This patch adds checks that ensures that we at least have any source files in the found include paths before we try to import the module. This prevents the module from being loaded in the situation described above which means we don't emit the bogus 'can't import module' diagnostic and also don't waste any time retrying the expression in the fallback mode. For the unit tests I did some refactoring as they now require a VFS with the files in it and not just the paths. The Python test just builds a binary with a fake C++ module, then deletes the module before debugging. Fixes rdar://73264458 Reviewed By: JDevlieghere Differential Revision: https://reviews.llvm.org/D95096 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| ClangExpressionDeclMapTest.cpp | ||
| ClangParserTest.cpp | ||
| CppModuleConfigurationTest.cpp | ||
| DWARFExpressionTest.cpp | ||
| DiagnosticManagerTest.cpp | ||