forked from OSchip/llvm-project
3b17b84b9c
The issue was that the has function was generating different results depending on the signedness of char on the host platform. This commit fixes the issue by explicitly using an unsigned char type to prevent sign extension and adds some extra tests. The original commit message was: This patch implements a variant of the DJB hash function which folds the input according to the algorithm in the Dwarf 5 specification (Section 6.1.1.4.5), which in turn references the Unicode Standard (Section 5.18, "Case Mappings"). To achieve this, I have added a llvm::sys::unicode::foldCharSimple function, which performs this mapping. The implementation of this function was generated from the CaseMatching.txt file from the Unicode spec using a python script (which is also included in this patch). The script tries to optimize the function by coalescing adjecant mappings with the same shift and stride (terms I made up). Theoretically, it could be made a bit smarter and merge adjecant blocks that were interrupted by only one or two characters with exceptional mapping, but this would save only a couple of branches, while it would greatly complicate the implementation, so I deemed it was not worth it. Since we assume that the vast majority of the input characters will be US-ASCII, the folding hash function has a fast-path for handling these, and only whips out the full decode+fold+encode logic if we encounter a character outside of this range. It might be possible to implement the folding directly on utf8 sequences, but this would also bring a lot of complexity for the few cases where we will actually need to process non-ascii characters. Reviewers: JDevlieghere, aprantl, probinson, dblaikie Subscribers: mgorny, hintonda, echristo, clayborg, vleschuk, llvm-commits Differential Revision: https://reviews.llvm.org/D42740 llvm-svn: 325732 |
||
|---|---|---|
| .. | ||
| FileCheck | ||
| KillTheDoctor | ||
| LLVMVisualizers | ||
| Misc | ||
| PerfectShuffle | ||
| TableGen | ||
| Target/ARM | ||
| UpdateTestChecks | ||
| bugpoint | ||
| count | ||
| crosstool | ||
| docker | ||
| emacs | ||
| fpcmp | ||
| gdb-scripts | ||
| git | ||
| git-svn | ||
| jedit | ||
| kate | ||
| lint | ||
| lit | ||
| llvm-build | ||
| llvm-lit | ||
| not | ||
| release | ||
| sanitizers | ||
| testgen | ||
| textmate | ||
| unittest | ||
| valgrind | ||
| vim | ||
| vscode | ||
| yaml-bench | ||
| DSAclean.py | ||
| DSAextract.py | ||
| GenLibDeps.pl | ||
| GetRepositoryPath | ||
| GetSourceVersion | ||
| LLVMBuild.txt | ||
| UpdateCMakeLists.pl | ||
| abtest.py | ||
| bisect | ||
| bisect-skip-count | ||
| bugpoint_gisel_reducer.py | ||
| check-each-file | ||
| clang-parse-diagnostics-file | ||
| codegen-diff | ||
| countloc.sh | ||
| create_ladder_graph.py | ||
| extract_symbols.py | ||
| findmisopt | ||
| findoptdiff | ||
| findsym.pl | ||
| getsrcs.sh | ||
| lldbDataFormatters.py | ||
| llvm-compilers-check | ||
| llvm-gisel-cov.py | ||
| llvm-native-gxx | ||
| llvm.grm | ||
| llvmdo | ||
| llvmgrep | ||
| makellvm | ||
| prepare-code-coverage-artifact.py | ||
| schedcover.py | ||
| shuffle_fuzz.py | ||
| shuffle_select_fuzz_tester.py | ||
| sort_includes.py | ||
| unicode-case-fold.py | ||
| update_llc_test_checks.py | ||
| update_mir_test_checks.py | ||
| update_test_checks.py | ||
| wciia.py | ||