llvm-project/clang/lib/CodeGen
Dean Michael Berris 05cf443463 [XRay][clang] Emit "never-instrument" attribute
Summary:
Before this change, we only emit the XRay attributes in LLVM IR when the
-fxray-instrument flag is provided. This may cause issues with thinlto
when the final binary is being built/linked with -fxray-instrument, and
the constitutent LLVM IR gets re-lowered with xray instrumentation.

With this change, we can honour the "never-instrument "attributes
provided in the source code and preserve those in the IR. This way, even
in thinlto builds, we retain the attributes which say whether functions
should never be XRay instrumented.

This change addresses llvm.org/PR38922.

Reviewers: mboerger, eizan

Subscribers: mehdi_amini, dexonsmith, cfe-commits, llvm-commits

Differential Revision: https://reviews.llvm.org/D52015

llvm-svn: 342200
2018-09-14 01:59:12 +00:00
..
ABIInfo.h Delete BuiltinCC. NFC. 2018-03-20 22:02:57 +00:00
Address.h
BackendUtil.cpp [MSan] add KMSAN support to Clang driver 2018-09-07 09:21:09 +00:00
CGAtomic.cpp Do not use optimized atomic libcalls for misaligned atomics. 2018-09-07 23:57:54 +00:00
CGBlocks.cpp Revert r341754. 2018-09-09 05:22:49 +00:00
CGBlocks.h [CodeGen] Merge identical block descriptor global variables. 2018-08-17 15:46:07 +00:00
CGBuilder.h Remove trailing space 2018-07-30 19:24:48 +00:00
CGBuiltin.cpp [X86] Custom emit __builtin_rdtscp so we can emit an explicit store for the out parameter 2018-09-07 19:14:24 +00:00
CGCUDANV.cpp [HIP] Make __hip_gpubin_handle hidden to avoid being merged across different shared libraries 2018-08-17 17:47:31 +00:00
CGCUDARuntime.cpp Refactor call emission to package the function pointer together with 2016-10-26 23:46:34 +00:00
CGCUDARuntime.h
CGCXX.cpp Remove trailing space 2018-07-30 19:24:48 +00:00
CGCXXABI.cpp Remove trailing space 2018-07-30 19:24:48 +00:00
CGCXXABI.h [WebAssembly] Use Windows EH instructions for Wasm EH 2018-05-31 22:18:13 +00:00
CGCall.cpp [x86/SLH] Add a real Clang flag and LLVM IR attribute for Speculative 2018-09-04 12:38:00 +00:00
CGCall.h Remove trailing space 2018-07-30 19:24:48 +00:00
CGClass.cpp Revert r341754. 2018-09-09 05:22:49 +00:00
CGCleanup.cpp Remove trailing space 2018-07-30 19:24:48 +00:00
CGCleanup.h Remove trailing space 2018-07-30 19:24:48 +00:00
CGCoroutine.cpp Port getLocStart -> getBeginLoc 2018-08-09 21:08:08 +00:00
CGDebugInfo.cpp Remove all uses of DIFlagBlockByrefStruct 2018-09-10 16:14:28 +00:00
CGDebugInfo.h Remove all uses of DIFlagBlockByrefStruct 2018-09-10 16:14:28 +00:00
CGDecl.cpp Revert r341754. 2018-09-09 05:22:49 +00:00
CGDeclCXX.cpp [AArch64] Enable return address signing for static ctors 2018-09-13 10:25:36 +00:00
CGException.cpp Add Windows support for the GNUstep Objective-C ABI V2. 2018-08-10 12:53:13 +00:00
CGExpr.cpp Revert r341754. 2018-09-09 05:22:49 +00:00
CGExprAgg.cpp Remove trailing space 2018-07-30 19:24:48 +00:00
CGExprCXX.cpp Port getLocStart -> getBeginLoc 2018-08-09 21:08:08 +00:00
CGExprComplex.cpp Remove \brief commands from doxygen comments. 2018-05-09 01:00:01 +00:00
CGExprConstant.cpp [CodeGen] IncompleteArray Support 2018-08-08 00:01:21 +00:00
CGExprScalar.cpp Port getLocStart -> getBeginLoc 2018-08-09 21:08:08 +00:00
CGGPUBuiltin.cpp Recommit r326946 after reducing CallArgList memory footprint 2018-03-15 15:25:19 +00:00
CGLoopInfo.cpp [CodeGen] Emit parallel_loop_access for each loop in the loop stack. 2018-08-03 04:42:52 +00:00
CGLoopInfo.h [UnrollAndJam] Add unroll_and_jam pragma handling 2018-08-01 14:36:12 +00:00
CGNonTrivialStruct.cpp [CodeGen] Merge equivalent block copy/helper functions. 2018-08-10 15:09:24 +00:00
CGObjC.cpp Port getLocEnd -> getEndLoc 2018-08-09 21:09:38 +00:00
CGObjCGNU.cpp [gnu-objc] Make selector order deterministic. 2018-08-14 10:05:25 +00:00
CGObjCMac.cpp [ObjC] Error out when using forward-declared protocol in a @protocol 2018-08-17 22:18:08 +00:00
CGObjCRuntime.cpp Fix a deprecated warning in the last commit. 2018-08-10 12:53:18 +00:00
CGObjCRuntime.h [CodeGen] Merge identical block descriptor global variables. 2018-08-17 15:46:07 +00:00
CGOpenCLRuntime.cpp [OpenCL] Add separate read_only and write_only pipe IR types 2018-04-27 10:37:04 +00:00
CGOpenCLRuntime.h Remove \brief commands from doxygen comments. 2018-05-09 01:00:01 +00:00
CGOpenMPRuntime.cpp [OPENMP] Fix PR38903: Crash on instantiation of the non-dependent 2018-09-13 16:54:05 +00:00
CGOpenMPRuntime.h [OPENMP] Fix PR38903: Crash on instantiation of the non-dependent 2018-09-13 16:54:05 +00:00
CGOpenMPRuntimeNVPTX.cpp [OPENMP] Fix PR38710: static functions are not emitted as implicitly 2018-08-30 18:56:11 +00:00
CGOpenMPRuntimeNVPTX.h [OPENMP] Fix PR38710: static functions are not emitted as implicitly 2018-08-30 18:56:11 +00:00
CGRecordLayout.h Remove \brief commands from doxygen comments. 2018-05-09 01:00:01 +00:00
CGRecordLayoutBuilder.cpp Remove trailing space 2018-07-30 19:24:48 +00:00
CGStmt.cpp Revert "[DebugInfo] Generate debug information for labels. (Fix PR37395)" 2018-09-06 14:27:40 +00:00
CGStmtOpenMP.cpp [OPENMP] Fix emission of the loop doacross constructs. 2018-08-13 19:04:24 +00:00
CGVTT.cpp [CodeGen] Align rtti and vtable data 2018-09-12 14:09:06 +00:00
CGVTables.cpp [CodeGen] Align rtti and vtable data 2018-09-12 14:09:06 +00:00
CGVTables.h Remove trailing space 2018-07-30 19:24:48 +00:00
CGValue.h Remove trailing space 2018-07-30 19:24:48 +00:00
CMakeLists.txt Compile CodeGenModule.cpp with /bigobj. 2018-06-26 17:45:26 +00:00
CodeGenABITypes.cpp Include getting generated struct offsets in CodegenABITypes 2017-10-10 23:54:21 +00:00
CodeGenAction.cpp [CodeGen][Timers] Enable llvm::TimePassesIsEnabled when -ftime-report is specified 2018-08-08 19:14:23 +00:00
CodeGenFunction.cpp [XRay][clang] Emit "never-instrument" attribute 2018-09-14 01:59:12 +00:00
CodeGenFunction.h [NFC]Refactor MultiVersion Resolver Emission to combine types 2018-09-13 16:58:24 +00:00
CodeGenModule.cpp [XRay][clang] Emit "never-instrument" attribute 2018-09-14 01:59:12 +00:00
CodeGenModule.h [CodeGen] Align rtti and vtable data 2018-09-12 14:09:06 +00:00
CodeGenPGO.cpp Port getLocStart -> getBeginLoc 2018-08-09 21:08:08 +00:00
CodeGenPGO.h Remove a dead field. NFC. 2017-04-24 20:54:36 +00:00
CodeGenTBAA.cpp [CodeGen] Fix generation of TBAA tags for may-alias accesses 2018-02-20 12:33:04 +00:00
CodeGenTBAA.h [CodeGen] Fix generation of TBAA tags for may-alias accesses 2018-02-20 12:33:04 +00:00
CodeGenTypeCache.h Delete BuiltinCC. NFC. 2018-03-20 22:02:57 +00:00
CodeGenTypes.cpp Remove trailing space 2018-07-30 19:24:48 +00:00
CodeGenTypes.h Remove trailing space 2018-07-30 19:24:48 +00:00
ConstantEmitter.h [NFC] typo 2018-07-11 19:51:40 +00:00
ConstantInitBuilder.cpp Remove trailing space 2018-07-30 19:24:48 +00:00
CoverageMappingGen.cpp Remove deprecated API 2018-09-06 18:26:30 +00:00
CoverageMappingGen.h Remove \brief commands from doxygen comments. 2018-05-09 01:00:01 +00:00
EHScopeStack.h Spelling mistakes in comments. NFCI. (PR27635) 2017-03-30 14:13:19 +00:00
ItaniumCXXABI.cpp [CodeGen] Align rtti and vtable data 2018-09-12 14:09:06 +00:00
MacroPPCallbacks.cpp Reland '[clang] Adding CharacteristicKind to PPCallbacks::InclusionDirective' 2018-05-10 19:05:36 +00:00
MacroPPCallbacks.h Add header guards to some headers that are missing them 2018-09-03 16:26:36 +00:00
MicrosoftCXXABI.cpp [CodeGen] Align rtti and vtable data 2018-09-12 14:09:06 +00:00
ModuleBuilder.cpp D34444: Teach codegen to work in incremental processing mode. 2017-08-27 10:58:03 +00:00
ObjectFilePCHContainerOperations.cpp [clang] Update uses of DEBUG macro to LLVM_DEBUG. 2018-05-15 13:30:56 +00:00
README.txt
SanitizerMetadata.cpp hwasan: add -fsanitize=kernel-hwaddress flag 2018-04-13 18:05:21 +00:00
SanitizerMetadata.h
SwiftCallingConv.cpp Remove trailing space 2018-07-30 19:24:48 +00:00
TargetInfo.cpp [CodeGen][ARM] Coerce FP16 vectors to integer vectors when needed 2018-09-12 09:19:19 +00:00
TargetInfo.h [CUDA][HIP] Set kernel calling convention before arrange function 2018-06-12 00:16:33 +00:00
VarBypassDetector.cpp Fix typos in clang 2018-04-06 15:14:32 +00:00
VarBypassDetector.h [CodeGen] Don't emit lifetime intrinsics for some local variables 2016-10-26 05:42:30 +00:00

README.txt

IRgen optimization opportunities.

//===---------------------------------------------------------------------===//

The common pattern of
--
short x; // or char, etc
(x == 10)
--
generates an zext/sext of x which can easily be avoided.

//===---------------------------------------------------------------------===//

Bitfields accesses can be shifted to simplify masking and sign
extension. For example, if the bitfield width is 8 and it is
appropriately aligned then is is a lot shorter to just load the char
directly.

//===---------------------------------------------------------------------===//

It may be worth avoiding creation of alloca's for formal arguments
for the common situation where the argument is never written to or has
its address taken. The idea would be to begin generating code by using
the argument directly and if its address is taken or it is stored to
then generate the alloca and patch up the existing code.

In theory, the same optimization could be a win for block local
variables as long as the declaration dominates all statements in the
block.

NOTE: The main case we care about this for is for -O0 -g compile time
performance, and in that scenario we will need to emit the alloca
anyway currently to emit proper debug info. So this is blocked by
being able to emit debug information which refers to an LLVM
temporary, not an alloca.

//===---------------------------------------------------------------------===//

We should try and avoid generating basic blocks which only contain
jumps. At -O0, this penalizes us all the way from IRgen (malloc &
instruction overhead), all the way down through code generation and
assembly time.

On 176.gcc:expr.ll, it looks like over 12% of basic blocks are just
direct branches!

//===---------------------------------------------------------------------===//