forked from OSchip/llvm-project
2622419c78
Using GNU diff, `--strip-trailing-cr` removes a `\r` appearing before a `\n` at the end of a line. Without this patch, lit's internal diff only removes `\r` if it appears as the last character. That seems useless. This patch fixes that. This patch also adds `--strip-trailing-cr` to some tests that fail on Windows bots when D68664 is applied. Based on what I see in the bot logs, I think the following is happening. In each test there, lit diff is comparing a file with `\r\n` line endings to a file with `\n` line endings. Without D68664, lit diff reads those files in text mode, which in Windows causes `\r\n` to be replaced with `\n`. However, with D68664, lit diff reads the files in binary mode instead and thus reports that every line is different, just as GNU diff does (at least under Ubuntu). Adding `--strip-trailing-cr` to those tests restores the previous behavior while permitting the behavior of lit diff to be more like GNU diff. Reviewed By: rnk Differential Revision: https://reviews.llvm.org/D68839 llvm-svn: 375020 |
||
|---|---|---|
| .. | ||
| AArch64 | ||
| Inputs | ||
| align_invalid.s | ||
| altmacro_expression.s | ||
| altmacro_string.s | ||
| altmacro_string_escape.s | ||
| assembler-expressions-fail.s | ||
| assembler-expressions-inlineasm.ll | ||
| assembler-expressions.s | ||
| assignment.s | ||
| at-pseudo-variable-bad.s | ||
| at-pseudo-variable.s | ||
| bad-macro.s | ||
| cfi-unfinished-frame.s | ||
| cfi-unknown-register.s | ||
| cfi-window-save.s | ||
| comments-x86-darwin.s | ||
| conditional_asm.s | ||
| dash-n.s | ||
| debug-empty-source.s | ||
| debug-no-source.s | ||
| debug-only-comments.s | ||
| defsym.s | ||
| defsym_error1.s | ||
| defsym_error2.s | ||
| directive-err-diagnostics.s | ||
| directive-err.s | ||
| directive-warning.s | ||
| directive_abort.s | ||
| directive_align.s | ||
| directive_ascii.s | ||
| directive_cgprofile.s | ||
| directive_comm.s | ||
| directive_darwin_section.s | ||
| directive_dc.s | ||
| directive_dcb.s | ||
| directive_desc.s | ||
| directive_ds.s | ||
| directive_elf_size.s | ||
| directive_end-2.s | ||
| directive_end.s | ||
| directive_file-2.s | ||
| directive_file-3.s | ||
| directive_file-g.s | ||
| directive_file.s | ||
| directive_fill.s | ||
| directive_fill_2.s | ||
| directive_incbin.s | ||
| directive_include.s | ||
| directive_lcomm.s | ||
| directive_line.s | ||
| directive_loc.s | ||
| directive_lsym.s | ||
| directive_org.s | ||
| directive_print.s | ||
| directive_rept-diagnostics.s | ||
| directive_rept.s | ||
| directive_seh.s | ||
| directive_set.s | ||
| directive_space.s | ||
| directive_subsections_via_symbols.s | ||
| directive_symbol_attrs.s | ||
| directive_tbss.s | ||
| directive_tdata.s | ||
| directive_thread_init_func.s | ||
| directive_tlv.s | ||
| directive_values.s | ||
| directive_zerofill.s | ||
| dollars-in-identifiers.s | ||
| dot-symbol-assignment-backwards.s | ||
| dot-symbol-assignment.s | ||
| dot-symbol-non-absolute.s | ||
| dot-symbol.s | ||
| empty-comment.s | ||
| equ.s | ||
| expr-shr.s | ||
| expr_symbol_modifiers.s | ||
| exprs-invalid.s | ||
| exprs.s | ||
| extern.s | ||
| floating-literals.s | ||
| hash-directive.s | ||
| hello.s | ||
| if-diagnostics.s | ||
| ifb.s | ||
| ifc.s | ||
| ifdef.s | ||
| ifeqs-diagnostics.s | ||
| ifeqs.s | ||
| ifndef.s | ||
| ifnes.s | ||
| incbin_abcd | ||
| include.ll | ||
| inline-comments.ll | ||
| inline_macro_duplication.ll | ||
| invalid-asm-variant.s | ||
| invalid-input-assertion.s | ||
| labels.s | ||
| line_with_hash.s | ||
| lit.local.cfg | ||
| macro-args.s | ||
| macro-def-in-instantiation.s | ||
| macro-duplicate-params-names-err.s | ||
| macro-err1.s | ||
| macro-exitm.s | ||
| macro-irp.s | ||
| macro-irpc.s | ||
| macro-max-depth.s | ||
| macro-qualifier-diagnostics.s | ||
| macro-qualifier.s | ||
| macro-rept-err1.s | ||
| macro-rept-err2.s | ||
| macro-rept.s | ||
| macro_parsing.s | ||
| macros-argument-parsing-diagnostics.s | ||
| macros-argument-parsing.s | ||
| macros-darwin-vararg.s | ||
| macros-darwin.s | ||
| macros-gas.s | ||
| macros-parsing.s | ||
| negativ_altmacro_expression.s | ||
| negative_altmacro_string.s | ||
| non-english-characters.s | ||
| pr11865.s | ||
| pr28805.ll | ||
| pr28921.s | ||
| preserve-comments-crlf.s | ||
| preserve-comments.s | ||
| purgem.s | ||
| reassign.s | ||
| rename.s | ||
| section.s | ||
| section_names.s | ||
| secure_log_unique.s | ||
| seh-directive-errors.s | ||
| seh-unfinished-frame.s | ||
| undefined-local-symbol.s | ||
| unfinished-op.s | ||
| uppercase-hex.s | ||
| vararg-default-value.s | ||
| vararg.s | ||
| variables-invalid.s | ||
| variables.s | ||