forked from OSchip/llvm-project
f035b75d8f
There are numorous flaws about the name conflict handling, this patch
attempts fixes them. Changes in details:
* HandleNameConflict return with a false DeclarationName
Hitherto we effectively never returned with a NameConflict error, even
if the preceding StructuralMatch indicated a conflict.
Because we just simply returned with the parameter `Name` in
HandleNameConflict and that name is almost always `true` when converted to
`bool`.
* Add tests which indicate wrong NameConflict handling
* Add to ConflictingDecls only if decl kind is different
Note, we might not indicate an ODR error when there is an existing record decl
and a enum is imported with same name. But there are other cases. E.g. think
about the case when we import a FunctionTemplateDecl with name f and we found a
simple FunctionDecl with name f. They overload. Or in case of a
ClassTemplateDecl and CXXRecordDecl, the CXXRecordDecl could be the 'templated'
class, so it would be false to report error. So I think we should report a
name conflict error only when we are 100% sure of that. That is why I think it
should be a general pattern to report the error only if the kind is the same.
* Fix failing ctu test with EnumConstandDecl
In ctu-main.c we have the enum class 'A' which brings in the enum
constant 'x' with value 0 into the global namespace.
In ctu-other.c we had the enum class 'B' which brought in the same name
('x') as an enum constant but with a different enum value (42). This is clearly
an ODR violation in the global namespace. The solution was to rename the
second enum constant.
* Introduce ODR handling strategies
Reviewers: a_sidorin, shafik
Differential Revision: https://reviews.llvm.org/D59692
llvm-svn: 370045
|
||
|---|---|---|
| .. | ||
| Models | ||
| expected-plists | ||
| ctu-chain.cpp | ||
| ctu-other.c | ||
| ctu-other.c.externalDefMap.txt | ||
| ctu-other.cpp | ||
| ctu-other.cpp.externalDefMap.txt | ||
| llvm.h | ||
| localization-pch.h | ||
| no-store-suppression.h | ||
| plist-macros-ctu.c | ||
| plist-macros-ctu.h | ||
| plist-macros-with-expansion-ctu.c.externalDefMap.txt | ||
| qt-simulator.h | ||
| system-header-simulator-cxx-std-suppression.h | ||
| system-header-simulator-cxx.h | ||
| system-header-simulator-for-cxx-uninitialized-object.h | ||
| system-header-simulator-for-malloc.h | ||
| system-header-simulator-for-nullability-cxx.h | ||
| system-header-simulator-for-nullability.h | ||
| system-header-simulator-for-objc-dealloc.h | ||
| system-header-simulator-for-pthread-lock.h | ||
| system-header-simulator-for-simple-stream.h | ||
| system-header-simulator-for-valist.h | ||
| system-header-simulator-objc.h | ||
| system-header-simulator.h | ||
| taint-generic-config-ill-formed.yaml | ||
| taint-generic-config-invalid-arg.yaml | ||
| taint-generic-config.yaml | ||