forked from OSchip/llvm-project
5c3d8fe853
an external layout is used Summary: The patch removes alignment of virtual bases when an external layout is used. We have two cases: - the external layout source has an information about virtual bases offsets, so we just use them; - the external source has no information about virtual bases offsets. In this case we can't predict where the base will be located. If we will align it but there will be something like `#pragma pack(push, 1)` really, then likely our layout will not fit into the real structure size, and then some asserts will hit. The asserts look reasonable, so I don't think that we need to remove them. May be it would be better instead don't align fields / bases etc. (so treat it always as `#pragma pack(push, 1)`) when an external layout source is used but no info about a field location is presented. This one is related to D49871 Reviewers: rnk, rsmith, zturner, mstorsjo, majnemer Reviewed By: rnk Subscribers: cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D53497 llvm-svn: 345012 |
||
|---|---|---|
| .. | ||
| debug-info-class-limited.cpp | ||
| override-bit-field-layout.layout | ||
| override-layout-nameless-struct-union.layout | ||
| override-layout-packed-base.layout | ||
| profile-remap.map | ||
| profile-remap.proftext | ||
| profile-remap.samples | ||
| std-compare.h | ||