llvm-project/clang/unittests
Paul Hoad 603650213b [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed
Summary:
This is a patch to fix PR43372 (https://bugs.llvm.org/show_bug.cgi?id=43372) - clang-format can't format file with includes, ( which really keep providing replacements for already sorted headers.)

A similar issue was addressed by @krasimir in {D60199}, however, this seemingly only prevented the issue when the files being formatted did not contain windows line endings (\r\n)

It's possible this is related to https://twitter.com/StephanTLavavej/status/1176722938243895296 given who @STL_MSFT  works for!

As people often used the existence of replacements to determine if a file needs clang-formatting, this is probably pretty important for windows users

There may be a better way of comparing 2 strings and ignoring \r (which appear in both Results and Code), I couldn't choose between this idiom or the copy_if approach, but I'm happy to change it to whatever people consider more performant.

Reviewers: krasimir, klimek, owenpan, ioeric

Reviewed By: krasimir

Subscribers: cfe-commits, STL_MSFT, krasimir

Tags: #clang-format, #clang, #clang-tools-extra

Differential Revision: https://reviews.llvm.org/D68227

llvm-svn: 373388
2019-10-01 20:20:22 +00:00
..
AST Fix memory leak in DeclTest. 2019-09-25 22:38:20 +00:00
ASTMatchers Fix the nullPointerConstant() test to get bots back to green. 2019-08-22 18:56:18 +00:00
Analysis [CFG] Introduce CFGElementRef, a wrapper that knows it's position in a CFGBlock 2019-08-14 17:05:55 +00:00
Basic ASTReader: Bypass overridden files when reading PCHs 2019-08-30 22:59:25 +00:00
CodeGen Added 'inline' to functions defined in headers to avoid ODR violations 2019-08-29 16:58:13 +00:00
CrossTU [Tooling] Migrated APIs that take ownership of objects to unique_ptr 2019-08-30 09:29:34 +00:00
DirectoryWatcher Use ASSERT_THAT_ERROR instead of logAllUnhandledErrors/exit 2019-08-09 06:14:54 +00:00
Driver Driver tests: set `--sysroot=""` to support clang with `DEFAULT_SYSROOT` 2019-09-28 12:21:06 +00:00
Format [clang-format] [PR43372] - clang-format shows replacements in DOS files when no replacement is needed 2019-10-01 20:20:22 +00:00
Frontend [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
Index [Tooling] Migrated APIs that take ownership of objects to unique_ptr 2019-08-30 09:29:34 +00:00
Lex [clang-scan-deps] Allow continuation line backslashes followed by whitespace 2019-09-26 19:28:51 +00:00
Rename cmake: Add CLANG_LINK_CLANG_DYLIB option 2019-07-03 22:45:55 +00:00
Rewrite [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug 2019-08-15 21:17:48 +00:00
Sema [LifetimeAnalysis] don't use raw string literals in macros 2019-09-06 19:15:02 +00:00
Serialization cmake: Add CLANG_LINK_CLANG_DYLIB option 2019-07-03 22:45:55 +00:00
StaticAnalyzer [analyzer][NFC] Fix inconsistent references to checkers as "checks" 2019-09-12 19:09:24 +00:00
Tooling [libTooling] Transformer: refine `SourceLocation` specified as anchor of changes. 2019-09-27 15:26:04 +00:00
libclang [libclang] Fix UninstallAbortingLLVMFatalErrorHandler test 2019-09-12 23:51:48 +00:00
CMakeLists.txt [clang] [unittest] Import LLVMTestingSupport if necessary 2019-09-12 13:06:12 +00:00