forked from OSchip/llvm-project
923ff550b9
The issue here is that we actually allow CGSCC passes to mutate IR (and therefore invalidate analyses) outside of the current SCC. At a minimum, we need to support mutating parent and ancestor SCCs to support the ArgumentPromotion pass which rewrites all calls to a function. However, the analysis invalidation infrastructure is heavily based around not needing to invalidate the same IR-unit at multiple levels. With Loop passes for example, they don't invalidate other Loops. So we need to customize how we handle CGSCC invalidation. Doing this without gratuitously re-running analyses is even harder. I've avoided most of these by using an out-of-band preserved set to accumulate the cross-SCC invalidation, but it still isn't perfect in the case of re-visiting the same SCC repeatedly *but* it coming off the worklist. Unclear how important this use case really is, but I wanted to call it out. Another wrinkle is that in order for this to successfully propagate to function analyses, we have to make sure we have a proxy from the SCC to the Function level. That requires pre-creating the necessary proxy. The motivating test case now works cleanly and is added for ArgumentPromotion. Thanks for the review from Philip and Wei! Differential Revision: https://reviews.llvm.org/D59869 llvm-svn: 357137 |
||
|---|---|---|
| .. | ||
| Inputs | ||
| X86 | ||
| 2002-01-31-CallGraph.ll | ||
| 2002-02-24-InlineBrokePHINodes.ll | ||
| 2002-03-11-ConstPropCrash.ll | ||
| 2003-02-19-LoopInfoNestingBug.ll | ||
| 2004-08-16-PackedConstantInlineStore.ll | ||
| 2004-08-16-PackedGlobalConstant.ll | ||
| 2004-08-16-PackedSelect.ll | ||
| 2004-08-16-PackedSimple.ll | ||
| 2004-08-20-PackedControlFlow.ll | ||
| 2006-02-05-PassManager.ll | ||
| 2007-04-24-eliminate-mostly-empty-blocks.ll | ||
| 2007-06-05-PassID.ll | ||
| 2007-06-28-PassManager.ll | ||
| 2007-09-10-PassManager.ll | ||
| 2008-02-14-PassManager.ll | ||
| 2008-06-04-FieldSizeInPacked.ll | ||
| 2008-10-06-RemoveDeadPass.ll | ||
| 2008-10-15-MissingSpace.ll | ||
| 2009-03-31-CallGraph.ll | ||
| 2009-06-05-no-implicit-float.ll | ||
| 2009-09-14-function-elements.ll | ||
| 2010-05-06-Printer.ll | ||
| FileCheck-space.txt | ||
| ResponseFile.ll | ||
| attribute-comment.ll | ||
| bcanalyzer-block-info.txt | ||
| can-execute.txt | ||
| cfg-printer-branch-weights.ll | ||
| cgscc-devirt-iteration.ll | ||
| cgscc-disconnected-invalidation.ll | ||
| cgscc-iterate-function-mutation.ll | ||
| cgscc-libcall-update.ll | ||
| cgscc-observe-devirt.ll | ||
| cleanup-lcssa.ll | ||
| close-stderr.ll | ||
| codegenprepare-and-debug.ll | ||
| constant-fold-gep-address-spaces.ll | ||
| constant-fold-gep.ll | ||
| cspgo-O2-pipeline.ll | ||
| debugcounter-dce.ll | ||
| debugcounter-earlycse.ll | ||
| debugcounter-newgvn.ll | ||
| debugcounter-predicateinfo.ll | ||
| extract-alias.ll | ||
| extract-linkonce.ll | ||
| extract-weak-odr.ll | ||
| extract.ll | ||
| invalid-commandline-option.ll | ||
| invariant.group.ll | ||
| lint.ll | ||
| lit-globbing.ll | ||
| lit-quoting.txt | ||
| lit-unicode.txt | ||
| llvm-nm-without-aliases.ll | ||
| loop-deletion-printer.ll | ||
| loop-pass-ordering.ll | ||
| loop-pass-printer.ll | ||
| loop-pm-invalidation.ll | ||
| machine-size-remarks.ll | ||
| new-pass-manager.ll | ||
| new-pm-cspgo.ll | ||
| new-pm-defaults.ll | ||
| new-pm-lto-defaults.ll | ||
| new-pm-pgo.ll | ||
| new-pm-thinlto-defaults.ll | ||
| opt-O0-pipeline.ll | ||
| opt-O2-pipeline.ll | ||
| opt-O3-pipeline.ll | ||
| opt-Os-pipeline.ll | ||
| opt-bisect-helper.py | ||
| opt-bisect-legacy-pass-manager.ll | ||
| opt-hot-cold-split.ll | ||
| opt-override-mcpu-mattr.ll | ||
| opt-twice.ll | ||
| optimization-remarks-inline.ll | ||
| optimization-remarks-invalidation.ll | ||
| optimization-remarks-lazy-bfi.ll | ||
| optimize-inrange-gep.ll | ||
| optimize-options.ll | ||
| pass-pipeline-parsing.ll | ||
| pass-pipelines.ll | ||
| pipefail.txt | ||
| pr32085.ll | ||
| print-debug-counter.ll | ||
| print-module-scope.ll | ||
| printer.ll | ||
| scc-deleted-printer.ll | ||
| scc-pass-printer.ll | ||
| size-remarks.ll | ||
| spir_cc.ll | ||
| statistic.ll | ||
| time-passes.ll | ||
| umask.ll | ||
| writing-to-stdout.ll | ||