forked from OSchip/llvm-project
31e60b9133
This is a rework of D85812, which didn't land.
When callee coroutine function is inlined into caller coroutine function before coro-split pass, llvm will emits "coroutine should have exactly one defining @llvm.coro.begin". It seems that coro-early pass can not handle this quiet well.
So we believe that unsplited coroutine function should not be inlined.
This patch fix such issue by not inlining function if it has attribute "coroutine.presplit" (it means the function has not been splited) to fix this issue
test plan: check-llvm, check-clang
In D85812, there was suggestions on moving the macros to Attributes.td to avoid circular header dependency issue.
I believe it's not worth doing just to be able to use one constant string in one place.
Today, there are already 3 possible attribute values for "coroutine.presplit":
|
||
|---|---|---|
| .. | ||
| Inputs | ||
| ArgAddr.ll | ||
| coro-alloc-with-param-O0.ll | ||
| coro-alloc-with-param-O2.ll | ||
| coro-alloca-01.ll | ||
| coro-alloca-02.ll | ||
| coro-alloca-03.ll | ||
| coro-alloca-04.ll | ||
| coro-alloca-05.ll | ||
| coro-alloca-06.ll | ||
| coro-async.ll | ||
| coro-catchswitch-cleanuppad.ll | ||
| coro-catchswitch.ll | ||
| coro-cleanup-lowering.ll | ||
| coro-cleanup.ll | ||
| coro-debug-frame-variable.ll | ||
| coro-debug.ll | ||
| coro-early.ll | ||
| coro-eh-aware-edge-split-00.ll | ||
| coro-eh-aware-edge-split-01.ll | ||
| coro-eh-aware-edge-split-02.ll | ||
| coro-elide.ll | ||
| coro-frame-arrayalloca.ll | ||
| coro-frame-reuse-alloca-00.ll | ||
| coro-frame-reuse-alloca-01.ll | ||
| coro-frame-reuse-alloca-02.ll | ||
| coro-frame-reuse-alloca-03.ll | ||
| coro-frame-unreachable.ll | ||
| coro-frame.ll | ||
| coro-heap-elide.ll | ||
| coro-inline.ll | ||
| coro-materialize.ll | ||
| coro-padding.ll | ||
| coro-param-copy.ll | ||
| coro-retcon-alloca.ll | ||
| coro-retcon-frame.ll | ||
| coro-retcon-once-value.ll | ||
| coro-retcon-once-value2.ll | ||
| coro-retcon-resume-values.ll | ||
| coro-retcon-resume-values2.ll | ||
| coro-retcon-value.ll | ||
| coro-retcon.ll | ||
| coro-spill-after-phi.ll | ||
| coro-spill-corobegin.ll | ||
| coro-spill-defs-before-corobegin.ll | ||
| coro-split-00.ll | ||
| coro-split-01.ll | ||
| coro-split-02.ll | ||
| coro-split-alloc.ll | ||
| coro-split-dbg.ll | ||
| coro-split-eh-00.ll | ||
| coro-split-eh-01.ll | ||
| coro-split-hidden.ll | ||
| coro-split-musttail.ll | ||
| coro-split-musttail1.ll | ||
| coro-split-musttail2.ll | ||
| coro-split-musttail3.ll | ||
| coro-split-sink-lifetime-01.ll | ||
| coro-split-sink-lifetime-02.ll | ||
| coro-split-sink-lifetime-03.ll | ||
| coro-split-sink-lifetime-04.ll | ||
| coro-swifterror.ll | ||
| ex0.ll | ||
| ex1.ll | ||
| ex2.ll | ||
| ex3.ll | ||
| ex4.ll | ||
| ex5.ll | ||
| no-suspend.ll | ||
| phi-coro-end.ll | ||
| restart-trigger.ll | ||
| smoketest.ll | ||