llvm-project/lldb
Greg Clayton 6234a5c863 Centralize the way symbol and functions are looked up by making a Module::LookupInfo class that does all of the heavy lifting.
Background: symbols and functions can be looked up by full mangled name and by basename. SymbolFile and ObjectFile are expected to be able to do the lookups based on full mangled name or by basename, so when the user types something that is incomplete, we must be able to look it up efficiently. For example the user types "a:🅱️:c" as a symbol to set a breakpoint on, we will break this down into a 'lookup "c"' and then weed out N matches down to just the ones that match "a:🅱️:c". Previously this was done manaully in many functions by calling Module::PrepareForFunctionNameLookup(...) and then doing the lookup and manually pruning the results down afterward with duplicated code. Now all places use Module::LookupInfo to do the work in one place.

This allowed me to fix the name lookups to look for "func" with eFunctionNameTypeFull as the "name_type_mask", and correctly weed the results:

"func", "func()", "func(int)", "a::func()", "b::func()", and "a:🅱️:func()" down to just "func", "func()", "func(int)". Previously we would have set 6 breakpoints, now we correctly set just 3. This also extends to the expression parser when it looks up names for functions it needs to not get multiple results so we can call the correct function.

<rdar://problem/24599697> 

llvm-svn: 275281
2016-07-13 17:12:24 +00:00
..
cmake [LLDB][MIPS] Check if libatomic needs to be specified explicitly 2016-06-29 12:30:18 +00:00
docs Add support to debugserver for some new ways to interact with dyld 2016-07-07 01:09:23 +00:00
examples Fixup the "shadow" example command to use the function that takes an execution context now that the @lldb.command decorator does the right thing for the command function that takes 5 arguments. 2016-06-28 00:06:35 +00:00
include/lldb Centralize the way symbol and functions are looked up by making a Module::LookupInfo class that does all of the heavy lifting. 2016-07-13 17:12:24 +00:00
lit Replace hardcoded comment at 'lit.site.cfg.in' 2016-04-16 07:14:05 +00:00
lldb.xcodeproj Because of our lifetime rules w.r.t. ValueObjects and ClusterManagers, synthetic children caching is a tricky area: 2016-07-06 21:24:28 +00:00
lldb.xcworkspace Revert r275223, which committed the wrong thing. 2016-07-12 23:31:42 +00:00
packages/Python/lldbsuite This doesn't compiler on Darwin. Skipping it. 2016-07-12 23:06:28 +00:00
resources Bump the lldb version # in the xcode project files from 2016-03-15 04:36:11 +00:00
scripts Add LLVM build config for BuildAndIntegration. 2016-07-12 01:44:58 +00:00
source Centralize the way symbol and functions are looked up by making a Module::LookupInfo class that does all of the heavy lifting. 2016-07-13 17:12:24 +00:00
test Always rerun all tests on Windows. 2016-05-23 17:32:04 +00:00
third_party/Python/module Put progress.py back, apparently this can't be deleted. 2015-12-09 21:32:28 +00:00
tools Try to fix the OSX build with old SDK after r274725 2016-07-07 10:38:05 +00:00
unittests Fix a no newline at end of file warning. 2016-06-09 18:06:09 +00:00
utils Python 3: Modernize exception raising syntax. 2015-11-03 21:01:45 +00:00
www Update the website with lots of new info about building / testing. 2016-02-24 22:19:23 +00:00
.arcconfig
.clang-format Update .clang-format file to support break after return type. 2015-12-28 22:09:29 +00:00
.gitignore Revert r273524, it may have been the cause of a linux testbot failure 2016-06-23 04:24:16 +00:00
CMakeLists.txt [CMake] Update to requiring CMake 3.4.3 2016-05-31 20:21:44 +00:00
CODE_OWNERS.txt Added myself to the CODE_OWNERS.txt list for a few subsystems. 2015-11-09 01:24:36 +00:00
INSTALL.txt Revert the patch to Test Commit Access 2015-07-06 11:26:51 +00:00
LICENSE.TXT
use_lldb_suite_root.py Preparation for turning lldbsuite into a Python package. 2015-10-27 22:33:47 +00:00