llvm-project/lldb/tools/lldb-vscode
Greg Clayton 63e512100a Fix race condition when launching and attaching.
This is a modified version of a previous patch that was reverted: https://reviews.llvm.org/D119797
This version only waits for the process to stop when using "launchCommands" or "attachCommands"...

...and doesn't play with the async mode when doing normal launch/attach.

We discovered that when using "launchCommands" or "attachCommands" that there was an issue where these commands were not being run synchronously. There were further problems in this case where we would get thread events for the process that was just launched or attached before the IDE was ready, which is after "configurationDone" was sent to lldb-vscode.

This fix introduces the ability to wait for the process to stop after "launchCommands" or "attachCommands" are run to ensure that we have a stopped process point that is ready for the debug session to proceed. We spin up the thread that listens for process events before we start the launch or attach, but we don't want stop events being delivered through the DAP protocol until the "configurationDone" packet is received. We now always ignore the stop event with a stop ID of 1, which is the first stop. All normal launch and attach scenarios use the synchronous mode, and "launchCommands and "attachCommands" run an array of LLDB commands in async mode.

This should make our launch with "launchCommands" and attach with "attachCommands" avoid a race condition when the process is being launched or attached.

Differential Revision: https://reviews.llvm.org/D120755
2022-03-03 16:20:27 -08:00
..
syntaxes [lldb-vscode ]Add Syntax Highlighting to Disassembly View 2020-08-04 13:31:44 -07:00
BreakpointBase.cpp
BreakpointBase.h
CMakeLists.txt [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB 2022-01-19 12:49:47 +01:00
ExceptionBreakpoint.cpp
ExceptionBreakpoint.h [lldb-vscode] NFC: clang format 2020-08-17 09:18:01 -07:00
FifoFiles.cpp [lldb-vscode] correctly use Windows macros 2021-02-04 11:03:33 -08:00
FifoFiles.h Remove dependency from raw_ostream on <chrono> 2022-01-21 15:17:39 +01:00
FunctionBreakpoint.cpp [lldb-vscode] NFC: clang format 2020-08-17 09:18:01 -07:00
FunctionBreakpoint.h
IOStream.cpp [lldb-vscode] redirect stderr/stdout to the IDE's console 2021-04-21 14:48:48 -07:00
IOStream.h [lldb-vscode] correctly use Windows macros 2021-02-04 11:03:33 -08:00
JSONUtils.cpp [lldb-vscode] Add presentation hints for scopes 2021-11-09 17:50:46 +01:00
JSONUtils.h [lldb][NFC] Use C++ versions of the deprecated C standard library headers 2021-05-26 12:46:12 +02:00
LLDBUtils.cpp [lldb] [gdb-remote server] Introduce new stop reasons for fork and vfork 2021-04-24 11:08:33 +02:00
LLDBUtils.h
Options.td [vscode] Improve runInTerminal and support linux 2021-01-25 12:30:05 -08:00
OutputRedirector.cpp [lldb-vscode] redirect stderr/stdout to the IDE's console 2021-04-21 14:48:48 -07:00
OutputRedirector.h [lldb-vscode] redirect stderr/stdout to the IDE's console 2021-04-21 14:48:48 -07:00
ProgressEvent.cpp [vscode] fix ubsan problem in the progress event reporter 2021-07-12 13:22:25 -07:00
ProgressEvent.h Retry of [lldb-vscode] only report long running progress events 2021-06-21 20:33:09 -07:00
README.md
RunInTerminal.cpp [lldb-vscode] correctly use Windows macros 2021-02-04 11:03:33 -08:00
RunInTerminal.h Fix 0f0462cacf 2021-01-25 14:06:10 -08:00
SourceBreakpoint.cpp
SourceBreakpoint.h [lldb-vscode] NFC: clang format 2020-08-17 09:18:01 -07:00
SourceReference.h
VSCode.cpp Fix race condition when launching and attaching. 2022-03-03 16:20:27 -08:00
VSCode.h Fix race condition when launching and attaching. 2022-03-03 16:20:27 -08:00
VSCodeForward.h
lldb-vscode-Info.plist.in
lldb-vscode.cpp Fix race condition when launching and attaching. 2022-03-03 16:20:27 -08:00
package.json Fix race condition when launching and attaching. 2022-03-03 16:20:27 -08:00

README.md

Table of Contents

Introduction

The lldb-vscode tool creates a command line tool that implements the Visual Studio Code Debug API. It can be installed as an extension for the Visual Studio Code and Nuclide IDE. The protocol is easy to run remotely and also can allow other tools and IDEs to get a full featured debugger with a well defined protocol.

Installation for Visual Studio Code

Installing the plug-in involves creating a directory in the ~/.vscode/extensions folder and copying the package.json file that is in the same directory as this documentation into it, and copying to symlinking a lldb-vscode binary into the bin directory inside the plug-in directory.

If you want to make a stand alone plug-in that you can send to others on unix systems:

$ mkdir -p ~/.vscode/extensions/llvm-org.lldb-vscode-0.1.0/bin
$ cp package.json ~/.vscode/extensions/llvm-org.lldb-vscode-0.1.0
$ cd ~/.vscode/extensions/llvm-org.lldb-vscode-0.1.0/bin
$ cp /path/to/a/built/lldb-vscode .
$ cp /path/to/a/built/liblldb.so .

If you want to make a stand alone plug-in that you can send to others on macOS systems:

$ mkdir -p ~/.vscode/extensions/llvm-org.lldb-vscode-0.1.0/bin
$ cp package.json ~/.vscode/extensions/llvm-org.lldb-vscode-0.1.0
$ cd ~/.vscode/extensions/llvm-org.lldb-vscode-0.1.0/bin
$ cp /path/to/a/built/lldb-vscode .
$ rsync -av /path/to/a/built/LLDB.framework LLDB.framework

You might need to create additional directories for the liblldb.so or LLDB.framework inside or next to the bin folder depending on how the rpath is set in your lldb-vscode binary. By default the Debug builds of LLDB usually includes the current executable directory in the rpath, so these steps should work for most people.

To create a plug-in that symlinks into your lldb-vscode in your build directory:

$ mkdir -p ~/.vscode/extensions/llvm-org.lldb-vscode-0.1.0/bin
$ cp package.json ~/.vscode/extensions/llvm-org.lldb-vscode-0.1.0
$ cd ~/.vscode/extensions/llvm-org.lldb-vscode-0.1.0/bin
$ ln -s /path/to/a/built/lldb-vscode

This is handy if you want to debug and develope the lldb-vscode executable when adding features or fixing bugs.

Configurations

Launching to attaching require you to create a launch configuration. This file defines arguments that get passed to lldb-vscode and the configuration settings control how the launch or attach happens.

Launch Configuration Settings

When you launch a program with Visual Studio Code you will need to create a launch.json file that defines how your program will be run. The JSON configuration file can contain the following lldb-vscode specific launch key/value pairs:

parameter type req
name string Y A configuration name that will be displayed in the IDE.
type string Y Must be "lldb-vscode".
request string Y Must be "launch".
program string Y Path to the executable to launch.
args [string] An array of command line argument strings to be passed to the program being launched.
cwd string The program working directory.
env dictionary Environment variables to set when launching the program. The format of each environment variable string is "VAR=VALUE" for environment variables with values or just "VAR" for environment variables with no values.
stopOnEntry boolean Whether to stop program immediately after launching.
initCommands [string] LLDB commands executed upon debugger startup prior to creating the LLDB target. Commands and command output will be sent to the debugger console when they are executed.
preRunCommands [string] LLDB commands executed just before launching after the LLDB target has been created. Commands and command output will be sent to the debugger console when they are executed.
stopCommands [string] LLDB commands executed just after each stop. Commands and command output will be sent to the debugger console when they are executed.
exitCommands [string] LLDB commands executed when the program exits. Commands and command output will be sent to the debugger console when they are executed.
terminateCommands [string] LLDB commands executed when the debugging session ends. Commands and command output will be sent to the debugger console when they are executed.
sourceMap [string[2]] Specify an array of path re-mappings. Each element in the array must be a two element array containing a source and destination pathname.
debuggerRoot string Specify a working directory to use when launching lldb-vscode. If the debug information in your executable contains relative paths, this option can be used so that lldb-vscode can find source files and object files that have relative paths.

Attaching Settings

When attaching to a process using LLDB you can attach in a few ways

  1. Attach to an existing process using the process ID
  2. Attach to an existing process by name
  3. Attach by name by waiting for the next instance of a process to launch

The JSON configuration file can contain the following lldb-vscode specific launch key/value pairs:

parameter type req
name string Y A configuration name that will be displayed in the IDE.
type string Y Must be "lldb-vscode".
request string Y Must be "attach".
program string Path to the executable to attach to. This value is optional but can help to resolve breakpoints prior the attaching to the program.
pid number The process id of the process you wish to attach to. If pid is omitted, the debugger will attempt to attach to the program by finding a process whose file name matches the file name from porgram. Setting this value to ${command:pickMyProcess} will allow interactive process selection in the IDE.
stopOnEntry boolean Whether to stop program immediately after launching.
waitFor boolean Wait for the process to launch.
initCommands [string] LLDB commands executed upon debugger startup prior to creating the LLDB target. Commands and command output will be sent to the debugger console when they are executed.
preRunCommands [string] LLDB commands executed just before launching after the LLDB target has been created. Commands and command output will be sent to the debugger console when they are executed.
stopCommands [string] LLDB commands executed just after each stop. Commands and command output will be sent to the debugger console when they are executed.
exitCommands [string] LLDB commands executed when the program exits. Commands and command output will be sent to the debugger console when they are executed.
terminateCommands [string] LLDB commands executed when the debugging session ends. Commands and command output will be sent to the debugger console when they are executed.
attachCommands [string] LLDB commands that will be executed after preRunCommands which take place of the code that normally does the attach. The commands can create a new target and attach or launch it however desired. This allows custom launch and attach configurations. Core files can use target create --core /path/to/core to attach to core files.

Example configurations

Launching

This will launch /tmp/a.out with arguments one, two, and three and adds FOO=1 and bar to the environment:

{
  "type": "lldb-vscode",
  "request": "launch",
  "name": "Debug",
  "program": "/tmp/a.out",
  "args": [ "one", "two", "three" ],
  "env": [ "FOO=1", "BAR" ],
}

Attach using PID

This will attach to a process a.out whose process ID is 123:

{
  "type": "lldb-vscode",
  "request": "attach",
  "name": "Attach to PID",
  "program": "/tmp/a.out",
  "pid": 123
}

Attach by Name

This will attach to an existing process whose base name matches a.out. All we have to do is leave the pid value out of the above configuration:

{
  "name": "Attach to Name",
  "type": "lldb-vscode",
  "request": "attach",
  "program": "/tmp/a.out",
}

If you want to ignore any existing a.out processes and wait for the next instance to be launched you can add the "waitFor" key value pair:

{
  "name": "Attach to Name (wait)",
  "type": "lldb-vscode",
  "request": "attach",
  "program": "/tmp/a.out",
  "waitFor": true
}

This will work as long as the architecture, vendor and OS supports waiting for processes. Currently MacOS is the only platform that supports this.

Loading a Core File

This loads the coredump file /cores/123.core associated with the program /tmp/a.out:

{
  "name": "Load coredump",
  "type": "lldb-vscode",
  "request": "attach",
  "coreFile": "/cores/123.core",
  "program": "/tmp/a.out"
}