Go to file
Teresa Johnson 5f312ad450 [ThinLTO] Consolidate cache key computation between new/old LTO APIs
Summary:
The old legacy LTO API had a separate cache key computation, which was
a subset of the cache key computation in the new LTO API (from what I
can tell this is largely just because certain features such as CFI,
dsoLocal, etc are only utilized via the new LTO API). However, having
separate computations is unnecessary (much of the code is duplicated),
and can lead to bugs when adding new optimizations if both cache
computation algorithms aren't updated properly - it's much easier to
maintain if we have a single facility.

This patch refactors the old LTO API code to use the cache key
computation from the new LTO API. To do this, we set up an lto::Config
object and fill in the fields that the old LTO was hashing (the others
will just use the defaults).

There are two notable changes:
- I added a Freestanding flag to the LTO Config. Currently this is only
used by the legacy LTO API. In the patch that added it (D30791) I had
asked about adding it to the new LTO API, but it looks like that was not
addressed. This should probably be discussed as a follow up to this
change, as it is orthogonal.
- The legacy LTO API had some code that was hashing the GUID of all
preserved symbols defined in the module. I looked back at the history of
this (which was added with the original hashing in the legacy LTO API in
D18494), and there is a comment in the review thread that it was added
in preparation for future internalization. We now do the internalization
of course, and that is handled in the new LTO API cache key computation
by hashing the recorded linkage type of all defined globals. Therefore I
didn't try to move over and keep the preserved symbols handling.

Reviewers: steven_wu, pcc

Subscribers: mehdi_amini, inglorion, eraman, dexonsmith, dang, llvm-commits

Differential Revision: https://reviews.llvm.org/D54635

llvm-svn: 347592
2018-11-26 20:40:37 +00:00
clang Revert "[clang][slh] add attribute for speculative load hardening" 2018-11-26 20:11:18 +00:00
clang-tools-extra [clangd] Do not drop diagnostics from macros 2018-11-26 17:05:13 +00:00
compiler-rt [X86][compiler-rt] Add missing semicolon 2018-11-24 20:57:03 +00:00
debuginfo-tests Set config.lit_tools_dir, which is needed by lit.llvm.initialize. 2018-11-06 21:54:27 +00:00
libclc r600: Add datalayout to image builtin implementation 2018-11-10 21:43:40 +00:00
libcxx Add basic_string::__resize_default_init (from P1072) 2018-11-26 20:15:38 +00:00
libcxxabi [CMake] Passthrough CFLAGS when checking the compiler-rt path 2018-11-14 00:09:26 +00:00
libunwind [CMake] Passthrough CFLAGS when checking the compiler-rt path 2018-11-14 00:09:26 +00:00
lld [COFF] ICF: use parallelForEach{,N} 2018-11-26 20:07:07 +00:00
lldb [lit] Fully qualify lit_config to avoid runtime crashes. 2018-11-26 17:39:20 +00:00
llgo Update copyright year to 2018. 2018-06-18 12:22:17 +00:00
llvm [ThinLTO] Consolidate cache key computation between new/old LTO APIs 2018-11-26 20:40:37 +00:00
openmp [OPENMP][NVPTX]Improved lock/critical constructs. 2018-11-20 20:19:36 +00:00
parallel-libs Update copyright year to 2018. 2018-06-18 12:22:17 +00:00
polly [CMake] Fix generation of exported targets in build directory 2018-11-06 15:18:17 +00:00
README.md Update the project name in README.md 2018-10-19 00:03:01 +00:00

README.md

The LLVM Compiler Infrastructure

This directory and its subdirectories contain source code for LLVM, a toolkit for the construction of highly optimized compilers, optimizers, and runtime environments.