llvm-project/clang/lib/CodeGen
George Burgess IV d0a9e807f3 [CodeGen] Fix ExtParameterInfo bugs in C++ CodeGen code.
This patch makes use of the prefix/suffix ABI argument distinction that
was introduced in r295870, so that we now emit ExtParameterInfo at the
correct offset for member calls that have added ABI arguments. I don't
see a good way to test the generated param info, since we don't actually
seem to use it in CGFunctionInfo outside of Swift. Any
suggestions/thoughts for how to better test this are welcome. :)

This patch also fixes a small bug with inheriting constructors: if we
decide not to pass args into an base class ctor, we would still
generate ExtParameterInfo as though we did. The added test-case is for
that behavior.

llvm-svn: 296024
2017-02-23 22:07:35 +00:00
..
ABIInfo.h [IRGen] Make header standalone. 2017-01-30 15:39:18 +00:00
Address.h Work around build failure due to GCC 4.8.1 bug. We don't completely understand 2016-02-02 23:11:49 +00:00
BackendUtil.cpp Only enable AddDiscriminator pass when -fdebug-info-for-profiling is true 2017-02-21 20:36:21 +00:00
CGAtomic.cpp Refactor call emission to package the function pointer together with 2016-10-26 23:46:34 +00:00
CGBlocks.cpp [CodeGen][ObjC] Use the type of the captured field of the enclosing 2017-02-14 06:46:55 +00:00
CGBlocks.h [CodeGen][ObjC] Block captures should inherit the type of the captured 2016-09-16 00:02:06 +00:00
CGBuilder.h IRGen: Remove an unused overload of CreateAlignedLoad. 2016-12-05 00:02:18 +00:00
CGBuiltin.cpp [CodeGen] Don't reemit expressions for pass_object_size params. 2017-02-23 05:59:56 +00:00
CGCUDANV.cpp ConstantBuilder -> ConstantInitBuilder for clarity, and 2016-11-28 22:18:27 +00:00
CGCUDARuntime.cpp Refactor call emission to package the function pointer together with 2016-10-26 23:46:34 +00:00
CGCUDARuntime.h [CUDA] Emit host-side 'shadows' for device-side global variables 2016-03-02 18:28:50 +00:00
CGCXX.cpp CodeGen: New vtable group representation: struct of vtable arrays. 2016-12-13 20:40:39 +00:00
CGCXXABI.cpp Refactor call emission to package the function pointer together with 2016-10-26 23:46:34 +00:00
CGCXXABI.h [CodeGen] Note where we add ABI-specific args in ctors. NFC. 2017-02-22 20:28:02 +00:00
CGCall.cpp [CodeGen] Fix ExtParameterInfo bugs in C++ CodeGen code. 2017-02-23 22:07:35 +00:00
CGCall.h Name some anonymous structs to avoid using a (very common) extension. 2016-11-07 21:13:27 +00:00
CGClass.cpp [CodeGen] Fix ExtParameterInfo bugs in C++ CodeGen code. 2017-02-23 22:07:35 +00:00
CGCleanup.cpp Retire llvm::alignOf in favor of C++11 alignof. 2016-10-20 14:27:22 +00:00
CGCleanup.h Use the correct ObjC EH personality 2017-01-08 22:58:07 +00:00
CGCoroutine.cpp [coroutines] Add allocation and deallocation substatements. 2016-10-27 16:28:31 +00:00
CGDebugInfo.cpp Fix assertion failure when generating debug information for a variable 2017-02-22 00:13:14 +00:00
CGDebugInfo.h [DebugInfo] Added support to Clang FE for generating debug info for preprocessor macros. 2017-02-09 22:07:24 +00:00
CGDecl.cpp Add an explicit derived class of FunctionDecl to model deduction guides rather 2017-02-17 20:05:37 +00:00
CGDeclCXX.cpp Improve handling of instantiated thread_local variables in Itanium C++ ABI. 2017-01-13 00:43:31 +00:00
CGException.cpp stop using associative comdats for SEH filter functions 2017-02-22 20:29:39 +00:00
CGExpr.cpp Rename a helper function, NFC. 2017-02-23 01:22:38 +00:00
CGExprAgg.cpp Fix problems in "[OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare operand." 2016-12-23 14:55:49 +00:00
CGExprCXX.cpp [CodeGen] Fix ExtParameterInfo bugs in C++ CodeGen code. 2017-02-23 22:07:35 +00:00
CGExprComplex.cpp Fix problems in "[OpenCL] Enabling the usage of CLK_NULL_QUEUE as compare operand." 2016-12-23 14:55:49 +00:00
CGExprConstant.cpp [CodeGen] Unique constant CompoundLiterals. 2016-12-28 07:27:40 +00:00
CGExprScalar.cpp [ObjC][CodeGen] CodeGen support for @available. 2017-02-23 21:08:08 +00:00
CGGPUBuiltin.cpp [OpenMP][NVPTX][CUDA] Adding support for printf for an NVPTX OpenMP device. 2017-01-29 20:49:31 +00:00
CGLoopInfo.cpp [CodeGen] Pass objects that are expensive to copy by const ref. 2016-11-24 16:01:20 +00:00
CGLoopInfo.h [CodeGen] Pass objects that are expensive to copy by const ref. 2016-11-24 16:01:20 +00:00
CGObjC.cpp [ObjC][CodeGen] CodeGen support for @available. 2017-02-23 21:08:08 +00:00
CGObjCGNU.cpp Clean up CGObjCMac's APIs for deriving class references. NFC. 2016-11-30 23:54:50 +00:00
CGObjCMac.cpp Clean up CGObjCMac's APIs for deriving class references. NFC. 2016-11-30 23:54:50 +00:00
CGObjCRuntime.cpp CodeGen: ensure that the runtime calling convention matches 2016-10-13 19:45:08 +00:00
CGObjCRuntime.h Clean up CGObjCMac's APIs for deriving class references. NFC. 2016-11-30 23:54:50 +00:00
CGOpenCLRuntime.cpp [OpenCL] Correct ndrange_t implementation 2017-02-16 12:27:47 +00:00
CGOpenCLRuntime.h [OpenCL] Augment pipe built-ins with pipe packet size and alignment. 2016-09-23 14:20:00 +00:00
CGOpenMPRuntime.cpp [OpenMP] Fix cancellation point in task with no cancel 2017-02-17 18:32:58 +00:00
CGOpenMPRuntime.h [OpenMP] Parallel reduction on the NVPTX device. 2017-02-16 16:20:16 +00:00
CGOpenMPRuntimeNVPTX.cpp [OpenMP] Teams reduction on the NVPTX device. 2017-02-16 16:48:49 +00:00
CGOpenMPRuntimeNVPTX.h [OpenMP] Parallel reduction on the NVPTX device. 2017-02-16 16:20:16 +00:00
CGRecordLayout.h Make CodeGen headers self-contained. 2016-02-02 16:05:18 +00:00
CGRecordLayoutBuilder.cpp revert SVN r265702, r265640 2016-04-08 16:52:00 +00:00
CGStmt.cpp [OpenMP] Sema and parsing for 'target teams distribute simd’ pragma 2017-01-10 18:08:18 +00:00
CGStmtOpenMP.cpp [OpenMP] Teams reduction on the NVPTX device. 2017-02-16 16:48:49 +00:00
CGVTT.cpp CodeGen: Start using inrange annotations on vtable getelementptr. 2016-12-13 20:50:44 +00:00
CGVTables.cpp [CodeGen] Fix ExtParameterInfo bugs in C++ CodeGen code. 2017-02-23 22:07:35 +00:00
CGVTables.h CodeGen: New vtable group representation: struct of vtable arrays. 2016-12-13 20:40:39 +00:00
CGValue.h [Sema] PR26444 fix crash when alignment value is >= 2**16 2016-03-02 06:48:47 +00:00
CMakeLists.txt [DebugInfo] Added support to Clang FE for generating debug info for preprocessor macros. 2017-02-09 22:07:24 +00:00
CodeGenABITypes.cpp Various improvements to the public IRGen interface. 2016-05-18 05:21:18 +00:00
CodeGenAction.cpp Rename DiagnosticInfoWithDebugLoc to WithLocation to match LLVM 2017-02-17 17:34:49 +00:00
CodeGenFunction.cpp Retry^2: [ubsan] Reduce null checking of C++ object pointers (PR27581) 2017-02-17 23:22:59 +00:00
CodeGenFunction.h [ObjC][CodeGen] CodeGen support for @available. 2017-02-23 21:08:08 +00:00
CodeGenModule.cpp [dllimport] Check for dtor references in functions 2017-02-15 23:28:10 +00:00
CodeGenModule.h [ObjC][CodeGen] CodeGen support for @available. 2017-02-23 21:08:08 +00:00
CodeGenPGO.cpp Reuse a local variable. NFC. 2017-02-18 01:50:11 +00:00
CodeGenPGO.h [NFC] Header cleanup 2016-07-18 19:02:11 +00:00
CodeGenTBAA.cpp revert SVN r265702, r265640 2016-04-08 16:52:00 +00:00
CodeGenTBAA.h Make the remaining headers self-contained. 2016-02-02 14:24:21 +00:00
CodeGenTypeCache.h Re-commit [OpenCL] AMDGCN: Fix size_t type 2016-08-19 05:17:25 +00:00
CodeGenTypes.cpp [OpenCL] Correct ndrange_t implementation 2017-02-16 12:27:47 +00:00
CodeGenTypes.h [CodeGen] Fix ExtParameterInfo bugs in C++ CodeGen code. 2017-02-23 22:07:35 +00:00
ConstantBuilder.h Struct GEPs must use i32, not whatever size_t is. It should be safe 2016-12-01 23:51:30 +00:00
CoverageMappingGen.cpp Fix use-of-temporary with StringRef in code coverage 2016-11-07 17:28:04 +00:00
CoverageMappingGen.h [NFC] Header cleanup 2016-07-18 19:02:11 +00:00
EHScopeStack.h Retire llvm::alignOf in favor of C++11 alignof. 2016-10-20 14:27:22 +00:00
ItaniumCXXABI.cpp [CodeGen] Note where we add ABI-specific args in ctors. NFC. 2017-02-22 20:28:02 +00:00
MacroPPCallbacks.cpp Update C style comments to C++ style. 2017-02-10 00:20:26 +00:00
MacroPPCallbacks.h Wdocumentation fixes 2017-02-10 12:14:01 +00:00
MicrosoftCXXABI.cpp [CodeGen] Fix ExtParameterInfo bugs in C++ CodeGen code. 2017-02-23 22:07:35 +00:00
ModuleBuilder.cpp [DebugInfo] Added support to Clang FE for generating debug info for preprocessor macros. 2017-02-09 22:07:24 +00:00
ObjectFilePCHContainerOperations.cpp CodeGen: plumb header search down to the IAS 2017-01-05 16:02:32 +00:00
README.txt
SanitizerMetadata.cpp Implement no_sanitize_address for global vars 2016-10-14 19:55:09 +00:00
SanitizerMetadata.h
SwiftCallingConv.cpp swiftcc: Add an api to query whether a target ABI stores swifterror in a register 2016-12-01 18:07:38 +00:00
TargetInfo.cpp CodeGen: use # as the comment leader for ARC marker 2017-02-11 23:03:13 +00:00
TargetInfo.h Re-commit r289252 and r289285, and fix PR31374 2016-12-15 08:09:08 +00:00
VarBypassDetector.cpp [CodeGen] Don't emit lifetime intrinsics for some local variables 2016-10-26 05:42:30 +00:00
VarBypassDetector.h [CodeGen] Don't emit lifetime intrinsics for some local variables 2016-10-26 05:42:30 +00:00

README.txt

IRgen optimization opportunities.

//===---------------------------------------------------------------------===//

The common pattern of
--
short x; // or char, etc
(x == 10)
--
generates an zext/sext of x which can easily be avoided.

//===---------------------------------------------------------------------===//

Bitfields accesses can be shifted to simplify masking and sign
extension. For example, if the bitfield width is 8 and it is
appropriately aligned then is is a lot shorter to just load the char
directly.

//===---------------------------------------------------------------------===//

It may be worth avoiding creation of alloca's for formal arguments
for the common situation where the argument is never written to or has
its address taken. The idea would be to begin generating code by using
the argument directly and if its address is taken or it is stored to
then generate the alloca and patch up the existing code.

In theory, the same optimization could be a win for block local
variables as long as the declaration dominates all statements in the
block.

NOTE: The main case we care about this for is for -O0 -g compile time
performance, and in that scenario we will need to emit the alloca
anyway currently to emit proper debug info. So this is blocked by
being able to emit debug information which refers to an LLVM
temporary, not an alloca.

//===---------------------------------------------------------------------===//

We should try and avoid generating basic blocks which only contain
jumps. At -O0, this penalizes us all the way from IRgen (malloc &
instruction overhead), all the way down through code generation and
assembly time.

On 176.gcc:expr.ll, it looks like over 12% of basic blocks are just
direct branches!

//===---------------------------------------------------------------------===//