forked from OSchip/llvm-project
7a96942a6a
The needed lld matching changes to be submitted immediately next, but this revision will cause lld failures with this alone which is expected. This removes the eating of the error in Archive::Child::getSize() when the characters in the size field in the archive header for the member is not a number. To do this we have all of the needed methods return ErrorOr to push them up until we get out of lib. Then the tools and can handle the error in whatever way is appropriate for that tool. So the solution is to plumb all the ErrorOr stuff through everything that touches archives. This include its iterators as one can create an Archive object but the first or any other Child object may fail to be created due to a bad size field in its header. Thanks to Lang Hames on the changes making child_iterator contain an ErrorOr<Child> instead of a Child and the needed changes to ErrorOr.h to add operator overloading for * and -> . We don’t want to use llvm_unreachable() as it calls abort() and is produces a “crash” and using report_fatal_error() to move the error checking will cause the program to stop, neither of which are really correct in library code. There are still some uses of these that should be cleaned up in this library code for other than the size field. The test cases use archives with text files so one can see the non-digit character, in this case a ‘%’, in the size field. These changes will require corresponding changes to the lld project. That will be committed immediately after this change. But this revision will cause lld failures with this alone which is expected. llvm-svn: 252192 |
||
|---|---|---|
| .. | ||
| BinaryHolder.cpp | ||
| BinaryHolder.h | ||
| CMakeLists.txt | ||
| DebugMap.cpp | ||
| DebugMap.h | ||
| DwarfLinker.cpp | ||
| LLVMBuild.txt | ||
| MachODebugMapParser.cpp | ||
| MachOUtils.cpp | ||
| MachOUtils.h | ||
| Makefile | ||
| NonRelocatableStringpool.h | ||
| dsymutil.cpp | ||
| dsymutil.h | ||