llvm-project/llvm
Sanjay Patel 5bd36644c8 [InstCombine] fix shuffle-of-binops transform to avoid poison/undef
As noted in D48987, there are many different ways for this transform to go wrong. 
In particular, the poison potential for shifts means we have to more careful with those ops. 
I added tests to make that behavior visible for all of the different cases that I could find.

This is a partial fix. To make this review easier, I did not make changes for the single binop 
pattern (handled in foldSelectShuffleWith1Binop()). I also left out some potential optimizations 
noted with TODO comments. I'll follow-up once we're confident that things are correct here.

The goal is to correct all marked FIXME tests to either avoid the shuffle transform or do it safely.

Note that distinguishing when the shuffle mask contains undefs and using getBinOpIdentity() allows 
for some improvements to div/rem patterns, so there are wins along with the missed opportunities 
and fixes.

Differential Revision: https://reviews.llvm.org/D49047

llvm-svn: 336546
2018-07-09 13:21:46 +00:00
..
bindings
cmake [cmake] Change WIN32 test to CMAKE_HOST_WIN32 2018-06-29 10:34:37 +00:00
docs nm: Add -no-weak flag for hiding weak symbols 2018-07-02 17:24:37 +00:00
examples [ORC] Update JITCompileCallbackManager to support multi-threaded code. 2018-05-30 01:57:45 +00:00
include [Support] Allow JSON serialization of Optional<T> for supported T. 2018-07-09 12:26:09 +00:00
lib [InstCombine] fix shuffle-of-binops transform to avoid poison/undef 2018-07-09 13:21:46 +00:00
projects
resources
runtimes Support for multiarch runtimes layout 2018-06-28 03:11:52 +00:00
test [InstCombine] fix shuffle-of-binops transform to avoid poison/undef 2018-07-09 13:21:46 +00:00
tools [llvm-mca] report an error if the assembly sequence contains an unsupported instruction. 2018-07-09 12:30:55 +00:00
unittests [Support] Allow JSON serialization of Optional<T> for supported T. 2018-07-09 12:26:09 +00:00
utils [TableGen] Increase the number of supported decoder fix-ups. 2018-07-05 10:39:15 +00:00
.arcconfig
.clang-format
.clang-tidy
.gitattributes
.gitignore
CMakeLists.txt Support for multiarch runtimes layout 2018-06-28 03:11:52 +00:00
CODE_OWNERS.TXT CODE_OWNERS: Take ownership of the MIPS backend 2018-06-21 09:59:44 +00:00
CREDITS.TXT Update my information in the CREDITS file. 2018-06-15 20:02:11 +00:00
LICENSE.TXT Update copyright year to 2018. 2018-06-18 12:22:17 +00:00
LLVMBuild.txt
README.txt Test commit: remove a blank line 2018-06-08 21:21:55 +00:00
RELEASE_TESTERS.TXT Remove myself from the release testers list. (NFC) 2018-06-20 21:25:50 +00:00
configure
llvm.spec.in

README.txt

The LLVM Compiler Infrastructure
================================

This directory and its subdirectories contain source code for LLVM,
a toolkit for the construction of highly optimized compilers,
optimizers, and runtime environments.

LLVM is open source software. You may freely distribute it under the terms of
the license agreement found in LICENSE.txt.

Please see the documentation provided in docs/ for further
assistance with LLVM, and in particular docs/GettingStarted.rst for getting
started with LLVM and docs/README.txt for an overview of LLVM's
documentation setup.

If you are writing a package for LLVM, see docs/Packaging.rst for our
suggestions.