forked from OSchip/llvm-project
e56626e438
D68041 placed `__profc_`, `__profd_` and (if exists) `__profvp_` in different comdat groups.
There are some issues:
* Cost: one or two additional section headers (`.group` section(s)): 64 or 128 bytes on ELF64.
* `__profc_`, `__profd_` and (if exists) `__profvp_` should be retained or
discarded. Placing them into separate comdat groups is conceptually inferior.
* If the prevailing group does not include `__profvp_` (value profiling not
used) but a non-prevailing group from another translation unit has `__profvp_`
(the function is inlined into another and triggers value profiling), there
will be a stray `__profvp_` if --gc-sections is not enabled.
This has been fixed by
|
||
---|---|---|
.. | ||
Inputs | ||
X86 | ||
PR28219.ll | ||
PR41279.ll | ||
PR41279_2.ll | ||
branch1.ll | ||
branch2.ll | ||
callbr.ll | ||
chr.ll | ||
comdat_internal.ll | ||
comdat_rename.ll | ||
counter_promo.ll | ||
counter_promo_exit_catchswitch.ll | ||
counter_promo_exit_merge.ll | ||
counter_promo_mexits.ll | ||
counter_promo_nest.ll | ||
criticaledge.ll | ||
cspgo_profile_summary.ll | ||
diag_FE_profile.ll | ||
diag_mismatch.ll | ||
diag_no_funcprofdata.ll | ||
diag_no_profile.ll | ||
diag_no_value_sites.ll | ||
do-not-instrument.ll | ||
fix_entry_count.ll | ||
func_entry.ll | ||
icp_covariant_call_return.ll | ||
icp_covariant_invoke_return.ll | ||
icp_invoke.ll | ||
icp_invoke_nouse.ll | ||
icp_mismatch_msg.ll | ||
icp_sample.ll | ||
icp_vararg.ll | ||
icp_vararg_sret.ll | ||
indirect_call_annotation.ll | ||
indirect_call_profile.ll | ||
indirect_call_profile_funclet.ll | ||
indirect_call_promotion.ll | ||
indirect_call_promotion_byval.ll | ||
indirect_call_promotion_musttail.ll | ||
indirect_call_promotion_vla.ll | ||
indirectbr.ll | ||
infinite_loop.ll | ||
infinite_loop_gen.ll | ||
instr_entry_bb.ll | ||
irreducible.ll | ||
landingpad.ll | ||
large_count_remarks.ll | ||
loop1.ll | ||
loop2.ll | ||
memcpy.ll | ||
memop_clone.ll | ||
memop_hash.ll | ||
memop_profile_funclet.ll | ||
memop_size_annotation.ll | ||
memop_size_from_strlen.ll | ||
memop_size_opt.ll | ||
memop_size_opt_zero.ll | ||
misexpect-branch-correct.ll | ||
misexpect-branch-stripped.ll | ||
misexpect-branch-unpredictable.ll | ||
misexpect-branch.ll | ||
misexpect-switch-default.ll | ||
misexpect-switch.ll | ||
multiple_hash_profile.ll | ||
noreturncall.ll | ||
not_promote_ret_exit.ll | ||
preinline.ll | ||
remap.ll | ||
select1.ll | ||
select2.ll | ||
select_hash_conflict.ll | ||
single_bb.ll | ||
split-indirectbr-critical-edges.ll | ||
statics_counter_naming.ll | ||
suppl-profile.ll | ||
switch.ll | ||
thinlto_cspgo_gen.ll | ||
thinlto_cspgo_use.ll | ||
thinlto_indirect_call_promotion.ll | ||
thinlto_samplepgo_icp.ll | ||
thinlto_samplepgo_icp2.ll | ||
thinlto_samplepgo_icp3.ll | ||
thinlto_samplepgo_icp_droppeddead.ll | ||
unreachable_bb.ll |