llvm-project/clang-tools-extra/clangd
Benjamin Kramer d3326a04e0 [Clangd] Failed to decode params using 1.x-compatible request message
textDocument/completion sends a TextDocumentPositionParams message in the 2.x
and 3.x. But in 1.x it was instead a TextDocumentPosition with inlined
parameters. This means that the "uri" field is at the top level and not in
textDocument. Because of this, some clients that maintain compability with 1.x
have both uri and textDocument.uri. Clangd, however, early returns in the
presence of anything but 'textDocument' or 'position' which prevents a client
compatible with both 3.x and 1.x to work correctly. If Clangd was a bit more
permissive (no early return), clients implementing all the versions of the
protocol would work.

Patch by Marc-Andre Laperle!

Differential Revision: https://reviews.llvm.org/D32238

llvm-svn: 300991
2017-04-21 15:51:23 +00:00
..
clients/clangd-vscode [clangd] Extract FsPath from file:// uri 2017-04-07 11:03:26 +00:00
ASTManager.cpp [clangd] Implement item kind for completion results 2017-04-11 13:27:15 +00:00
ASTManager.h [clangd] Remove ASTUnits for closed documents and cache CompilationDatabase per directory. 2017-04-10 13:31:39 +00:00
CMakeLists.txt [clangd] Rename ClangDMain.cpp -> ClangdMain.cpp, NFC 2017-04-12 17:13:08 +00:00
ClangdMain.cpp [clangd] Rename ClangDMain.cpp -> ClangdMain.cpp, NFC 2017-04-12 17:13:08 +00:00
DocumentStore.h [clangd] Extract FsPath from file:// uri 2017-04-07 11:03:26 +00:00
JSONRPCDispatcher.cpp [clangd] Synchronize logs access. 2017-02-15 16:44:11 +00:00
JSONRPCDispatcher.h [clangd] Synchronize logs access. 2017-02-15 16:44:11 +00:00
Protocol.cpp [Clangd] Failed to decode params using 1.x-compatible request message 2017-04-21 15:51:23 +00:00
Protocol.h [clangd] Remove ASTUnits for closed documents and cache CompilationDatabase per directory. 2017-04-10 13:31:39 +00:00
ProtocolHandlers.cpp [clangd] Remove ASTUnits for closed documents and cache CompilationDatabase per directory. 2017-04-10 13:31:39 +00:00
ProtocolHandlers.h [clangd] Remove ASTUnits for closed documents and cache CompilationDatabase per directory. 2017-04-10 13:31:39 +00:00