llvm-project/libcxxabi
Louis Dionne 8d51969bd4 [runtimes] Avoid overwriting the rpath unconditionally
When building the runtimes, it's very important not to add rpaths unless
the user explicitly asks for them (the standard way being CMAKE_INSTALL_RPATH),
or to change the install name dir unless the user requests it (via
CMAKE_INSTALL_NAME_DIR).

llvm_setup_rpath() would override the install_name_dir of the runtimes
even if CMAKE_INSTALL_NAME_DIR was specified to something, which is wrong
and in fact even "dangerous" for the runtimes.

This issue was discovered when trying to build libc++ and libc++abi as
system libraries for Apple, where we set the install name dir to /usr/lib
explicitly. llvm_setup_rpath() would cause libc++ to have the wrong install
name dir, and for basically everything on the system to fail to load.
This was discovered just now because we previously used something closer
to a standalone build, where llvm_setup_rpath() wouldn't exist, and hence
not be used.

This is a revert of the following commits:

  libunwind: 3a667b9bd8
  libc++abi: 4877063e19
  libc++: 88434fe05f

Those added llvm_setup_rpath() for consistency, so it seems reasonable
to revert.

Differential Revision: https://reviews.llvm.org/D91099
2020-11-09 16:56:03 -05:00
..
cmake [libcxxabi,libunwind] support running tests in standalone mode 2020-10-14 09:10:20 +02:00
fuzz add cxa_demangle_fuzzer 2016-12-28 03:28:29 +00:00
include [libcxxabi] Define _LIBCXXABI_WEAK properly for mingw compilers 2020-10-22 09:00:57 +03:00
lib [libc++/abi] Revert "[libc++] Move the weak symbols list to libc++abi" 2020-10-05 11:42:13 -04:00
src [runtimes] Avoid overwriting the rpath unconditionally 2020-11-09 16:56:03 -05:00
test Revert "Allow running back-deployment testing against libc++abi" 2020-11-06 17:26:42 -05:00
www [libc++abi] Simplify the logic for finding libc++ from libc++abi 2020-06-11 15:08:01 -04:00
.clang-format Fully Reformat fallback_malloc.cpp 2017-03-04 03:23:15 +00:00
.gitignore
CMakeLists.txt [libcxx] [libcxxabi] Set flags for visibility when statically linking libcxxabi into libcxx for windows 2020-11-03 17:13:48 +02:00
CREDITS.TXT Try again, this time with the correct address 2017-12-29 19:26:28 +00:00
LICENSE.TXT Fix typos throughout the license files that somehow I and my reviewers 2019-01-21 09:52:34 +00:00