forked from OSchip/llvm-project
532290e69f
Summary:
The FileSpec class is often used as a sort of a pattern -- one specifies
a bare file name to search, and we check if in matches the full file
name of an existing module (for example).
These comparisons used FileSpec::Equal, which had some support for it
(via the full=false argument), but it was not a good fit for this job.
For one, it did a symmetric comparison, which makes sense for a function
called "equal", but not for typical searches (when searching for
"/foo/bar.so", we don't want to find a module whose name is just
"bar.so"). This resulted in patterns like:
if (FileSpec::Equal(pattern, file, pattern.GetDirectory()))
which would request a "full" match only if the pattern really contained
a directory. This worked, but the intended behavior was very unobvious.
On top of that, a lot of the code wanted to handle the case of an
"empty" pattern, and treat it as matching everything. This resulted in
conditions like:
if (pattern && !FileSpec::Equal(pattern, file, pattern.GetDirectory())
which are nearly impossible to decipher.
This patch introduces a FileSpec::Match function, which does exactly
what most of FileSpec::Equal callers want, an asymmetric match between a
"pattern" FileSpec and a an actual FileSpec. Empty paterns match
everything, filename-only patterns match only the filename component.
I've tried to update all callers of FileSpec::Equal to use a simpler
interface. Those that hardcoded full=true have been changed to use
operator==. Those passing full=pattern.GetDirectory() have been changed
to use FileSpec::Match.
There was also a handful of places which hardcoded full=false. I've
changed these to use FileSpec::Match too. This is a slight change in
semantics, but it does not look like that was ever intended, and it was
more likely a result of a misunderstanding of the "proper" way to use
FileSpec::Equal.
[In an ideal world a "FileSpec" and a "FileSpec pattern" would be two
different types, but given how widespread FileSpec is, it is unlikely
we'll get there in one go. This at least provides a good starting point
by centralizing all matching behavior.]
Reviewers: teemperor, JDevlieghere, jdoerfert
Subscribers: emaste, lldb-commits
Tags: #lldb
Differential Revision: https://reviews.llvm.org/D70851
|
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| CommandCompletions.cpp | ||
| CommandObjectApropos.cpp | ||
| CommandObjectApropos.h | ||
| CommandObjectBreakpoint.cpp | ||
| CommandObjectBreakpoint.h | ||
| CommandObjectBreakpointCommand.cpp | ||
| CommandObjectBreakpointCommand.h | ||
| CommandObjectCommands.cpp | ||
| CommandObjectCommands.h | ||
| CommandObjectDisassemble.cpp | ||
| CommandObjectDisassemble.h | ||
| CommandObjectExpression.cpp | ||
| CommandObjectExpression.h | ||
| CommandObjectFrame.cpp | ||
| CommandObjectFrame.h | ||
| CommandObjectGUI.cpp | ||
| CommandObjectGUI.h | ||
| CommandObjectHelp.cpp | ||
| CommandObjectHelp.h | ||
| CommandObjectLanguage.cpp | ||
| CommandObjectLanguage.h | ||
| CommandObjectLog.cpp | ||
| CommandObjectLog.h | ||
| CommandObjectMemory.cpp | ||
| CommandObjectMemory.h | ||
| CommandObjectMultiword.cpp | ||
| CommandObjectPlatform.cpp | ||
| CommandObjectPlatform.h | ||
| CommandObjectPlugin.cpp | ||
| CommandObjectPlugin.h | ||
| CommandObjectProcess.cpp | ||
| CommandObjectProcess.h | ||
| CommandObjectQuit.cpp | ||
| CommandObjectQuit.h | ||
| CommandObjectRegister.cpp | ||
| CommandObjectRegister.h | ||
| CommandObjectReproducer.cpp | ||
| CommandObjectReproducer.h | ||
| CommandObjectSettings.cpp | ||
| CommandObjectSettings.h | ||
| CommandObjectSource.cpp | ||
| CommandObjectSource.h | ||
| CommandObjectStats.cpp | ||
| CommandObjectStats.h | ||
| CommandObjectTarget.cpp | ||
| CommandObjectTarget.h | ||
| CommandObjectThread.cpp | ||
| CommandObjectThread.h | ||
| CommandObjectType.cpp | ||
| CommandObjectType.h | ||
| CommandObjectVersion.cpp | ||
| CommandObjectVersion.h | ||
| CommandObjectWatchpoint.cpp | ||
| CommandObjectWatchpoint.h | ||
| CommandObjectWatchpointCommand.cpp | ||
| CommandObjectWatchpointCommand.h | ||
| Options.td | ||
| OptionsBase.td | ||