llvm-project/clang/lib/CodeGen
David Blaikie 47d28e07c1 DebugInof: Correct the location of exception cleanups in global ctors/dtors and ObjC methods
Without setting the CurEHLocation these cleanups would be attributed to
whatever the last active debug line location was (the 'fn' call in the
included test cases). By setting CurEHLocation correctly the line
information is improved/corrected.

This quality bug turned into a crasher with r225000 when, instead of
allowing the last location to persist, it would be zero'd out. This
could lead to a function call (such as the dtor) being made without a
debug location - if that call was subsequently inlined (and the caller
and callee had debug info, just not the call instruction) the inliner
would violate important constraints about the debug location chains by
not updating the inlined instructions to chain up to the callee
locations.

So, by fixing this bug, I am addressing the assertion failures
introduced by r225000 and should be able to recommit that patch with
impunity...

llvm-svn: 225955
2015-01-14 07:10:46 +00:00
..
ABIInfo.h Fix invalid calling convention used for libcalls on ARM. 2014-12-02 16:04:58 +00:00
BackendUtil.cpp Revert "Insert random noops to increase security against ROP attacks (clang)" 2015-01-14 05:24:11 +00:00
CGAtomic.cpp Bugfix for Codegen of atomic load/store/other ops. 2014-12-15 05:25:25 +00:00
CGBlocks.cpp DebugInfo: Correct the location of EH cleanup for blocks 2015-01-13 23:06:27 +00:00
CGBlocks.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CGBuilder.h typo 2014-09-10 16:59:01 +00:00
CGBuiltin.cpp Add __builtin_amdgpu_class 2015-01-06 23:14:57 +00:00
CGCUDANV.cpp [C++11] Add 'override' keyword to virtual methods that override their base class. 2014-03-12 06:41:41 +00:00
CGCUDARuntime.cpp Pass expressions instead of argument ranges to EmitCall/EmitCXXConstructorCall. 2014-08-21 20:26:47 +00:00
CGCUDARuntime.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CGCXX.cpp Don't use a doc comment in a function body. 2015-01-12 21:22:27 +00:00
CGCXXABI.cpp MS ABI: Implement thread_local for global variables 2014-10-05 05:05:40 +00:00
CGCXXABI.h MS ABI: Add CodeGen support for rethrowing MS C++ exceptions 2014-11-25 07:20:20 +00:00
CGCall.cpp Revert r225085, it caused PR22096. 2015-01-07 18:23:08 +00:00
CGCall.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CGClass.cpp Revert "DebugInfo: Generalize debug info location handling" and related commits 2015-01-09 23:00:28 +00:00
CGCleanup.cpp Revert "DebugInfo: Generalize debug info location handling" and related commits 2015-01-09 23:00:28 +00:00
CGCleanup.h Update for LLVM API change to make Small(Ptr)Set::insert return pair<iterator, bool> as per the C++ standard's associative container concept. 2014-11-19 07:49:47 +00:00
CGDebugInfo.cpp Revert "DebugInfo: Generalize debug info location handling" and related commits 2015-01-09 23:00:28 +00:00
CGDebugInfo.h Revert "DebugInfo: Generalize debug info location handling" and related commits 2015-01-09 23:00:28 +00:00
CGDecl.cpp [patch][pr19848] Produce explicit comdats in clang. 2015-01-12 22:13:53 +00:00
CGDeclCXX.cpp DebugInof: Correct the location of exception cleanups in global ctors/dtors and ObjC methods 2015-01-14 07:10:46 +00:00
CGException.cpp Revert "DebugInfo: Generalize debug info location handling" and related commits 2015-01-09 23:00:28 +00:00
CGExpr.cpp Reimplement -fsanitize-recover family of flags. 2015-01-12 22:39:12 +00:00
CGExprAgg.cpp PR18097: Support initializing an _Atomic(T) from an object of C++ class type T 2014-07-31 06:31:19 +00:00
CGExprCXX.cpp Revert "DebugInfo: Generalize debug info location handling" and related commits 2015-01-09 23:00:28 +00:00
CGExprComplex.cpp Revert "DebugInfo: Generalize debug info location handling" and related commits 2015-01-09 23:00:28 +00:00
CGExprConstant.cpp CodeGen: Optimize emssion of zeroinitialzied arrays 2014-12-28 23:46:59 +00:00
CGExprScalar.cpp [mips] Fix va_arg() for pointer types on big-endian N32. 2015-01-13 10:47:00 +00:00
CGLoopInfo.cpp IR: Update clang for Metadata/Value split in r223802 2014-12-09 18:39:32 +00:00
CGLoopInfo.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CGObjC.cpp DebugInof: Correct the location of exception cleanups in global ctors/dtors and ObjC methods 2015-01-14 07:10:46 +00:00
CGObjCGNU.cpp IR: Update clang for Metadata/Value split in r223802 2014-12-09 18:39:32 +00:00
CGObjCMac.cpp Implement the __builtin_call_with_static_chain GNU extension. 2014-12-12 23:41:25 +00:00
CGObjCRuntime.cpp Update for llvm api change. 2014-06-04 18:51:46 +00:00
CGObjCRuntime.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CGOpenCLRuntime.cpp [C++11] Use 'nullptr'. CodeGen edition. 2014-05-21 05:09:00 +00:00
CGOpenCLRuntime.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CGOpenMPRuntime.cpp First patch with codegen of the 'omp for' directive. It implements 2014-12-15 07:07:06 +00:00
CGOpenMPRuntime.h s/ScheduleKind/SchedKind/ in \param. [-Wdocumentation] 2014-12-17 14:47:06 +00:00
CGRecordLayout.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CGRecordLayoutBuilder.cpp CodeGen: Cleanup CGRecordLowering::lowerUnion a little 2014-10-15 16:36:11 +00:00
CGStmt.cpp CodeGen: Simplify consecutive '%' modifiers 2015-01-11 09:13:56 +00:00
CGStmtOpenMP.cpp Revert "DebugInfo: Generalize debug info location handling" and related commits 2015-01-09 23:00:28 +00:00
CGVTT.cpp Remove the -fhidden-weak-vtables -cc1 option. It was dead, 2014-02-08 00:41:16 +00:00
CGVTables.cpp PR22051: Missing debug location on calls in dtor thunks in Windows. 2014-12-29 22:53:52 +00:00
CGVTables.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CGValue.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CMakeLists.txt cmake: Conditionalize CodeGen's dependency on intrinsics_gen 2014-11-05 20:30:55 +00:00
CodeGenABITypes.cpp Implement the __builtin_call_with_static_chain GNU extension. 2014-12-12 23:41:25 +00:00
CodeGenAction.cpp Initialize BackendConsumer::Context in constructor. 2014-12-25 12:21:56 +00:00
CodeGenFunction.cpp Revert "DebugInfo: Generalize debug info location handling" and related commits 2015-01-09 23:00:28 +00:00
CodeGenFunction.h Sink a parameter into the callee since it's always the same expression in terms of another parameter 2015-01-14 00:04:42 +00:00
CodeGenModule.cpp [patch][pr19848] Produce explicit comdats in clang. 2015-01-12 22:13:53 +00:00
CodeGenModule.h Don't emit implicit template instantiations eagerly (PR21718) 2015-01-10 01:19:48 +00:00
CodeGenPGO.cpp InstrProf: Don't emit counter increments in dead code 2015-01-09 01:46:40 +00:00
CodeGenPGO.h InstrProf: Use LLVM's -instrprof pass for profiling 2014-12-08 19:04:51 +00:00
CodeGenTBAA.cpp [C++11] Use 'nullptr'. CodeGen edition. 2014-05-21 05:09:00 +00:00
CodeGenTBAA.h Header guard canonicalization, clang part. 2014-08-13 16:25:19 +00:00
CodeGenTypes.cpp Use nullptr to silence -Wsentinel when self-hosting on Windows 2014-12-01 22:02:27 +00:00
CodeGenTypes.h Implement the __builtin_call_with_static_chain GNU extension. 2014-12-12 23:41:25 +00:00
CoverageMappingGen.cpp InstrProf: Simplify/reduce state in CoverageMapping (NFC) 2014-12-17 23:55:04 +00:00
CoverageMappingGen.h Reapply "InstrProf: Update for the LLVM API change in r218879" 2014-10-02 16:44:01 +00:00
EHScopeStack.h Silence a warning from MSVC "14" by making an enum unsigned 2014-10-31 23:33:56 +00:00
ItaniumCXXABI.cpp [patch][pr19848] Produce explicit comdats in clang. 2015-01-12 22:13:53 +00:00
Makefile
MicrosoftCXXABI.cpp [patch][pr19848] Produce explicit comdats in clang. 2015-01-12 22:13:53 +00:00
ModuleBuilder.cpp Initialize CodeGeneratorImpl::Ctx in constructor. 2014-12-25 11:38:15 +00:00
README.txt
SanitizerMetadata.cpp IR: Update clang for Metadata/Value split in r223802 2014-12-09 18:39:32 +00:00
SanitizerMetadata.h [ASan] Improve blacklisting of global variables. 2014-10-17 22:37:33 +00:00
TargetInfo.cpp [mips] Fix va_arg() for pointer types on big-endian N32. 2015-01-13 10:47:00 +00:00
TargetInfo.h [OPENMP] Codegen of the ‘aligned’ clause for the ‘omp simd’ directive. 2014-09-30 05:29:28 +00:00

README.txt

IRgen optimization opportunities.

//===---------------------------------------------------------------------===//

The common pattern of
--
short x; // or char, etc
(x == 10)
--
generates an zext/sext of x which can easily be avoided.

//===---------------------------------------------------------------------===//

Bitfields accesses can be shifted to simplify masking and sign
extension. For example, if the bitfield width is 8 and it is
appropriately aligned then is is a lot shorter to just load the char
directly.

//===---------------------------------------------------------------------===//

It may be worth avoiding creation of alloca's for formal arguments
for the common situation where the argument is never written to or has
its address taken. The idea would be to begin generating code by using
the argument directly and if its address is taken or it is stored to
then generate the alloca and patch up the existing code.

In theory, the same optimization could be a win for block local
variables as long as the declaration dominates all statements in the
block.

NOTE: The main case we care about this for is for -O0 -g compile time
performance, and in that scenario we will need to emit the alloca
anyway currently to emit proper debug info. So this is blocked by
being able to emit debug information which refers to an LLVM
temporary, not an alloca.

//===---------------------------------------------------------------------===//

We should try and avoid generating basic blocks which only contain
jumps. At -O0, this penalizes us all the way from IRgen (malloc &
instruction overhead), all the way down through code generation and
assembly time.

On 176.gcc:expr.ll, it looks like over 12% of basic blocks are just
direct branches!

//===---------------------------------------------------------------------===//