llvm-project/lldb/unittests
Greg Clayton e55979b1e2 Fix MinidumpParser::GetFilteredModuleList() and test it
The MinidumpParser::GetFilteredModuleList() code was attempting to iterate through the entire module list and if it found more than one entry for a given module name, it wanted to pick the MinidumpModule with the lowest address. A bug existed where it wasn't doing that due to "exists" variable being inverted. "exists" was set to true if it was inserted, not if it existed. Furthermore, the order of the modules would be modified by sorting all modules from low address to high address (using MinidumpModule::base_of_image). This fix also maintains the original order which means your executable is at index 0 as intended instead of some random shared library.

Tests were added to ensure this functionality doesn't regress.

Differential Revision: https://reviews.llvm.org/D55614

llvm-svn: 349062
2018-12-13 17:24:30 +00:00
..
Breakpoint Rename Error -> Status. 2017-05-12 04:51:55 +00:00
Core Move DataExtractorTest to unittests/Utility 2018-11-14 14:58:36 +00:00
Disassembler If we fail to get an armv7em-- disassembler from llvm, skip the 2018-09-12 19:30:03 +00:00
Editline [FileSystem] Move path resolution logic out of FileSpec 2018-11-01 21:05:36 +00:00
Expression Remove Go debugger plugin 2018-11-05 19:33:59 +00:00
Host [unittests] Fix the File System Test on Windows 2018-11-28 19:34:01 +00:00
Interpreter [FileSystem] Migrate CommandCompletions 2018-12-04 17:58:21 +00:00
Language CPlusPlusLanguage: Use new demangler API to implement type substitution 2018-11-06 15:41:37 +00:00
ObjectFile [ObjectFile] Prefer reinterpret_cast<> 2018-11-06 17:42:14 +00:00
Platform [FileSystem] Move path resolution logic out of FileSpec 2018-11-01 21:05:36 +00:00
Process Fix MinidumpParser::GetFilteredModuleList() and test it 2018-12-13 17:24:30 +00:00
ScriptInterpreter [FileSystem] Open File instances through the FileSystem. 2018-11-02 22:34:51 +00:00
Signals Make LLDB skip server-client roundtrip for signals that don't require any actions 2017-03-07 21:34:40 +00:00
Symbol Remove Go debugger plugin 2018-11-05 19:33:59 +00:00
SymbolFile [Symbol] Search symbols with name and type in a symbol file 2018-11-30 06:56:37 +00:00
Target [FileSystem] Move path resolution logic out of FileSpec 2018-11-01 21:05:36 +00:00
TestingSupport Revert "[FileSystem] Make use of FS in TildeExpressionResolver" 2018-11-09 01:59:28 +00:00
UnwindAssembly [x86] Fix issues with a realigned stack in MSVC compiled applications 2018-10-30 10:07:08 +00:00
Utility Add another ArchSpec unit test. 2018-12-06 17:11:45 +00:00
debugserver [CMake] Need to set WITH_LOCKDOWN on debugserver target 2017-09-06 20:15:43 +00:00
tools Fix lldb-server unit tests for the MonitoringProcessLauncher refactor 2018-12-04 14:04:27 +00:00
CMakeLists.txt Add the Disassembler unit test dir. 2018-09-07 18:51:10 +00:00
gtest_common.h [Windows] Remove the #include <eh.h> hack. 2017-03-03 20:21:59 +00:00