forked from OSchip/llvm-project
24a1bedf76
in macro argument pre-expansion mode when skipping a function body
This commit fixes a token caching problem that currently occurs when clang is
skipping a function body (e.g. when looking for a code completion token) and at
the same time caching the tokens for _Pragma when lexing it in macro argument
pre-expansion mode.
When _Pragma is being lexed in macro argument pre-expansion mode, it caches the
tokens so that it can avoid interpreting the pragma immediately (as the macro
argument may not be used in the macro body), and then either backtracks over or
commits these tokens. The problem is that, when we're backtracking/committing in
such a scenario, there's already a previous backtracking position stored in
BacktrackPositions (as we're skipping the function body), and this leads to a
situation where the cached tokens from the pragma (like '(' 'string_literal'
and ')') will remain in the cached tokens array incorrectly even after they're
consumed (in the case of backtracking) or just ignored (in the case when they're
committed). Furthermore, what makes it even worse, is that because of a previous
backtracking position, the logic that deals with when should we call
ExitCachingLexMode in CachingLex no longer works for us in this situation, and
more tokens in the macro argument get cached, to the point where the EOF token
that corresponds to the macro argument EOF is cached. This problem leads to all
sorts of issues in code completion mode, where incorrect errors get presented
and code completion completely fails to produce completion results.
rdar://28523863
Differential Revision: https://reviews.llvm.org/D28772
llvm-svn: 296140
|
||
|---|---|---|
| .. | ||
| Inputs | ||
| PR9728.cpp | ||
| auto.cpp | ||
| auto_type.c | ||
| bracket-decl.c | ||
| call.c | ||
| call.cpp | ||
| constexpr.cpp | ||
| ctor-initializer.cpp | ||
| documentation.cpp | ||
| documentation.m | ||
| enum-switch-case-qualified.cpp | ||
| enum-switch-case.c | ||
| enum-switch-case.cpp | ||
| function-templates.cpp | ||
| functions.cpp | ||
| keywords.cpp | ||
| macros-in-modules.c | ||
| macros-in-modules.m | ||
| macros.c | ||
| member-access.c | ||
| member-access.cpp | ||
| namespace-alias.cpp | ||
| namespace.cpp | ||
| nested-name-specifier.cpp | ||
| objc-expr.m | ||
| objc-message.m | ||
| objc-message.mm | ||
| objc-protocol-member-access.m | ||
| operator.cpp | ||
| ordinary-name-cxx11.cpp | ||
| ordinary-name.c | ||
| ordinary-name.cpp | ||
| pch-and-module.m | ||
| pragma-macro-token-caching.c | ||
| preamble.c | ||
| some_struct.h | ||
| stdin.c | ||
| tag.c | ||
| tag.cpp | ||
| templates.cpp | ||
| truncation.c | ||
| truncation.c.h | ||
| using-namespace.cpp | ||
| using.cpp | ||