llvm-project/compiler-rt/cmake/Modules
Robert Underwood 16de50895e honor Python2_EXECUTABLE and Python3_EXECUTABLE when they are passed to cmake
CMake's find_package(Python3) and find_package(Python2) packages have a PYTHON_EXECUTABLE, Python2_EXECUTABLE, and Python3_EXECUTABLE cmake variables which control which version of python is built against.  As far as I can tell, the rest of LLVM honors these variables. This can cause the build process to fail when  if the automatically selected version of Python can't run due to modifications of LD_LIBRARY_PATH when using spack.  The corresponding Spack issue is https://github.com/spack/spack/issues/19908.  The corresponding LLVM issue is 48180

I believe an appropriate fix is to add the variables to the list of PASSTHROUGH_VARIABLES in cmake/Modules/AddCompilerRT.cmake, and this fixed compilation errors for me.

This bug affects distributions like Gentoo and package managers like Spack which allow for combinatorial versioning.

Reviewed By: Meinersbur

Differential Revision: https://reviews.llvm.org/D91536
2020-11-17 17:49:14 -06:00
..
CustomLibcxx [CMake] Bump CMake minimum version to 3.13.4 2020-07-22 14:25:07 -04:00
AddCompilerRT.cmake honor Python2_EXECUTABLE and Python3_EXECUTABLE when they are passed to cmake 2020-11-17 17:49:14 -06:00
BuiltinTests.cmake [cmake] Strip quotes in try_compile_only 2019-09-19 11:28:32 +00:00
CompilerRTCompile.cmake [compiler-rt][Darwin] Fix linker errors for check-asan 2020-07-31 16:43:21 -07:00
CompilerRTDarwinUtils.cmake [profile] Add InstrProfilingVersionVar.c.o to Darwin kext builtins 2020-08-26 10:02:13 -07:00
CompilerRTLink.cmake
CompilerRTUtils.cmake Revert "[CMake] Avoid accidental C++ standard library dependency in sanitizers" 2020-10-14 18:44:09 -07:00
HandleCompilerRT.cmake [compiler-rt] Build with correct ABI (PR38025) 2020-04-03 11:53:40 -07:00
SanitizerUtils.cmake build: use Python3 for compiler-rt 2020-04-28 17:29:04 +00:00
UseLibtool.cmake [compiler-rt] Disable ranlib when using libtool 2020-08-24 13:48:28 -07:00