forked from OSchip/llvm-project
7406d236d8
This starts to fix the other half of the lifetime problems in this code -- dangling references. SB objects created on the stack will go away when the function returns, which is a problem if the python code they were meant for stashes a reference to them somewhere. Most of the time this goes by unnoticed, as the code rarely has a reason to store these, but in case it does, we shouldn't respond by crashing. This patch fixes the management for a couple of SB objects (Debugger, Frame, Thread). The SB objects are now created on the heap, and their ownership is immediately passed on to SWIG, which will ensure they are destroyed when the last python reference goes away. I will handle the other objects in separate patches. I include one test which demonstrates the lifetime issue for SBDebugger. Strictly speaking, one should create a test case for each of these objects and each of the contexts they are being used. That would require figuring out how to persist (and later access) each of these objects. Some of those may involve a lot of hoop-jumping (we can run python code from within a frame-format string). I don't think that is necessary/worth it since the new wrapper functions make it very hard to get this wrong. Differential Revision: https://reviews.llvm.org/D115925 |
||
|---|---|---|
| .. | ||
| API | ||
| Breakpoint | ||
| Core | ||
| DataFormatter | ||
| Disassembler | ||
| Editline | ||
| Expression | ||
| Host | ||
| Instruction | ||
| Interpreter | ||
| Language | ||
| ObjectFile | ||
| Platform | ||
| Process | ||
| ScriptInterpreter | ||
| Signals | ||
| Symbol | ||
| SymbolFile | ||
| Target | ||
| TestingSupport | ||
| Thread | ||
| UnwindAssembly | ||
| Utility | ||
| debugserver | ||
| tools | ||
| CMakeLists.txt | ||
| gtest_common.h | ||