llvm-project/llvm/lib/Support
Zachary Turner 337462b365 [ADT] Make Twine's copy constructor private.
There's a lot of misuse of Twine scattered around LLVM.  This
ranges in severity from benign (returning a Twine from a function
by value that is just a string literal) to pretty sketchy (storing
a Twine by value in a class).  While there are some uses for
copying Twines, most of the very compelling ones are confined
to the Twine class implementation itself, and other uses are
either dubious or easily worked around.

This patch makes Twine's copy constructor private, and fixes up
all callsites.

Differential Revision: https://reviews.llvm.org/D38767

llvm-svn: 315530
2017-10-11 23:33:06 +00:00
..
Unix Support: Have directory_iterator::status() return FindFirstFileEx/FindNextFile results on Windows. 2017-10-10 22:19:46 +00:00
Windows Support: Work around missing SetFileInformationByHandle on Wine 2017-10-11 22:04:14 +00:00
AMDGPUMetadata.cpp AMDGPU/NFC: Minor clean ups in HSA metadata 2017-10-11 22:59:35 +00:00
APFloat.cpp [APFloat] Fix IsInteger() for DoubleAPFloat. 2017-08-21 16:51:54 +00:00
APInt.cpp [APInt] Move the single word cases of countTrailingZeros and countLeadingOnes inline for consistency with countTrailingOnes and countLeadingZeros. NFCI 2017-06-23 20:28:45 +00:00
APSInt.cpp
ARMAttributeParser.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
ARMBuildAttrs.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
ARMWinEH.cpp
Allocator.cpp
Atomic.cpp Fix llvm-for-windows-on-linux build after LLVM r272701. 2017-08-03 20:10:47 +00:00
BinaryStreamError.cpp [Support] Move Stream library from MSF -> Support. 2017-03-02 20:52:51 +00:00
BinaryStreamReader.cpp Add a BinarySubstreamRef, and a method to read one. 2017-06-23 16:38:40 +00:00
BinaryStreamRef.cpp [BinaryStream] Defaultify copy and move constructors. 2017-08-21 19:46:46 +00:00
BinaryStreamWriter.cpp Fix buildbots. 2017-06-16 02:42:33 +00:00
BlockFrequency.cpp
BranchProbability.cpp Cleanup dump() functions. 2017-01-28 02:02:38 +00:00
CMakeLists.txt AMDGPU/NFC: Rename code object metadata as HSA metadata 2017-10-11 22:18:53 +00:00
COM.cpp
COPYRIGHT.regex
CachePruning.cpp Support: Have directory_iterator::status() return FindFirstFileEx/FindNextFile results on Windows. 2017-10-10 22:19:46 +00:00
Chrono.cpp Make naming in Host.h in line with coding standards. 2017-03-31 13:06:40 +00:00
CommandLine.cpp Don't call exit from cl::PrintHelpMessage. 2017-09-07 23:30:48 +00:00
Compression.cpp Recommit r292214 "[Support/Compression] - Change zlib API to return Error instead of custom status" 2017-01-17 15:45:07 +00:00
ConvertUTF.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
ConvertUTFWrapper.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
CrashRecoveryContext.cpp Re-land r303274: "[CrashRecovery] Use SEH __try instead of VEH when available" 2017-05-17 18:16:17 +00:00
DAGDeltaAlgorithm.cpp
DataExtractor.cpp [DWARF] Support for DW_FORM_strx3 and complete support for DW_FORM_strx{1,2,4} 2017-06-21 19:37:44 +00:00
Debug.cpp Attempt to fix build bot after r290597 2016-12-27 10:24:58 +00:00
DebugCounter.cpp Hide dbgs() stream for when built with -fmodules. 2017-06-14 19:16:22 +00:00
DeltaAlgorithm.cpp
DynamicLibrary.cpp Allow clients to specify search order of DynamicLibraries. 2017-07-12 21:22:45 +00:00
Errno.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
Error.cpp [ADT] Make Twine's copy constructor private. 2017-10-11 23:33:06 +00:00
ErrorHandling.cpp Defeat a GCC -Wunused-result warning 2017-07-19 15:03:38 +00:00
FileOutputBuffer.cpp Do not remove a target file in FileOutputBuffer::create(). 2017-09-27 21:19:24 +00:00
FileUtilities.cpp
FoldingSet.cpp Support, IR, ADT: Check nullptr after allocation with malloc/realloc or calloc 2017-07-20 01:30:39 +00:00
FormatVariadic.cpp Remove unused variables. No functionality change. 2017-10-08 19:11:02 +00:00
FormattedStream.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
GlobPattern.cpp [Support/GlobPattern] - Do not crash when pattern has characters with int value < 0. 2017-07-31 09:26:50 +00:00
GraphWriter.cpp Convenience/safety fix for llvm::sys::Execute(And|No)Wait 2017-09-13 17:03:37 +00:00
Hashing.cpp
Host.cpp [AArch64] Add basic support for Qualcomm's Saphira CPU. 2017-09-25 14:05:00 +00:00
IntEqClasses.cpp
IntervalMap.cpp
JamCRC.cpp
KnownBits.cpp [KnownBits][ValueTracking] Move the math for calculating known bits for add/sub into a static method in KnownBits object 2017-08-08 16:29:35 +00:00
LEB128.cpp
LLVMBuild.txt
LineIterator.cpp
Locale.cpp
LockFileManager.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
LowLevelType.cpp [GlobalISel] Support vector-of-pointers in LLT 2017-04-19 07:23:57 +00:00
MD5.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
ManagedStatic.cpp Revamp llvm::once_flag to be closer to std::once_flag 2017-02-05 21:13:06 +00:00
MathExtras.cpp
Memory.cpp
MemoryBuffer.cpp Recommit "[Support] Add RetryAfterSignal helper function" 2017-06-29 13:15:31 +00:00
Mutex.cpp [Support] - Add bad alloc error handler for handling allocation malfunctions 2017-07-11 16:45:30 +00:00
NativeFormatting.cpp Remove dead variable Len. 2017-01-04 19:47:10 +00:00
Options.cpp
Parallel.cpp Bring r314809 back. 2017-10-04 20:27:01 +00:00
Path.cpp Support: Have directory_iterator::status() return FindFirstFileEx/FindNextFile results on Windows. 2017-10-10 22:19:46 +00:00
PluginLoader.cpp
PrettyStackTrace.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
Process.cpp [llvm-rc] Use proper search algorithm for finding resources. 2017-10-11 20:12:09 +00:00
Program.cpp Convenience/safety fix for llvm::sys::Execute(And|No)Wait 2017-09-13 17:03:37 +00:00
README.txt.system
RWMutex.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
RandomNumberGenerator.cpp
Regex.cpp Add const to a const method. NFC 2017-04-18 01:04:05 +00:00
SHA1.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
ScaledNumber.cpp Replace APFloatBase static fltSemantics data members with getter functions 2016-12-14 11:57:17 +00:00
ScopedPrinter.cpp [llvm-pdbdump] Allow printing only a portion of a stream. 2017-04-28 00:43:38 +00:00
Signals.cpp Convenience/safety fix for llvm::sys::Execute(And|No)Wait 2017-09-13 17:03:37 +00:00
SmallPtrSet.cpp Support, IR, ADT: Check nullptr after allocation with malloc/realloc or calloc 2017-07-20 01:30:39 +00:00
SmallVector.cpp Support, IR, ADT: Check nullptr after allocation with malloc/realloc or calloc 2017-07-20 01:30:39 +00:00
SourceMgr.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
SpecialCaseList.cpp Add section headers to SpecialCaseLists 2017-09-25 22:11:11 +00:00
Statistic.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
StringExtras.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
StringMap.cpp Support, IR, ADT: Check nullptr after allocation with malloc/realloc or calloc 2017-07-20 01:30:39 +00:00
StringPool.cpp
StringRef.cpp [Support] Add StringRef::getAsDouble. 2017-02-14 19:06:37 +00:00
StringSaver.cpp
SystemUtils.cpp
TarWriter.cpp Fix a UBsan bot. 2017-09-28 00:27:39 +00:00
TargetParser.cpp [TargetParser][AArch64] Add support for RDM feature in the target parser. 2017-08-24 14:30:44 +00:00
TargetRegistry.cpp Allow VersionPrinter to print to arbitrary raw_ostreams 2017-06-06 21:54:04 +00:00
ThreadLocal.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
ThreadPool.cpp Bring r314809 back. 2017-10-04 20:27:01 +00:00
Threading.cpp Bring r314809 back. 2017-10-04 20:27:01 +00:00
Timer.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
ToolOutputFile.cpp [Support] Rename tool_output_file to ToolOutputFile, NFC 2017-09-23 01:03:17 +00:00
TrigramIndex.cpp Sort the remaining #include lines in include/... and lib/.... 2017-06-06 11:49:48 +00:00
Triple.cpp [Triple] Add AMDPAL operating system type 2017-09-29 09:48:12 +00:00
Twine.cpp [ADT] Make Twine's copy constructor private. 2017-10-11 23:33:06 +00:00
Unicode.cpp
Valgrind.cpp
Watchdog.cpp
YAMLParser.cpp [ProfileData, Support] Fix some Clang-tidy modernize-use-using and Include What You Use warnings; other minor fixes (NFC). 2017-06-21 23:19:47 +00:00
YAMLTraits.cpp [yaml2obj] - Don't crash on one more invalid document. 2017-09-21 08:25:59 +00:00
circular_raw_ostream.cpp
raw_os_ostream.cpp
raw_ostream.cpp llvm-dwarfdump: support dumping UUIDs of Mach-O binaries. 2017-09-13 18:22:59 +00:00
regcclass.h
regcname.h
regcomp.c
regengine.inc
regerror.c
regex2.h
regex_impl.h
regexec.c
regfree.c
regstrlcpy.c
regutils.h
xxhash.cpp Revert r301487: Replace HashString algorithm with xxHash64 2017-04-26 23:15:10 +00:00

README.txt.system

Design Of lib/System
====================

The software in this directory is designed to completely shield LLVM from any
and all operating system specific functionality. It is not intended to be a
complete operating system wrapper (such as ACE), but only to provide the
functionality necessary to support LLVM.

The software located here, of necessity, has very specific and stringent design
rules. Violation of these rules means that cracks in the shield could form and
the primary goal of the library is defeated. By consistently using this library,
LLVM becomes more easily ported to new platforms since the only thing requiring
porting is this library.

Complete documentation for the library can be found in the file:
  llvm/docs/SystemLibrary.html
or at this URL:
  http://llvm.org/docs/SystemLibrary.html

While we recommend that you read the more detailed documentation, for the
impatient, here's a high level summary of the library's requirements.

 1. No system header files are to be exposed through the interface.
 2. Std C++ and Std C header files are okay to be exposed through the interface.
 3. No exposed system-specific functions.
 4. No exposed system-specific data.
 5. Data in lib/System classes must use only simple C++ intrinsic types.
 6. Errors are handled by returning "true" and setting an optional std::string
 7. Library must not throw any exceptions, period.
 8. Interface functions must not have throw() specifications.
 9. No duplicate function impementations are permitted within an operating
    system class.

To accomplish these requirements, the library has numerous design criteria that
must be satisfied. Here's a high level summary of the library's design criteria:

 1. No unused functionality (only what LLVM needs)
 2. High-Level Interfaces
 3. Use Opaque Classes
 4. Common Implementations
 5. Multiple Implementations
 6. Minimize Memory Allocation
 7. No Virtual Methods