forked from OSchip/llvm-project
47c3472c41
Summary: Even though the getDIEOffset offset function was common for the two accelerator table implementations, it was doing two different things: for the Apple tables, it was returning the die offset relative to the start of the section, whereas for DWARF v5 tables, it was relative to the start of the CU. I resolve this by renaming the function to getDIESectionOffset to make it obvious what the function returns, and change the DWARF implementation to return the section offset. I also keep the CU-relative accessor, but only in the DWARF implementation (there is no way to get this information for the Apple tables). This was not caught by existing tests because the hand-written inputs also erroneously used section offsets instead of CU-relative ones. While looking at this, I noticed that the Apple implementation was not fully correct either -- the header contains a DIEOffsetBase field, which should be added to offsets encoded with the DW_FORM_ref*** family, but this was not being used. This went unnoticed because all current writers set this field to zero anyway. I fix this as well and add a hand-written test which demonstrates the issue. Reviewers: JDevlieghere, dblaikie Subscribers: aprantl, llvm-commits Differential Revision: https://reviews.llvm.org/D44202 llvm-svn: 327116 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| DWARFAbbreviationDeclaration.cpp | ||
| DWARFAcceleratorTable.cpp | ||
| DWARFAddressRange.cpp | ||
| DWARFCompileUnit.cpp | ||
| DWARFContext.cpp | ||
| DWARFDataExtractor.cpp | ||
| DWARFDebugAbbrev.cpp | ||
| DWARFDebugArangeSet.cpp | ||
| DWARFDebugAranges.cpp | ||
| DWARFDebugFrame.cpp | ||
| DWARFDebugInfoEntry.cpp | ||
| DWARFDebugLine.cpp | ||
| DWARFDebugLoc.cpp | ||
| DWARFDebugMacro.cpp | ||
| DWARFDebugPubTable.cpp | ||
| DWARFDebugRangeList.cpp | ||
| DWARFDebugRnglists.cpp | ||
| DWARFDie.cpp | ||
| DWARFExpression.cpp | ||
| DWARFFormValue.cpp | ||
| DWARFGdbIndex.cpp | ||
| DWARFTypeUnit.cpp | ||
| DWARFUnit.cpp | ||
| DWARFUnitIndex.cpp | ||
| DWARFVerifier.cpp | ||
| LLVMBuild.txt | ||