forked from OSchip/llvm-project
303e2f1eac
Since array parameters decay to pointers, '_Nullable' and friends should be available for use there as well. This is especially important for parameters that are typedefs of arrays. The unsugared syntax for this follows the syntax for 'static'-sized arrays in C: void test(int values[_Nullable]); This syntax was previously accepted but the '_Nullable' (and any other attributes) were silently discarded. However, applying '_Nullable' to a typedef was previously rejected and is now accepted; therefore, it may be necessary to test for the presence of this feature: #if __has_feature(nullability_on_arrays) One important change here is that DecayedTypes don't always immediately contain PointerTypes anymore; they may contain an AttributedType instead. This only affected one place in-tree, so I would guess it's not likely to cause problems elsewhere. This commit does not change -Wnullability-completeness just yet. I want to think about whether it's worth doing something special to avoid breaking existing clients that compile with -Werror. It also doesn't change '#pragma clang assume_nonnull' behavior, which currently treats the following two declarations as equivalent: #pragma clang assume_nonnull begin void test(void *pointers[]); #pragma clang assume_nonnull end void test(void * _Nonnull pointers[]); This is not the desired behavior, but changing it would break backwards-compatibility. Most likely the best answer is going to be adding a new warning. Part of rdar://problem/25846421 llvm-svn: 286519 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| HeaderMap.cpp | ||
| HeaderSearch.cpp | ||
| Lexer.cpp | ||
| LiteralSupport.cpp | ||
| MacroArgs.cpp | ||
| MacroInfo.cpp | ||
| ModuleMap.cpp | ||
| PPCaching.cpp | ||
| PPCallbacks.cpp | ||
| PPConditionalDirectiveRecord.cpp | ||
| PPDirectives.cpp | ||
| PPExpressions.cpp | ||
| PPLexerChange.cpp | ||
| PPMacroExpansion.cpp | ||
| PTHLexer.cpp | ||
| Pragma.cpp | ||
| PreprocessingRecord.cpp | ||
| Preprocessor.cpp | ||
| PreprocessorLexer.cpp | ||
| ScratchBuffer.cpp | ||
| TokenConcatenation.cpp | ||
| TokenLexer.cpp | ||
| UnicodeCharSets.h | ||