maxjhandsome
/
llvm-project
forked from OSchip/llvm-project
1
0
Fork 0
Code Issues Pull Requests Packages Releases Wiki Activity
llvm-project/lldb
History
Joseph Tremoulet 20f84257ac [lldb] Fix GetRemoteSharedModule fallback logic 
When the various methods of locating the module in GetRemoteSharedModule
fail, make sure we pass the original module spec to the bail-out call to
the provided resolver function.

Also make sure we consistently use the resolved module spec from the
various success paths.

Thanks to what appears to have been an accidentally inverted condition
(commit 85967fa applied the new condition to a path where GetModuleSpec
returns false, but should have applied it when GetModuleSpec returns
true), without this fix we only pass the original module spec in the
fallback if the original spec has no uuid (or has a uuid that somehow
matches the resolved module's uuid despite the call to GetModuleSpec
failing).  This manifested as a bug when processing a minidump file with
a user-provided sysroot, since in that case the resolver call was being
applied to resolved_module_spec (despite resolution failing), which did
not have the path of its file_spec set.

Reviewed By: JDevlieghere

Differential Revision: https://reviews.llvm.org/D88099
 		2020-09-23 06:00:50 -07:00
..
bindings [lldb] Clarify docstring for SBBlock::IsInlined, NFC 2020-09-17 16:54:58 -07:00
cmake [lldb] Remove redundant call to FindBacktrace (NFC) 2020-08-20 22:41:49 -07:00
docs [lldb/Docs] Correct LLDB_ENABLE_TESTS to LLDB_INCLUDE_TESTS 2020-09-09 11:07:57 -07:00
examples Harmonize Python shebang 2020-07-16 21:53:45 +02:00
include/lldb Add a "Trace" plug-in to LLDB to add process trace support in stages. 2020-09-21 17:13:18 -07:00
packages/Python [lldb/test] Clean up version checking. 2020-09-21 16:19:28 -07:00
resources
…
scripts Harmonize Python shebang 2020-07-16 21:53:45 +02:00
source [lldb] Fix GetRemoteSharedModule fallback logic 2020-09-23 06:00:50 -07:00
test [lldb] Fix GetRemoteSharedModule fallback logic 2020-09-23 06:00:50 -07:00
third_party/Python/module Revert "[lldb] temporary commit to see why a test is failing only on lldb-aarch64-ubuntu" 2020-08-05 11:55:02 +02:00
tools Fix 132e57bc59 2020-09-14 10:54:17 -07:00
unittests [DWARFYAML] Make the include_directories, file_names and opcodes fields of the line table optional. 2020-09-18 20:21:11 +08:00
utils [lldb, tests] Correctly configure the yaml2obj paths 2020-09-10 10:10:28 -07:00
.clang-format
…
.clang-tidy [lldb] Add .clang-tidy with customization to disable readability-identifier-naming 2020-03-09 12:50:28 -07:00
.gitignore
…
CMakeLists.txt Create ${swig_target}-scripts target instead of lldb-python-scripts 2020-08-22 19:36:37 -07:00
CODE_OWNERS.txt
…
LICENSE.TXT
…
use_lldb_suite_root.py
…