forked from OSchip/llvm-project
52fe1f68c8
When getting attributes it is sometimes nicer to use Optional<T> some of the time instead of magic values. I tried to cut over to only using the Optional values but it made many of the call sites very messy, so it makes sense the leave in the calls that can return a default value. Otherwise code that looks like this:
uint64_t CallColumn = Die.getAttributeValueAsAddress(DW_AT_call_line, 0);
Has to be turned into:
uint64_t CallColumn = 0;
if (auto CallColumnValue = Die.getAttributeValueAsAddress(DW_AT_call_line))
CallColumn = *CallColumnValue;
The first snippet of code looks much better. But in cases where you want an offset that may or may not be there, the following code looks better:
if (auto StmtOffset = Die.getAttributeValueAsSectionOffset(DW_AT_stmt_list)) {
// Use StmtOffset
}
Differential Revision: https://reviews.llvm.org/D27772
llvm-svn: 289731
|
||
|---|---|---|
| .. | ||
| BinaryHolder.cpp | ||
| BinaryHolder.h | ||
| CMakeLists.txt | ||
| DebugMap.cpp | ||
| DebugMap.h | ||
| DwarfLinker.cpp | ||
| LLVMBuild.txt | ||
| MachODebugMapParser.cpp | ||
| MachOUtils.cpp | ||
| MachOUtils.h | ||
| NonRelocatableStringpool.h | ||
| dsymutil.cpp | ||
| dsymutil.h | ||