forked from OSchip/llvm-project
5a9497d689
We sometimes unroll an ac-implied-do of an array constructor into a flat list of values. We then re-analyze the array constructor that contains the resulting list of expressions. Such a list may or may not contain errors. But when processing an array constructor with an unrolled ac-implied-do, the compiler was building an expression to represent the extent of the resulting array constructor containing the list of values. The number of operands in this extent expression was based on the number of elements in the unrolled list of values. For very large lists, this created an expression so large that it could not be evaluated by the compiler without overflowing the stack. I fixed this by continuously folding the extent expression as each operand is added to it. I added the test .../flang/test/Semantics/array-constr-big.f90 that will cause the compiler to seg fault without this change. Also, when the unrolled ac-implied-do expression contains errors, we were repeating the same error message referencing the same source line for every instance of the erroneous expression in the unrolled list. This potentially resulted in a very long list of messages for a single error in the source code. I fixed this by comparing the message being emitted to the previously emitted message. If they are the same, I do not emit the message. This change is also tested by the new test array-constr-big.f90. Several of the existing tests had duplicate error messages for the same source line, and this change caused differences in their output. So I adjusted the tests to match the new message emitting behavior. Differential Revision: https://reviews.llvm.org/D102210 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| Fortran-parsers.cpp | ||
| basic-parsers.h | ||
| char-block.cpp | ||
| char-buffer.cpp | ||
| char-set.cpp | ||
| characters.cpp | ||
| debug-parser.cpp | ||
| debug-parser.h | ||
| executable-parsers.cpp | ||
| expr-parsers.cpp | ||
| expr-parsers.h | ||
| instrumented-parser.cpp | ||
| io-parsers.cpp | ||
| message.cpp | ||
| misc-parsers.h | ||
| openacc-parsers.cpp | ||
| openmp-parsers.cpp | ||
| parse-tree.cpp | ||
| parsing.cpp | ||
| preprocessor.cpp | ||
| preprocessor.h | ||
| prescan.cpp | ||
| prescan.h | ||
| program-parsers.cpp | ||
| provenance.cpp | ||
| source.cpp | ||
| stmt-parser.h | ||
| token-parsers.h | ||
| token-sequence.cpp | ||
| token-sequence.h | ||
| tools.cpp | ||
| type-parser-implementation.h | ||
| type-parsers.h | ||
| unparse.cpp | ||
| user-state.cpp | ||