llvm-project/clang-tools-extra/clang-tidy
Jonas Toth 6a9f831ffd [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker
Summary:
Correct the case of the local variables..

Rational:
I want to be able to run clang-tidy on new clang-tidy checker code prior to creating a review (to demonstrate we should dog food our own tools during development, not my suggestion but @Eugene.Zelenko)

To this end I am running the following in a script, prior to make a change.

```
tidy:
    @for source in $$(git status -suno | grep ".cpp$$" | cut -c4-) ;\
    do \
        clang-tidy -quiet  $$source -- $(TIDY_FLAGS);\
    done

```

I then want to go through the checkers and see which checkers most closely match the review style of the reviewers

```
---
Checks:          '
-clang-diagnostic-*,
readability-identifier-naming,
llvm-header-guard
'
WarningsAsErrors: ''
HeaderFilterRegex: ''
AnalyzeTemporaryDtors: false
FormatStyle:     LLVM
CheckOptions:
  - key:             readability-identifier-naming.IgnoreFailedSplit
    value:           '0'
  - key:             readability-identifier-naming.VariableCase
    value:           'CamelCase'
  - key:             readability-identifier-naming.LocalVariableCase
    value:           'CamelCase'
...

```

Unfortunately in doing so, I have identified that my previous review {D55433} it violates what looks like to be the convention of local variables being in CamelCase.

Sending this small review in the hope it can be corrected.

Patch by MyDeveloperDay.

Reviewers: JonasToth, Eugene.Zelenko

Reviewed By: JonasToth

Subscribers: xazax.hun, Eugene.Zelenko

Differential Revision: https://reviews.llvm.org/D56536

llvm-svn: 350814
2019-01-10 11:56:44 +00:00
..
abseil [clang-tidy] Use the public hasInit matcher, rather than defining our own, NFC 2019-01-07 14:36:47 +00:00
android [Clang-tidy] Alphabetical sort of files/checks. Add space after clang-tidy in source code headers. 2018-09-20 00:02:55 +00:00
boost Port getLocStart -> getBeginLoc 2018-08-09 22:42:26 +00:00
bugprone Revert "[clang-tidy] new check: bugprone-branch-clone" 2018-12-05 09:34:18 +00:00
cert Fix false positive with lambda assignments in cert-err58-cpp. 2018-11-28 15:04:38 +00:00
cppcoreguidelines Add explicit dependency on clangSerialization after rC348911 2018-12-12 08:25:16 +00:00
fuchsia A bit of AST matcher cleanup, NFC. 2018-11-25 02:41:01 +00:00
google [clang-tidy] Improve google-objc-function-naming diagnostics 📙 2018-12-14 03:13:31 +00:00
hicpp Add explicit dependency on clangSerialization after rC348911 2018-12-12 08:25:16 +00:00
llvm Port getLocEnd -> getEndLoc 2018-08-09 22:43:02 +00:00
misc Add explicit dependency on clangSerialization after rC348911 2018-12-12 08:25:16 +00:00
modernize [clang-tidy] Fix case of local variables in modernize-use-nodiscard checker 2019-01-10 11:56:44 +00:00
mpi [clang-tidy] Add dependency to clangAnalysis after rC343160 2018-09-27 04:23:24 +00:00
objc [clang-tidy/checks] Update objc-property-declaration check to allow arbitrary acronyms and initialisms 🔧 2018-12-05 03:44:03 +00:00
performance A bit of AST matcher cleanup, NFC. 2018-11-25 02:41:01 +00:00
plugin [clang-tidy] Remove extra config.h includes 2018-12-14 07:44:52 +00:00
portability A bit of AST matcher cleanup, NFC. 2018-11-25 02:41:01 +00:00
readability [clang-tidy] add IgnoreMacros option to readability-uppercase-literal-suffix 2018-12-24 17:47:32 +00:00
tool [clang-tidy] Add export-fixes flag to clang-tidy-diff 2018-12-21 17:25:27 +00:00
utils [clang-tidy] Fixed code sample in a comment. NFC 2018-11-02 15:29:37 +00:00
zircon A bit of AST matcher cleanup, NFC. 2018-11-25 02:41:01 +00:00
CMakeLists.txt Add explicit dependency on clangSerialization after rC348911 2018-12-12 08:25:16 +00:00
ClangTidy.cpp [clang-tidy] Untangle layering in ClangTidyDiagnosticConsumer somewhat. NFC 2018-11-08 17:42:16 +00:00
ClangTidy.h [clang-tidy] Get ClangTidyContext out of the business of storing diagnostics. NFC 2018-11-02 10:01:59 +00:00
ClangTidyDiagnosticConsumer.cpp [clang-tidy] use "const SourceManager&" parameter, NFC. 2018-12-19 13:25:08 +00:00
ClangTidyDiagnosticConsumer.h [clang-tidy] Untangle layering in ClangTidyDiagnosticConsumer somewhat. NFC 2018-11-08 17:42:16 +00:00
ClangTidyForceLinker.h [clang-tidy] Share the forced linking code between clang-tidy tool and plugin 2018-12-14 07:29:06 +00:00
ClangTidyModule.cpp Change getChecksFilter() interface to hide implementation details. 2017-05-17 14:39:47 +00:00
ClangTidyModule.h [clang-tools-extra] Format sources with clang-format. NFC. 2016-11-08 07:50:19 +00:00
ClangTidyModuleRegistry.h Reapply r276973 "Adjust Registry interface to not require plugins to export a registry" 2016-08-05 11:01:08 +00:00
ClangTidyOptions.cpp Lift VFS from clang to llvm (NFC) 2018-10-10 13:27:25 +00:00
ClangTidyOptions.h Lift VFS from clang to llvm (NFC) 2018-10-10 13:27:25 +00:00
ClangTidyProfiling.cpp [clang-tidy] Store checks profiling info as JSON files 2018-06-06 15:07:51 +00:00
ClangTidyProfiling.h [clang-tidy] Store checks profiling info as JSON files 2018-06-06 15:07:51 +00:00
add_new_check.py [clang-tidy] insert release notes for new checkers alphabetically 2018-12-10 19:41:53 +00:00
rename_check.py [clang-tidy] Use :doc: for check links in Release Notes. 2018-03-21 17:06:13 +00:00