forked from OSchip/llvm-project
93f9996278
Summary: We can sometimes end up with multiple copies of a local variable that have the same GUID in the index. This happens when there are local variables with the same name that are in different source files having the same name/path at compile time (but compiled into different bitcode objects). In this case make sure we import the copy in the caller's module. This enables importing both of the variables having the same GUID (but which will have different promoted names since the module paths, and therefore the module hashes, will be distinct). Importing the wrong copy is particularly problematic for read only variables, since we must import them as a local copy whenever referenced. Otherwise we get undefs at link time. Note that the llvm-lto.cpp and ThinLTOCodeGenerator changes are needed for testing the distributed index case via clang, which will be sent as a separate clang-side patch shortly. We were previously not doing the dead code/read only computation before computing imports when testing distributed index generation (like it was for testing importing and other ThinLTO mechanisms alone). Reviewers: evgeny777 Subscribers: mehdi_amini, inglorion, eraman, steven_wu, dexonsmith, dang, llvm-commits Differential Revision: https://reviews.llvm.org/D55047 llvm-svn: 347886 |
||
|---|---|---|
| .. | ||
| Inputs | ||
| alias_import.ll | ||
| alias_internal.ll | ||
| alias_resolution.ll | ||
| autoupgrade.ll | ||
| cache-config.ll | ||
| cache-icall.ll | ||
| cache-import-lists.ll | ||
| cache-typeid-resolutions.ll | ||
| cache.ll | ||
| callees-metadata.ll | ||
| cfi-devirt.ll | ||
| cfi-distributed.ll | ||
| cfi-icall.ll | ||
| cfi.ll | ||
| crash_debuginfo.ll | ||
| deadstrip.ll | ||
| debuginfo-compositetype-import.ll | ||
| debuginfo-cu-import.ll | ||
| devirt-after-icp.ll | ||
| diagnostic-handler-remarks-with-hotness.ll | ||
| diagnostic-handler-remarks.ll | ||
| dicompositetype-unique-alias.ll | ||
| dicompositetype-unique.ll | ||
| dicompositetype-unique2.ll | ||
| distributed_import.ll | ||
| distributed_indexes.ll | ||
| dot-dumper-full-lto.ll | ||
| dot-dumper.ll | ||
| drop-debug-info.ll | ||
| dsolocal_dllimport.ll | ||
| emit_imports.ll | ||
| empty-module.ll | ||
| empty_module_with_cache.ll | ||
| export.ll | ||
| funcimport-debug.ll | ||
| funcimport-tbaa.ll | ||
| funcimport.ll | ||
| funcimport2.ll | ||
| globals-import-blockaddr.ll | ||
| globals-import-const-fold.ll | ||
| globals-import.ll | ||
| import_opaque_type.ll | ||
| index-const-prop-O0.ll | ||
| index-const-prop-alias.ll | ||
| index-const-prop-cache.ll | ||
| index-const-prop-comdat.ll | ||
| index-const-prop-dead.ll | ||
| index-const-prop-full-lto.ll | ||
| index-const-prop-gvref.ll | ||
| index-const-prop-ldst.ll | ||
| index-const-prop-linkage.ll | ||
| index-const-prop.ll | ||
| index-const-prop2.ll | ||
| internalize.ll | ||
| lazyload_metadata.ll | ||
| linkonce_aliasee_ref_import.ll | ||
| linkonce_odr_unnamed_addr.ll | ||
| linkonce_resolution_comdat.ll | ||
| lit.local.cfg | ||
| llvm.used.ll | ||
| local_name_conflict.ll | ||
| local_name_conflict_var.ll | ||
| merge-triple.ll | ||
| module_asm2.ll | ||
| module_asm_glob.ll | ||
| module_summary_graph_traits.ll | ||
| newpm-basic.ll | ||
| noinline.ll | ||
| personality-local.ll | ||
| personality.ll | ||
| pr35472.ll | ||
| prefix_replace.ll | ||
| reference_non_importable.ll | ||
| referenced_by_constant.ll | ||
| save_objects.ll | ||
| section.ll | ||
| strong_non_prevailing.ll | ||
| tli-nobuiltin.ll | ||
| weak_resolution.ll | ||
| weak_resolution_single.ll | ||