llvm-project/lldb
Pavel Labath ede7c02b38 [lldb/COFF] Remove strtab zeroing hack
Summary:
This code (recently responsible for a unaligned access sanitizer
failure) claims that the string table offset zero should result in an
empty string.

I cannot find any mention of this detail in the Microsoft COFF
documentation, and the llvm COFF parser also does not handle offset zero
specially. This code was introduced in 0076e7159, which also does not go
into specifics, citing "various bugfixes".

Given that this is obviously a hack, and does not cause tests to fail, I
think we should just delete it.

Reviewers: amccarth, markmentovai

Subscribers: lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D83881
2020-07-17 13:24:59 +02:00
..
bindings [lldb/api] Improve error reporting in SBBreakpoint::AddName (NFCI) 2020-07-01 12:45:05 +02:00
cmake [lldb/Lua] Require Lua 5.3 2020-06-23 09:24:01 -07:00
docs Updated the list of supported platforms in LLDB to include Apple silicon. 2020-07-08 15:33:00 -07:00
examples Harmonize Python shebang 2020-07-16 21:53:45 +02:00
include/lldb [lldb] Store StackFrameRecognizers in the target instead of a global list 2020-07-17 09:26:27 +02:00
packages/Python [lldb/Test] Remove custom tearDownHooks from GDB Remote tests 2020-07-15 13:18:06 -07:00
resources
scripts Harmonize Python shebang 2020-07-16 21:53:45 +02:00
source [lldb/COFF] Remove strtab zeroing hack 2020-07-17 13:24:59 +02:00
test [lldb/DWARF] Don't get confused by line sequences with tombstone values 2020-07-17 11:51:52 +02:00
third_party/Python/module Harmonize Python shebang 2020-07-16 21:53:45 +02:00
tools [intel-pt] Fix building due to CMake + python changes 2020-07-16 12:18:59 -07:00
unittests [lldb] Store StackFrameRecognizers in the target instead of a global list 2020-07-17 09:26:27 +02:00
utils [lldb/Test] Fix missing yaml2obj in Xcode standalone build. 2020-07-10 21:34:56 -07:00
.clang-format
.clang-tidy [lldb] Add .clang-tidy with customization to disable readability-identifier-naming 2020-03-09 12:50:28 -07:00
.gitignore Add .noindex to the gitignore 2019-04-05 17:57:42 +00:00
CMakeLists.txt [lldb/CMake] Only CMAKE_CFG_INTDIR if it's not '.' 2020-03-27 17:49:00 -07:00
CODE_OWNERS.txt [lldb][NFC] Cleanup mentions and code related to lldb-mi 2019-07-19 15:55:23 +00:00
LICENSE.TXT Fix typos throughout the license files that somehow I and my reviewers 2019-01-21 09:52:34 +00:00
use_lldb_suite_root.py