llvm-project/clang/lib
Joel E. Denny 9be6d7edb2 [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug
I'd like to add these comments to warn others of problems I
encountered when trying to use `RemoveLineIfEmpty`.  I originally
tried to fix the problem, but I realized I could implement the
functionality more easily and efficiently in my calling code where I
can make the simplifying assumption that there are no prior edits to
the line from which text is being removed.  While I've lost the
motivation to write a fix, which doesn't look easy, I figure a warning
to others is better than silence.

I've added a unit test to demonstrate the problem.  I don't know how
to mark it as an expected failure, so I just marked it disabled.

Reviewed By: jkorous

Differential Revision: https://reviews.llvm.org/D61466

llvm-svn: 369049
2019-08-15 21:17:48 +00:00
..
ARCMigrate [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
AST [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
ASTMatchers [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
Analysis [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
Basic [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
CodeGen [WebAssembly] Correctly handle va_arg of zero-sized structures 2019-08-15 19:33:36 +00:00
CrossTU [CrossTU] Fix problem with CrossTU AST load limit and progress messages. 2019-08-12 07:15:29 +00:00
DirectoryWatcher [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
Driver [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
Edit [C++2a] Add __builtin_bit_cast, used to implement std::bit_cast 2019-07-02 18:28:13 +00:00
Format [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
Frontend [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
FrontendTool [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
Headers [OpenCL] Fix lang mode predefined macros for C++ mode. 2019-08-12 10:44:07 +00:00
Index [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
Lex [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
Parse [clang] Loop pragma parsing. NFC. 2019-08-15 07:39:05 +00:00
Rewrite [Rewrite][NFC] Add FIXMEs and tests for RemoveLineIfEmpty bug 2019-08-15 21:17:48 +00:00
Sema [Sema] Implement DR2386 for C++17 structured binding 2019-08-15 19:45:28 +00:00
Serialization [Clang] Migrate llvm::make_unique to std::make_unique 2019-08-14 23:04:18 +00:00
StaticAnalyzer [analyzer] Warn about -analyzer-configs being meant for development purposes only 2019-08-15 08:53:16 +00:00
Tooling [Tooling] Add a hack to work around issues with matcher binding in r368681. 2019-08-15 04:10:11 +00:00
CMakeLists.txt Reland [clang] DirectoryWatcher 2019-07-12 20:34:10 +00:00