forked from OSchip/llvm-project
5f56fca4e1
Summary: The args class is used in plenty of places (a lot of them in the lower lldb layers) for representing a list of arguments, and most of these places don't care about option parsing. Moving the option parsing out of the class removes the largest external dependency (there are a couple more, but these are in static functions), and brings us closer to being able to move it to the Utility module). The new home for these functions is the Options class, which was already used as an argument to the parse calls, so this just inverts the dependency between the two. The functions are themselves are mainly just copied -- the biggest functional change I've made to them is to avoid modifying the input Args argument (getopt likes to permute the argument vector), as it was weird to have another class reorder the entries in Args class. So now the functions don't modify the input arguments, and (for those where it makes sense) return a new Args vector instead. I've also made the addition of a "fake arg0" (required for getopt compatibility) an implementation detail rather than a part of interface. While doing that I noticed that ParseForCompletion function was recording the option indexes in the shuffled vector, but then the consumer was looking up the entries in the unshuffled one. This manifested itself as us not being able to complete "watchpoint set variable foo --" (because getopt would move "foo" to the end). Surprisingly all other completions (e.g. "watchpoint set variable foo --w") were not affected by this. However, I couldn't find a comprehensive test for command argument completion, so I consolidated the existing tests and added a bunch of new ones. Reviewers: davide, jingham, zturner Subscribers: lldb-commits Differential Revision: https://reviews.llvm.org/D43837 llvm-svn: 327110 |
||
|---|---|---|
| .. | ||
| CMakeLists.txt | ||
| CommandCompletions.cpp | ||
| CommandObjectApropos.cpp | ||
| CommandObjectApropos.h | ||
| CommandObjectArgs.cpp | ||
| CommandObjectArgs.h | ||
| CommandObjectBreakpoint.cpp | ||
| CommandObjectBreakpoint.h | ||
| CommandObjectBreakpointCommand.cpp | ||
| CommandObjectBreakpointCommand.h | ||
| CommandObjectBugreport.cpp | ||
| CommandObjectBugreport.h | ||
| CommandObjectCommands.cpp | ||
| CommandObjectCommands.h | ||
| CommandObjectDisassemble.cpp | ||
| CommandObjectDisassemble.h | ||
| CommandObjectExpression.cpp | ||
| CommandObjectExpression.h | ||
| CommandObjectFrame.cpp | ||
| CommandObjectFrame.h | ||
| CommandObjectGUI.cpp | ||
| CommandObjectGUI.h | ||
| CommandObjectHelp.cpp | ||
| CommandObjectHelp.h | ||
| CommandObjectLanguage.cpp | ||
| CommandObjectLanguage.h | ||
| CommandObjectLog.cpp | ||
| CommandObjectLog.h | ||
| CommandObjectMemory.cpp | ||
| CommandObjectMemory.h | ||
| CommandObjectMultiword.cpp | ||
| CommandObjectPlatform.cpp | ||
| CommandObjectPlatform.h | ||
| CommandObjectPlugin.cpp | ||
| CommandObjectPlugin.h | ||
| CommandObjectProcess.cpp | ||
| CommandObjectProcess.h | ||
| CommandObjectQuit.cpp | ||
| CommandObjectQuit.h | ||
| CommandObjectRegister.cpp | ||
| CommandObjectRegister.h | ||
| CommandObjectSettings.cpp | ||
| CommandObjectSettings.h | ||
| CommandObjectSource.cpp | ||
| CommandObjectSource.h | ||
| CommandObjectSyntax.cpp | ||
| CommandObjectSyntax.h | ||
| CommandObjectTarget.cpp | ||
| CommandObjectTarget.h | ||
| CommandObjectThread.cpp | ||
| CommandObjectThread.h | ||
| CommandObjectType.cpp | ||
| CommandObjectType.h | ||
| CommandObjectVersion.cpp | ||
| CommandObjectVersion.h | ||
| CommandObjectWatchpoint.cpp | ||
| CommandObjectWatchpoint.h | ||
| CommandObjectWatchpointCommand.cpp | ||
| CommandObjectWatchpointCommand.h | ||