5e3bdbff3f
Fixed the expression parser to handle cases where
...
GetValueForVariableExpressionPath returns NULL and
doesn't set an error.
<rdar://problem/18682916>
llvm-svn: 220070
2014-10-17 18:16:04 +00:00
0e478f5aa3
Make a general helper function on the AST context to retrieve a type by identifier in the fashion needed by data formatters
...
llvm-svn: 220059
2014-10-17 17:56:59 +00:00
8e96e6b6f2
Break out of the command word parsing loop if we hit
...
an invalid combination of words; don't accidentally
continue trying to parse the command line.
clang static analysis fixit.
llvm-svn: 220026
2014-10-17 02:10:33 +00:00
81926c3ffe
Add #if 0 around unreachable block of code to suppress warnings.
...
clang warnings.
llvm-svn: 220025
2014-10-17 01:56:57 +00:00
9bdc4e1a59
Add null-checks around getter/setter before using them.
...
clang static analyzer fixit.
llvm-svn: 220024
2014-10-17 01:55:08 +00:00
84843ed536
A << operation would be undefined for a bit-selecting
...
function because of a '1u' making it a 32-bit value
when it really needed to be a 64-bit value. Trivial to fix
once I figured out what was going on.
clang static analzyer fixit.
llvm-svn: 220022
2014-10-17 01:52:30 +00:00
5b94115d50
Remove always-true part of a conditional expression.
...
clang warning.
llvm-svn: 220018
2014-10-17 01:38:10 +00:00
61e0a3ef1f
Put #if 0 blocks around three sections of code that are intentionally
...
unreachable so we don't get warnings about them.
Completely initialize a structure instead of leaving some of its fields
potentially indeterminate (although in reality they would all be set
before use -- but the compiler warning doesn't know that).
clang warning.
llvm-svn: 220017
2014-10-17 01:36:20 +00:00
cf3ab58e47
Making all @expectedFailure markers take an explicit bugnumber annotation. This used to be optional, but that makes it harder to track what tests are failing for what reason. So, make it mandatory, in the form of refusing to run the test suite if annotations are missing
...
llvm-svn: 220012
2014-10-17 01:11:29 +00:00
4b2f7456ad
Don't enable the log here. It was just me debugging
...
llvm-svn: 220011
2014-10-17 01:09:06 +00:00
ed1d075d78
Add a few more bug IDs for x'fail test cases
...
llvm-svn: 220003
2014-10-17 00:47:44 +00:00
d950fa7165
Made multi-line test case actions possible in
...
the inline test cases. This makes them much
more readable.
llvm-svn: 220001
2014-10-17 00:39:37 +00:00
e2669ba6d4
Attach a bug number to these failures
...
llvm-svn: 219986
2014-10-16 23:17:46 +00:00
d15ad22048
Split this test case to handle each literal kind uniquely
...
llvm-svn: 219985
2014-10-16 23:16:13 +00:00
816cb3eed4
Added a new kind of test case: the "inline" test
...
case. This test case style attempts to shed all
of the boilerplate that is required for test
cases, and let 80% of test cases use a much terser
syntax.
Inline testcases have much simplified python files
(the corresponding .py file should contain two
lines of code) and require no Makefile, because the
Makefile is generated automatically. Breakpoints
are set automatically and the indicated breakpoint
actions (specified after a magic //% comment) are
executed when the breakpoint is hit.
All other testcases are unaffected.
One thing I'm not really happy with yet is the way
multiple actions for the same line are specified.
I'm going to use lang/c/struct_types as a guinea
pig to develop this further.
llvm-svn: 219984
2014-10-16 23:15:22 +00:00
bc464ee614
Change a use of mktemp() to mkstemp() for better security.
...
We have two more uses of mktemp still in the source base
but they'll take a little more consideration.
clang static analyzer fixit.
llvm-svn: 219983
2014-10-16 23:10:03 +00:00
511247188f
The number '5' triggers a bug unrelated to LLDB, and is not instrumental to this test in any way. Use another, randomly chosen, number to make the test pass again and provide useful actionable feedback about things that truly matter
...
llvm-svn: 219982
2014-10-16 23:06:40 +00:00
82909b9f1d
Some more test marking
...
llvm-svn: 219981
2014-10-16 23:03:06 +00:00
d2657c53ac
This test needs the SB headers to make sense
...
llvm-svn: 219980
2014-10-16 23:02:45 +00:00
da3a386622
Add a test for the -b (batch mode) option to the lldb driver.
...
llvm-svn: 219979
2014-10-16 23:02:14 +00:00
a0524bd159
Fix this test case to actually work - it was relying on a certain 'po' output which wasn't occurring
...
llvm-svn: 219978
2014-10-16 23:02:03 +00:00
83e7f68d39
Some more failure to bug tracking
...
llvm-svn: 219973
2014-10-16 22:27:17 +00:00
0d976f0699
Associate a bug tracking ID with this test case
...
llvm-svn: 219972
2014-10-16 22:06:26 +00:00
be7d285e73
This test actually works alright - we were just checking for the wrong string
...
llvm-svn: 219971
2014-10-16 22:04:05 +00:00
d116f4a0a0
I see this test case crash - skip for now
...
llvm-svn: 219970
2014-10-16 21:42:34 +00:00
e5d8eaf042
Only call RemovePersistentVariable on expr_result if that shared
...
pointer contains something.
llvm-svn: 219966
2014-10-16 21:25:43 +00:00
8d9c2da2d1
Rework this code so that it does not trigger a compiler warning. NFC
...
llvm-svn: 219964
2014-10-16 21:18:58 +00:00
48c0440d97
Fix MemoryHistory plugin to check whether the plugin
...
was able to create itself before returning the shared
pointer to it.
clang warning.
llvm-svn: 219936
2014-10-16 16:59:23 +00:00
823d8f6246
Most of this function checks to see if m_process is non-null before
...
dereferencing it, except for this one section of code. Add a null
check around it.
clang static analyzer fix.
llvm-svn: 219920
2014-10-16 08:43:27 +00:00
9bc86593a2
Another logical-or vrs. bitwise-or mixup in ClangUserExpression.
...
clang unreachable code warning.
llvm-svn: 219918
2014-10-16 08:27:27 +00:00
b3795a4f5e
Enable warnings in the debugserver project file..
...
llvm-svn: 219917
2014-10-16 08:16:29 +00:00
0060a38e7b
A series of bit-flag values should be bitwise-or'ed not logical-or'ed.
...
clang unreachable code warning.
llvm-svn: 219916
2014-10-16 08:15:11 +00:00
f8a7cfad6d
Remove unreachable code.
...
llvm-svn: 219915
2014-10-16 08:08:13 +00:00
637822e3d1
Remove unreachable code.
...
llvm-svn: 219914
2014-10-16 08:07:54 +00:00
97e704b2af
Add /* DISABLES CODE */ annotation before if (0) to mark it as intentional.
...
llvm-svn: 219913
2014-10-16 08:07:20 +00:00
a68e4dcd7e
Remove unreachable code.
...
llvm-svn: 219912
2014-10-16 08:05:49 +00:00
665f12a870
Remove unreachable code.
...
llvm-svn: 219911
2014-10-16 08:05:22 +00:00
ecafcb867a
Xcode recommended these changes to the project file. It recommended
...
a number of warnings to be enabled. The one making the most noise
across the code base right now is CLANG_WARN_UNREACHABLE_CODE = YES.
llvm-svn: 219910
2014-10-16 08:04:28 +00:00
60b5da6c3c
Remove unused initialization.
...
clang static analyzer fixit.
llvm-svn: 219909
2014-10-16 07:53:46 +00:00
18f5fd3a43
Remove dead store.
...
clang static analyzer fixit.
llvm-svn: 219908
2014-10-16 07:52:17 +00:00
8b5f2cfc19
Remove dead store.
...
clang static analyzer fixit.
llvm-svn: 219907
2014-10-16 07:49:27 +00:00
1e6cf05763
Remove dead store.
...
clang static analyzer fixit.
llvm-svn: 219905
2014-10-16 07:47:37 +00:00
5cf1e237f0
Remove unused variable.
...
clang static analyzer fixit.
llvm-svn: 219904
2014-10-16 07:41:32 +00:00
275746d768
Ryan Brown's patch to handle DW_OP_call_frame_cfa addresses
...
as load addreses instead of host addresses.
http://reviews.llvm.org/D5735
llvm-svn: 219896
2014-10-16 02:56:12 +00:00
42f4c7e720
Fix accidental over-checking of args in launcherXPCService.
...
llvm-svn: 219895
2014-10-16 02:53:57 +00:00
4ecbc44f79
Fix a potential null pointer deref & a potential memory leak,
...
also reformat to conform to the usual lldb coding conventions
a little better.
clang static analyzer fixit.
llvm-svn: 219893
2014-10-16 02:08:11 +00:00
3206b1e077
Remove unnecessary update of 'name' local.
...
clang static analyzer fixit.
llvm-svn: 219892
2014-10-16 01:55:21 +00:00
3c86c7e3a2
Remove unused change to argc/argv after long option parsing has been completed.
...
clang static analyzer fixit.
llvm-svn: 219891
2014-10-16 01:50:14 +00:00
1446881254
Ensure that user_exe_path is non-NULL before derferencing.
...
We've already created a FileSpec based on this local and
this code path would never be executed if it is an invalid
FilePath - but the static analyzer doesn't know this and I
want to placate it.
clang static analyzer fixit.
llvm-svn: 219890
2014-10-16 01:42:11 +00:00
60db6e43ca
Guard against NULL derefs.
...
clang static analyzer fixits.
llvm-svn: 219889
2014-10-16 01:40:16 +00:00
Sean Callanan