7919beaaf2
Fix a bug with va_arg and vectors on Darwin x86-32. <rdar://problem/11592208>.
...
llvm-svn: 158017
2012-06-05 19:40:46 +00:00
beafa44be8
Reapply "Only emit debug information for methods that are user defined, there's"
...
As the failing testcase has been fixed.
This reverts commit 0637f407e6ee7fdccde17fbf9a5fcc4853187b3e.
llvm-svn: 158009
2012-06-05 18:16:22 +00:00
d3d173ddca
Mips: Define __mips_hard_float macro additional to __mips_single_float
...
when single float ABI is selected.
llvm-svn: 157996
2012-06-05 13:06:56 +00:00
65485d7694
Revert "Only emit debug information for methods that are user defined, there's"
...
This reverts r157970, which was not passing on
clang-x86_64-darwin10-nobootstrap-RA
llvm-svn: 157983
2012-06-05 06:10:39 +00:00
f5dad49a65
Only emit debug information for methods that are user defined, there's
...
not much reason to emit for constructors and destructors that aren't
user defined.
rdar://11593099
llvm-svn: 157970
2012-06-05 00:15:06 +00:00
97c6f2b9e5
Teach format string checking about compile-time CFString constants.
...
Within the guts of CheckFormatHandler, the IsObjCLiteral flag was being used in
two ways: to see if null bytes were allowed, and to see if the '%@' specifier
is allowed.* The former usage has been changed to an explicit test and the
latter pushed down to CheckPrintfHandler and renamed ObjCContext, since it
applies to CFStrings as well.
* This also changes how wide chars are interpreted; in OS X Foundation, the
wide character type is 'unichar', a typedef for short, rather than wchar_t.
llvm-svn: 157968
2012-06-04 23:52:23 +00:00
614e72bec7
Make suggestions for mismatched enum arguments to printf/scanf.
...
llvm-svn: 157962
2012-06-04 22:49:02 +00:00
98709985a6
Teach printf/scanf about enums with fixed underlying types.
...
llvm-svn: 157961
2012-06-04 22:48:57 +00:00
50fba8f0a9
PR13022: cope with parenthesized function types in MS name mangling.
...
llvm-svn: 157959
2012-06-04 22:46:59 +00:00
eb3cad53e7
Add a warning for when an array-to-pointer decay is performed on an array
...
temporary or an array subobject of a class temporary, and the resulting value
is used to initialize a pointer which outlives the temporary. Such a pointer
is always left dangling after the initialization completes and the array's
lifetime ends.
In order to detect this situation, this change also adds an
LValueClassification of LV_ArrayTemporary for temporaries of array type which
aren't subobjects of class temporaries. These occur in C++11 T{...} and GNU C++
(T){...} expressions, when T is an array type. Previously we treated the former
as a generic prvalue and the latter as a class temporary.
llvm-svn: 157955
2012-06-04 22:27:30 +00:00
6310fdd982
[objcmt] Don't migrate to subscripting syntax if the required methods have not
...
been declared on NSArray/NSDictionary.
rdar://11581975
llvm-svn: 157951
2012-06-04 21:23:26 +00:00
4ff9097fcc
[analyzer] Fix a diagnostics bug which lead to a crash on the buildbot.
...
This bug was triggered by r157851. It only happens in the case where we
don't perform optimal diagnostic pruning.
llvm-svn: 157950
2012-06-04 21:03:31 +00:00
22535def43
objective-c: Handle more warning cases for when
...
message receiver is 'weak' property.
// rdar://10225276
llvm-svn: 157946
2012-06-04 19:16:34 +00:00
8388d24701
Fixed a problem related to resolution of built-in headers in case a path of tool's binary contains sym-links.
...
llvm-svn: 157944
2012-06-04 19:02:59 +00:00
f0b67b6f5c
Removing the lambda extension warning concerning single return statements, as it no longer applies.
...
llvm-svn: 157943
2012-06-04 18:57:41 +00:00
88bf06584b
Remove AST and Parse from Driver's dependencies.
...
llvm-svn: 157933
2012-06-04 16:57:53 +00:00
ea155f0153
Require -pie when linking with ASan on Android.
...
llvm-svn: 157923
2012-06-04 11:15:05 +00:00
2b1eda344a
Add fma3 intrinsic header file.
...
llvm-svn: 157913
2012-06-04 03:42:47 +00:00
5bee25884b
When adding built-in operator candidates for overload resolution
...
involving 'restrict', place restrict on the pointer type rather than
on the pointee type. Also make sure that we gather restrict from the
pointer type. Fixes PR12854 and the major part of PR11093.
llvm-svn: 157910
2012-06-04 00:15:09 +00:00
12c9df3a9d
Make disabling SSE levels also disable AVX and FMA.
...
llvm-svn: 157907
2012-06-03 22:23:42 +00:00
1e9e01fabf
Make AES and PCLMUL features imply SSE2 as that's needed to get the right types defined.
...
llvm-svn: 157906
2012-06-03 21:56:22 +00:00
bba778bfd5
Add fma feature flag for Intel FMA instructions.
...
llvm-svn: 157904
2012-06-03 21:46:30 +00:00
cdfb1ae7f7
Improve fixit for comparison operator on lhs of bitwise operator.
...
Before:
test.cc:2:18: note: place parentheses around the == expression to silence this warning
if (0 == flags & 0xdd)
^
( )
Now:
test.cc:2:18: note: place parentheses around the == expression to silence this warning
if (0 == flags & 0xdd)
^
( )
llvm-svn: 157897
2012-06-03 07:07:00 +00:00
3c9aaf1ab8
Initialize the non-target-dependent fields of the Preprocessor in its constructor
...
so we can destroy it even if it was constructed with "DelayInitialization = true",
and we didn't end up calling Preprocessor::Initialize.
Fixes crashes in rdar://11558355
llvm-svn: 157892
2012-06-02 18:08:09 +00:00
4de31654bb
ToolInvocation::mapVirtualFile(): Tweak for Win32. Handle the key as native path.
...
llvm-svn: 157889
2012-06-02 15:34:21 +00:00
590ad8f515
MIPS: Factor out code selects the float ABI as determined by -msoft-float,
...
-mhard-float, and -mfloat-abi= to the new function getMipsFloatABI. That
simplifies reuse of this code.
llvm-svn: 157888
2012-06-02 15:06:29 +00:00
474261af7b
Fix typos found by http://github.com/lyda/misspell-check
...
llvm-svn: 157886
2012-06-02 10:20:41 +00:00
06caf7d59f
Implementation of a "soft opt-in" option for -Wimplicit-fallthrough diagnostics: -Wimplicit-fallthrough-per-method
...
llvm-svn: 157871
2012-06-02 01:01:07 +00:00
7ba2615047
[analyzer] Rely on canBeInlined utility instead of checking CallExpr
...
explicitly.
This will make it easier to add inlining support to more expressions.
llvm-svn: 157870
2012-06-02 00:40:52 +00:00
bec49efdf2
[analyzer] Fix a spurious undef value warning.
...
When we timeout or exceed a max number of blocks within an inlined
function, we retry with no inlining starting from a node right before
the CallEnter node. We assume the state of that node is the state of the
program before we start evaluating the call. However, the node pruning
removes this node as unimportant.
Teach the node pruning to keep the predecessors of the call enter nodes.
llvm-svn: 157860
2012-06-01 23:48:44 +00:00
1b37ea0a5f
[analyzer] Fix lack of coverage after empty inlined function.
...
We should not stop exploring the path after we return from an empty
function.
llvm-svn: 157859
2012-06-01 23:48:40 +00:00
5d6e7c3351
Disable diagnosic path pruning for ReturnUndefChecker.
...
llvm-svn: 157851
2012-06-01 23:04:04 +00:00
c3da376fbc
static analyzer: add inlining support for directly called blocks.
...
llvm-svn: 157833
2012-06-01 20:04:04 +00:00
ba896f17ae
Don't allow multiple correction candidates that have the same identifier
...
but different nested name specifiers to quietly clobber each other so
only one remains if they do not refer to the same NamedDecl. Fixes
PR12951.
llvm-svn: 157823
2012-06-01 18:11:16 +00:00
31a1fc6654
Support C++11 enum forward declarations.
...
Part of rdar://11570854
llvm-svn: 157787
2012-06-01 00:22:57 +00:00
273c7c40b2
[arcmt] Use CFBridgingRetain/CFBridgingRelease instead of __bridge_retained/__bridge_transfer
...
when migrating.
rdar://11569198
llvm-svn: 157785
2012-06-01 00:10:47 +00:00
a0bc07262b
Anonymous union members within a struct are now properly handled as an unevaluated field in C++11 mode. This fixes PR12866.
...
llvm-svn: 157784
2012-06-01 00:02:08 +00:00
34fab5598d
In TypoCorrectionConsumer, BestResults to CorrectionResults to lessen
...
the confusion among all of the uses of Best* in relation to the set of
possible typo correction results. Also add a method to return the set of
typo corrections that have the single best edit distance--it returns the
second half of the first pair in TypoEditDistanceMap (with
getBestEditDistance already returning the first half).
llvm-svn: 157781
2012-05-31 23:32:58 +00:00
bebd0ba549
objc: properties of NSObject attribute must
...
have correct pointer type or issue error,
instead of crashing in IRGen. // rdar:// 11569860
llvm-svn: 157780
2012-05-31 23:18:32 +00:00
698daefb58
[analyzer] Fix BugType memory leak in IdempotentOperationChecker.
...
llvm-svn: 157772
2012-05-31 21:24:58 +00:00
2774f99913
[analyzer] Cleanup for r157721.
...
We should lock the number of elements after the initial parsing is
complete. Recursive AST visitors in AnalyzesConsumer and CallGarph can
trigger lazy pch deserialization resulting in more calls to
HandleTopLevelDecl and appending to the LocalTUDecls list. We should
ignore those.
llvm-svn: 157762
2012-05-31 18:07:55 +00:00
21d6ec9224
Fix an object lifetime issue in clang/Tooling.
...
llvm-svn: 157759
2012-05-31 17:58:43 +00:00
16704bb15b
Allow some BugReports to opt-out of PathDiagnostic callstack pruning until we have significantly
...
improved the pruning heuristics. The current heuristics are pretty good, but they make diagnostics
for uninitialized variables warnings particularly useless in some cases.
llvm-svn: 157734
2012-05-31 06:03:17 +00:00
3f122a7636
Add builtin for pclmulqdq instruction.
...
llvm-svn: 157733
2012-05-31 05:18:48 +00:00
d08d9159c2
Change wording of 'memcpy' type mismatch warning and remove fixit.
...
As per comments following r157659.
llvm-svn: 157722
2012-05-30 23:14:52 +00:00
34d89b7ddc
[analyzer]Fix another occurrence of iterator invalidation (LocalTUDecls)
...
Follow up in r155693, r155680.
Prevents a hard to reproduce crash with the following stack trace:
3 libsystem_c.dylib 0x00007ff55a835050 _sigtramp + 18446744029881443184
4 clang 0x0000000106218e97 (anonymous
namespace)::AnalysisConsumer::HandleTranslationUnit(clang::ASTContext&)
+ 519
5 clang 0x0000000105cf3002 clang::ParseAST(clang::Sema&,
bool, bool) + 690
6 clang 0x00000001059a41d8
clang::ASTFrontendAction::ExecuteAction() + 312
7 clang 0x00000001059a3df7 clang::FrontendAction::Execute()
+ 231
8 clang 0x00000001059b0ecc
clang::CompilerInstance::ExecuteAction(clang::FrontendAction&) + 860
9 clang 0x000000010595e451
clang::ExecuteCompilerInvocation(clang::CompilerInstance*) + 961
10 clang 0x0000000105947f29 cc1_main(char const**, char
const**, char const*, void*) + 969
11 clang 0x0000000105958259 main + 473
12 clang 0x0000000105947b34 start + 52
llvm-svn: 157721
2012-05-30 23:14:48 +00:00
68f6d3b1a6
Suggest '%@' for Objective-C objects in ObjC format strings.
...
llvm-svn: 157716
2012-05-30 21:53:13 +00:00
7e6ad46275
Disable -Wunique-enum for anonymous enums.
...
This is a large class of false positives where anonymous enums are used to
declare constants (see Clang's Diagnostics.h for example). A small number of
true positives could probably be found in this bucket by still warning if the
anonymous enum is used in a declarator (enum { ... } x;) but so far we don't
believe this to be a source of significant benefit so I haven't bothered to
preserve those cases.
General offline review/acknowledgment by rtrieu.
llvm-svn: 157713
2012-05-30 20:45:14 +00:00
a1d29cd471
objective-c: revert r157407. It broke a project
...
and reported as PR12959. // rdar://11499742
llvm-svn: 157697
2012-05-30 17:33:54 +00:00
8b1c60220d
Adds a toString method to Replacement, which helps debugging.
...
Adds missing header guards to Refactoring.h.
llvm-svn: 157694
2012-05-30 16:04:29 +00:00
9e8d22896c
Fixed a memory leak in clang/Tooling.
...
llvm-svn: 157687
2012-05-30 12:10:28 +00:00
9ee12508ca
SSE4A should not imply LZCNT and POPCNT. FMA4 should imply SSE4A. Add missing break at the end of btver1 feature list.
...
llvm-svn: 157680
2012-05-30 05:54:54 +00:00
9fd12db1c0
Update FIXME. ABM is already covered by LZCNT and POPCNT.
...
llvm-svn: 157676
2012-05-30 04:49:49 +00:00
13586ab6d8
Remove some extra braces.
...
llvm-svn: 157667
2012-05-30 01:14:28 +00:00
01cf09302d
Add new -Wunique-enum which will warn on enums which all elements have the
...
same value and were initialized with literals. Clang will warn on code like
this:
enum A {
FIRST = 1,
SECOND = 1
};
llvm-svn: 157666
2012-05-30 01:01:11 +00:00
869aeccada
Add fixits for memory access warnings.
...
Also, do not display the builtin name and macro expansion when the
function is a builtin.
llvm-svn: 157659
2012-05-30 00:34:21 +00:00
b6499eb60d
objc: position of 'fixit' was off by one.
...
This patch fixes it. // rdar://11488351
llvm-svn: 157646
2012-05-29 21:52:45 +00:00
b5dd2cb13c
objective-c: fix a sema and IRGen crash when property
...
getter result type is safe but does not match with property
type resulting in spurious warning followed by crash in
IRGen. // rdar://11515196
llvm-svn: 157641
2012-05-29 19:56:01 +00:00
1ab16ba501
Install ammintrin.h in the cmake build.
...
llvm-svn: 157639
2012-05-29 19:36:17 +00:00
ba6e2528fa
Add an ammintrin.h header for SSE4a intrinsics.
...
This is a clean-room implementation based on public documentation and
I tried to validate it as much as possible against gcc.
llvm-svn: 157638
2012-05-29 19:10:17 +00:00
217dc2d8dd
MIPS: Pass -KPIC argument to MIPS assembler if necessary.
...
llvm-svn: 157635
2012-05-29 19:07:33 +00:00
a16b7fd029
Factor out the code retrieves the last PIC related argument from
...
the Clang::ConstructJob() to the new ArgList::getLastArg() routine
with eight argument. That simplifies reusing of this code.
llvm-svn: 157633
2012-05-29 18:50:33 +00:00
8ac9c22391
Define __SSE4A__ when targeting new AMD CPUs.
...
This doesn't really fit the existing SSELevel so it gets an extra flag.
llvm-svn: 157630
2012-05-29 17:48:39 +00:00
48b812854e
Fix indenting.
...
llvm-svn: 157628
2012-05-29 17:05:42 +00:00
67030280f9
Sparc is bigendian.
...
llvm-svn: 157626
2012-05-29 16:10:50 +00:00
dda3a7f914
Make Clang driver pass the last option from -g group to the compiler.
...
Leave a better fixme for different debug info flags
llvm-svn: 157602
2012-05-29 08:10:34 +00:00
e8ccc1134b
Use fewer temporaries mangling APSInt objects. The performance difference
...
is negligible, but it makes the code clearer. Based on a suggestion by
Jordy Rose.
llvm-svn: 157601
2012-05-29 07:01:45 +00:00
aac265cc78
OpenCL: Fix vector conditional operator CodeGen for the case where
...
the operands are vectors of doubles.
llvm-svn: 157596
2012-05-29 00:35:18 +00:00
7e64fd9d53
Address minor FIXME in RedeclLink to contain a PointerIntPair instead of derive from it.
...
Use actual factory functions rather than derived classes acting as named constructors/factories.
llvm-svn: 157588
2012-05-28 19:38:42 +00:00
6770dea704
Fix mangling of integral template arguments between 1 and 10. Add a test case
...
for this. Reported by Timur Iskhodzhanov.
llvm-svn: 157583
2012-05-28 16:53:33 +00:00
ee855f06e7
Fix Lang's fix. This should fix the tests for +Asserts builds.
...
llvm-svn: 157561
2012-05-28 03:54:22 +00:00
a2db6f2bd8
adjust to mainline llvm API change.
...
llvm-svn: 157557
2012-05-28 01:47:53 +00:00
c4c0e8aa9a
Fix PR12960 by not attempting to correct cases when we're not actually instantiatiating a template.
...
This comes up in the begin/end calls of a range-for (see the included test
case). Other suggestions are welcome, though this seems to do the trick without
regressing anything.
llvm-svn: 157553
2012-05-28 01:26:45 +00:00
ea388a2832
PR12962: Fix a rare use after free when collecting virtual overrides.
...
The DenseMap reallocates after 64 insertions so this only happened in
large test cases under very specific circumstances.
llvm-svn: 157549
2012-05-27 22:41:08 +00:00
6ccb51130e
Fix call to APSInt constructor - it doesn't take an initial value, just a
...
bitwidth and signedness. Also rename the variable to reflect its purpose.
No test case - discovered during random code exploration.
llvm-svn: 157547
2012-05-27 21:39:49 +00:00
f021889036
-Wdeprecated warning to include reference (as a note)
...
to the declaration in this patch. // rdar://10893232
llvm-svn: 157537
2012-05-27 16:59:48 +00:00
b33ffee04f
Use the SelectorSet typedef more widely throughout Sema.
...
While there make it a SmallPtrSet.
llvm-svn: 157532
2012-05-27 13:28:52 +00:00
69b5a60d96
Replace some custom hash combines with the standard stuff from DenseMapInfo.
...
llvm-svn: 157531
2012-05-27 13:28:44 +00:00
ce6ad6748a
clang/lib/Rewrite/Rewriter.cpp: Don't try to rename opened files on Win32. Win32 doesn't allow rename/removing opened files.
...
llvm-svn: 157528
2012-05-27 12:59:58 +00:00
5511dfb399
Mangle template instantiations properly (as of VC 7.x) when compiling for
...
the Microsoft Visual C++ ABI. Currently limited to type and integral
non-type arguments. Based on a patch by Timur Iskhodzhanov!
llvm-svn: 157524
2012-05-26 23:12:19 +00:00
7b01b578a9
Only emit one set of braces for __VERSION__, getClangFullRepositoryVersion already adds some.
...
No test as the output is highly dependend on the local configuration.
llvm-svn: 157520
2012-05-26 19:39:52 +00:00
f3b7681f2b
Change warning to error when property setter names conflict.
...
// rdar://11528439
llvm-svn: 157517
2012-05-26 16:10:06 +00:00
1bb8edb8ac
In response to some discussions on IRC, tweak the wording of the new
...
-Wsometimes-uninitialized diagnostics to make it clearer that the cause
of the issue may be a condition which must always evaluate to true or
false, rather than an uninitialized variable.
To emphasize this, add a new note with a fixit which removes the
impossible condition or replaces it with a constant.
Also, downgrade the diagnostic from -Wsometimes-uninitialized to
-Wconditional-uninitialized when it applies to a range-based for loop,
since the condition is not written explicitly in the code in that case.
llvm-svn: 157511
2012-05-26 06:20:46 +00:00
3d8edc24c7
Fix indentation.
...
llvm-svn: 157510
2012-05-26 05:35:39 +00:00
246e85ddb0
Don't offer '[[clang::fallthrough]];' fix-it when a fall-through occurs to a
...
switch label immediately followed by a 'break;'.
llvm-svn: 157508
2012-05-26 00:49:15 +00:00
f491fbd715
fix codegen support for alloc_size attribute for static C++ methods
...
add test case for C++ codegen
llvm-svn: 157500
2012-05-25 21:45:08 +00:00
67a498cc5f
Don't ignore linkage when ignoring visibility in the instantiation of a
...
method template.
llvm-svn: 157486
2012-05-25 17:22:33 +00:00
147dcd8c33
add CodeGen support for the alloc_size attribute
...
llvm-svn: 157483
2012-05-25 17:04:42 +00:00
340941dc16
Don't ignore linkage when ignoring visibility in the instantiation of a
...
function template.
llvm-svn: 157480
2012-05-25 16:41:35 +00:00
6a65819ba3
[analyzer] Don't crash on LValBitCast
...
llvm-svn: 157478
2012-05-25 16:02:16 +00:00
a28bf63d9a
Consider the linkage for member class templates even when we have to ignore
...
the visibility.
llvm-svn: 157475
2012-05-25 15:51:26 +00:00
0cf10ac9ab
When ignoring visibility in an instantiation, still consider the linkage.
...
Similar fixes for function and member template to follow as I write the
testcases.
llvm-svn: 157470
2012-05-25 14:47:05 +00:00
4d71d0f9fa
Whitespace fixes.
...
llvm-svn: 157469
2012-05-25 14:17:45 +00:00
4323bf8e2e
Split a chunk of -Wconditional-uninitialized warnings out into a separate flag,
...
-Wsometimes-uninitialized. This detects cases where an explicitly-written branch
inevitably leads to an uninitialized variable use (so either the branch is dead
code or there is an uninitialized use bug).
This chunk of warnings tentatively lives within -Wuninitialized, in order to
give it more visibility to existing Clang users.
llvm-svn: 157458
2012-05-25 02:17:09 +00:00
14340ca173
ensure value passed to is space is representable as unsigned char
...
if the value isn't an unsigned char or EOF behavior is undefined
(and on Windows there's an assertion)
llvm-svn: 157445
2012-05-25 00:03:29 +00:00
3d31e8b280
Some cleanups around the uninitialized variables warning, and a FIXME. No functional change.
...
llvm-svn: 157440
2012-05-24 23:45:35 +00:00
c37a1d6e0f
cleanup some code.
...
llvm-svn: 157436
2012-05-24 22:59:56 +00:00
3f88afad2f
objective-c: warn on use of property setters
...
backing two propeties because proprty names
match except for first letter being of different
case. // rdar://11528439, [PR12936].
llvm-svn: 157435
2012-05-24 22:48:38 +00:00
c49c22642b
Get rid of some non-ASCII en-dashes that crept in.
...
llvm-svn: 157434
2012-05-24 22:36:31 +00:00
f798f65ccc
Implement the C++11 discarded value expression rules for volatile lvalues. <rdar://problem/10790820>.
...
llvm-svn: 157420
2012-05-24 22:04:19 +00:00
Eli Friedman