Sean Callanan
35e678c7e0
Don't allow the expression parser to magically
...
look through 'self' at its ivars. It produces
surprising results.
<rdar://problem/18698760>
llvm-svn: 220220
2014-10-20 18:36:58 +00:00
Zachary Turner
cb5742b828
Don't use mkstemp, as it doesn't exist on Windows.
...
Differential Revision: http://reviews.llvm.org/D5849
Reviewed by: Jason Molenda
llvm-svn: 220218
2014-10-20 17:46:56 +00:00
Zachary Turner
10687b0ea5
Remove LLDB_DEFAULT_SHELL #define, and determine this at runtime.
...
Differential Revision: http://reviews.llvm.org/D5805
Reviewed by: Greg Clayton
llvm-svn: 220217
2014-10-20 17:46:43 +00:00
Sean Callanan
5e3bdbff3f
Fixed the expression parser to handle cases where
...
GetValueForVariableExpressionPath returns NULL and
doesn't set an error.
<rdar://problem/18682916>
llvm-svn: 220070
2014-10-17 18:16:04 +00:00
Enrico Granata
0e478f5aa3
Make a general helper function on the AST context to retrieve a type by identifier in the fashion needed by data formatters
...
llvm-svn: 220059
2014-10-17 17:56:59 +00:00
Jason Molenda
8e96e6b6f2
Break out of the command word parsing loop if we hit
...
an invalid combination of words; don't accidentally
continue trying to parse the command line.
clang static analysis fixit.
llvm-svn: 220026
2014-10-17 02:10:33 +00:00
Jason Molenda
81926c3ffe
Add #if 0 around unreachable block of code to suppress warnings.
...
clang warnings.
llvm-svn: 220025
2014-10-17 01:56:57 +00:00
Jason Molenda
9bdc4e1a59
Add null-checks around getter/setter before using them.
...
clang static analyzer fixit.
llvm-svn: 220024
2014-10-17 01:55:08 +00:00
Jason Molenda
84843ed536
A << operation would be undefined for a bit-selecting
...
function because of a '1u' making it a 32-bit value
when it really needed to be a 64-bit value. Trivial to fix
once I figured out what was going on.
clang static analzyer fixit.
llvm-svn: 220022
2014-10-17 01:52:30 +00:00
Jason Molenda
5b94115d50
Remove always-true part of a conditional expression.
...
clang warning.
llvm-svn: 220018
2014-10-17 01:38:10 +00:00
Jason Molenda
61e0a3ef1f
Put #if 0 blocks around three sections of code that are intentionally
...
unreachable so we don't get warnings about them.
Completely initialize a structure instead of leaving some of its fields
potentially indeterminate (although in reality they would all be set
before use -- but the compiler warning doesn't know that).
clang warning.
llvm-svn: 220017
2014-10-17 01:36:20 +00:00
Jason Molenda
bc464ee614
Change a use of mktemp() to mkstemp() for better security.
...
We have two more uses of mktemp still in the source base
but they'll take a little more consideration.
clang static analyzer fixit.
llvm-svn: 219983
2014-10-16 23:10:03 +00:00
Jason Molenda
e5d8eaf042
Only call RemovePersistentVariable on expr_result if that shared
...
pointer contains something.
llvm-svn: 219966
2014-10-16 21:25:43 +00:00
Enrico Granata
8d9c2da2d1
Rework this code so that it does not trigger a compiler warning. NFC
...
llvm-svn: 219964
2014-10-16 21:18:58 +00:00
Jason Molenda
48c0440d97
Fix MemoryHistory plugin to check whether the plugin
...
was able to create itself before returning the shared
pointer to it.
clang warning.
llvm-svn: 219936
2014-10-16 16:59:23 +00:00
Jason Molenda
823d8f6246
Most of this function checks to see if m_process is non-null before
...
dereferencing it, except for this one section of code. Add a null
check around it.
clang static analyzer fix.
llvm-svn: 219920
2014-10-16 08:43:27 +00:00
Jason Molenda
9bc86593a2
Another logical-or vrs. bitwise-or mixup in ClangUserExpression.
...
clang unreachable code warning.
llvm-svn: 219918
2014-10-16 08:27:27 +00:00
Jason Molenda
0060a38e7b
A series of bit-flag values should be bitwise-or'ed not logical-or'ed.
...
clang unreachable code warning.
llvm-svn: 219916
2014-10-16 08:15:11 +00:00
Jason Molenda
f8a7cfad6d
Remove unreachable code.
...
llvm-svn: 219915
2014-10-16 08:08:13 +00:00
Jason Molenda
637822e3d1
Remove unreachable code.
...
llvm-svn: 219914
2014-10-16 08:07:54 +00:00
Jason Molenda
97e704b2af
Add /* DISABLES CODE */ annotation before if (0) to mark it as intentional.
...
llvm-svn: 219913
2014-10-16 08:07:20 +00:00
Jason Molenda
a68e4dcd7e
Remove unreachable code.
...
llvm-svn: 219912
2014-10-16 08:05:49 +00:00
Jason Molenda
665f12a870
Remove unreachable code.
...
llvm-svn: 219911
2014-10-16 08:05:22 +00:00
Jason Molenda
60b5da6c3c
Remove unused initialization.
...
clang static analyzer fixit.
llvm-svn: 219909
2014-10-16 07:53:46 +00:00
Jason Molenda
18f5fd3a43
Remove dead store.
...
clang static analyzer fixit.
llvm-svn: 219908
2014-10-16 07:52:17 +00:00
Jason Molenda
8b5f2cfc19
Remove dead store.
...
clang static analyzer fixit.
llvm-svn: 219907
2014-10-16 07:49:27 +00:00
Jason Molenda
1e6cf05763
Remove dead store.
...
clang static analyzer fixit.
llvm-svn: 219905
2014-10-16 07:47:37 +00:00
Jason Molenda
5cf1e237f0
Remove unused variable.
...
clang static analyzer fixit.
llvm-svn: 219904
2014-10-16 07:41:32 +00:00
Jason Molenda
275746d768
Ryan Brown's patch to handle DW_OP_call_frame_cfa addresses
...
as load addreses instead of host addresses.
http://reviews.llvm.org/D5735
llvm-svn: 219896
2014-10-16 02:56:12 +00:00
Jason Molenda
42f4c7e720
Fix accidental over-checking of args in launcherXPCService.
...
llvm-svn: 219895
2014-10-16 02:53:57 +00:00
Jason Molenda
4ecbc44f79
Fix a potential null pointer deref & a potential memory leak,
...
also reformat to conform to the usual lldb coding conventions
a little better.
clang static analyzer fixit.
llvm-svn: 219893
2014-10-16 02:08:11 +00:00
Jason Molenda
1446881254
Ensure that user_exe_path is non-NULL before derferencing.
...
We've already created a FileSpec based on this local and
this code path would never be executed if it is an invalid
FilePath - but the static analyzer doesn't know this and I
want to placate it.
clang static analyzer fixit.
llvm-svn: 219890
2014-10-16 01:42:11 +00:00
Jason Molenda
60db6e43ca
Guard against NULL derefs.
...
clang static analyzer fixits.
llvm-svn: 219889
2014-10-16 01:40:16 +00:00
Jason Molenda
d31c800ce0
Ah, accidentally committed a patch I didn't mean to.
...
llvm-svn: 219888
2014-10-16 01:27:31 +00:00
Jason Molenda
320e7b3897
It's possible for long_options[long_options_index].definition to be null
...
from the previous for() loop - check that it is non-null before trying
to deref it.
clang static analyzer fixit.
llvm-svn: 219887
2014-10-16 01:26:51 +00:00
Jason Molenda
aee7eb5ed1
Check that process is non-null before calling a method in it.
...
clang static analyzer fixit.
llvm-svn: 219886
2014-10-16 01:23:06 +00:00
Jason Molenda
4c9bd87916
It's possible for this function to not be passed a CompUnit*; add
...
guards around a few additional uses of the cu local pointer.
clang static analyzer fixit.
llvm-svn: 219885
2014-10-16 01:21:25 +00:00
Jason Molenda
76513fd9bc
Give old_state a default value so we won't try to restore
...
an uninitialized value. In reality the code block that
initializes it and the code block that restores it will always
match up - but the analyzer doesn't know that and I want to
quiet it, so...
clang static analyzer fixit.
llvm-svn: 219869
2014-10-15 23:39:31 +00:00
Jason Molenda
900dbdc4d9
Give user_id a default invalid value so we don't
...
possibly use it uninitialized in a log message later.
clang static analyzer fixit.
llvm-svn: 219865
2014-10-15 23:27:12 +00:00
Jason Molenda
026aa4962a
Mechanical change to FastDemangle to make it closer to the lldb
...
coding conventions. Lots of whitespace et al changes but no
content changes.
llvm-svn: 219856
2014-10-15 22:11:15 +00:00
Enrico Granata
de4de39c9d
This should keep the non-Xcode-based builds happy
...
llvm-svn: 219853
2014-10-15 21:39:17 +00:00
Enrico Granata
5510a5762c
Add synthetic children support for NSIndexPath
...
llvm-svn: 219852
2014-10-15 21:38:32 +00:00
Enrico Granata
db2ecad3cd
The NSDate formatter should use GMT instead of the local timezone. Fixes rdar://13416848
...
llvm-svn: 219841
2014-10-15 20:18:58 +00:00
Greg Clayton
807b6b326d
Allow ThreadLauncher::LaunchThread() to specify a minimum stack byte size when launching threads.
...
This defaults to zero, which means to use the system default.
NOTE: Windows will need to implement this.
<rdar://problem/18644448>
llvm-svn: 219821
2014-10-15 18:03:59 +00:00
Zachary Turner
cb37ddda0d
Remove some unnecessary headers from Host.cpp
...
After the recent migration of code out of Host.cpp, many
unnecessary headers were still being included. This prunes the
include list down to only what is still necessary.
llvm-svn: 219814
2014-10-15 17:27:11 +00:00
Matthew Gardiner
6e7b0a088e
Improve the handling of kalimba ELF file section type recognition.
...
Recognise the SHT_NOBITS property in kalimba ELF, and determine this to be
of type zerofilled. Subsequently recognise this type to represent bytes
on the target's DATA address space, and therefore be sized accordingly.
llvm-svn: 219782
2014-10-15 08:21:54 +00:00
Jason Molenda
270c52c8dc
Be more consistent about null checks for the Process and ABI
...
in GetFullUnwindPlanForFrame() - the code was mostly checking
that we had an active Process and ABI but not always.
clang static analyzer fixit.
llvm-svn: 219772
2014-10-15 03:11:37 +00:00
Jason Molenda
d91a662a2e
Make sure local var cu is non-NULL before dereferencing.
...
(it was checked for NULL-ness in some places, not in others)
clang static analyzer fixit.
llvm-svn: 219771
2014-10-15 03:07:39 +00:00
Jason Molenda
4d9f3b0e50
Remove unneeded local var initialization.
...
clang static analyzer fixit.
llvm-svn: 219770
2014-10-15 03:06:23 +00:00
Jason Molenda
9aae9fcbaf
Make sure is_indirect local var is initialized; there
...
exists a code path where it could be used while uninitialized.
clang static analyzer fixit.
llvm-svn: 219769
2014-10-15 03:05:38 +00:00