3 Commits

Author	SHA1	Message	Date
Weverything	9740f9f0b6	Add -Wtautological-compare to -Wall ... Some warnings in -Wtautological-compare subgroups are DefaultIgnore. Adding this group to -Wmost, which is part of -Wall, will aid in their discoverability. Differential Revision: https://reviews.llvm.org/D69292	2019-11-12 14:36:57 -08:00
Richard Trieu	8b0d14a8f0	New tautological warning for bitwise-or with non-zero constant always true. ... Taking a value and the bitwise-or it with a non-zero constant will always result in a non-zero value. In a boolean context, this is always true. if (x | 0x4) {} // always true, intended '&' This patch creates a new warning group -Wtautological-bitwise-compare for this warning. It also moves in the existing tautological bitwise comparisons into this group. A few other changes were needed to the CFGBuilder so that all bool contexts would be checked. The warnings in -Wtautological-bitwise-compare will be off by default due to using the CFG. Fixes: https://bugs.llvm.org/show_bug.cgi?id=42666 Differential Revision: https://reviews.llvm.org/D66046 llvm-svn: 375318	2019-10-19 00:57:23 +00:00
Jordan Rose	7afd71e4ff	Add a check for tautological bitwise comparisons to -Wtautological-compare. ... This catches issues like: if ((x & 8) == 4) { ... } if ((x | 4) != 3) { ... } Patch by Anders Rönnholm! llvm-svn: 209221	2014-05-20 17:31:11 +00:00