Haojian Wu
54829bb3ff
Fix an undefined behavior when storing an empty StringRef.
...
Summary: Passing a nullptr to memcpy is UB.
Reviewers: ioeric
Subscribers: llvm-commits, cfe-commits
Differential Revision: https://reviews.llvm.org/D50966
llvm-svn: 340170
2018-08-20 13:12:54 +00:00
Sam McCall
4bb7883d09
[Support] Add a UniqueStringSaver: like StringSaver, but deduplicating.
...
Summary: Clarify contract of StringSaver (it null-terminates, callers rely on it).
Reviewers: hokein
Subscribers: llvm-commits
Differential Revision: https://reviews.llvm.org/D49596
llvm-svn: 337677
2018-07-23 10:44:40 +00:00
Mehdi Amini
ec4fb5ba97
Use StringRef in StringSaver API (NFC)
...
llvm-svn: 283290
2016-10-05 01:32:41 +00:00
Rafael Espindola
b82455d262
There is only one saver of strings.
...
llvm-svn: 244854
2015-08-13 01:07:02 +00:00
Rafael Espindola
454adf6454
Bring in a BumpPtrStringSaver from lld and simplify the interface.
...
StringSaver now always saves to a BumpPtrAllocator.
The only reason for having the virtual saveImpl is so lld can have a
thread safe version.
The reason for the distinct BumpPtrStringSaver class is to avoid the
virtual destructor.
llvm-svn: 239669
2015-06-13 12:49:52 +00:00