llvm-project

Commit Graph

Author	SHA1	Message	Date
Alex Zinenko	f5e736c448	SDBM: fix the order of variables in the stripe-induced inequalities The initial implementation of SDBM mistakenly swapped the order of variables in the inequalities induced by a stripe equality: y = x # B actually implies y - x <= 0 and x - y <= B - 1 rather than x - y <= 0 and y - x <= B - 1 as implemented. Textual comments in the test files were correct but did not correspond to the emitted IR. Round-tripping between SDBM and expression lists was not affected because the wrong order was used in both directions of the conversion. Use the correct order. PiperOrigin-RevId: 251252980	2019-06-03 19:26:29 -07:00
Alex Zinenko	3b500c694d	Move SDBM uniquer into the SDBM dialect MLIRContext does not have to be aware of the SDBM unique data structures directly. Move the SDBM storage uniquer from MLIRContext to the SDBM dialect instance. Expressions that previously required a context to be constructed now require an instance of the dialect in order to access the uniquer. While they could look up the dialect in the context, it would have introduced a rather expensive lookup into each construction. Instead, the caller is expected to obtain the dialect instance and cache it. -- PiperOrigin-RevId: 249245199	2019-06-01 19:54:43 -07:00
Alex Zinenko	6804cf2429	Move SDBM infrastructure into a new SDBM dialect We now have sufficient extensibility in dialects to move attribute components such as SDBM out of the core IR into a dedicated dialect and make them optional. Introduce an SDBM dialect and move the code. This is a mostly non-functional change. -- PiperOrigin-RevId: 249244802	2019-06-01 19:54:33 -07:00

Author

SHA1

Message

Date

Alex Zinenko

f5e736c448

SDBM: fix the order of variables in the stripe-induced inequalities

The initial implementation of SDBM mistakenly swapped the order of variables in
the inequalities induced by a stripe equality: y = x # B actually implies
y - x <= 0 and x - y <= B - 1 rather than x - y <= 0 and y - x <= B - 1 as
implemented.  Textual comments in the test files were correct but did not
correspond to the emitted IR.  Round-tripping between SDBM and expression lists
was not affected because the wrong order was used in both directions of the
conversion.  Use the correct order.

PiperOrigin-RevId: 251252980

2019-06-03 19:26:29 -07:00

Alex Zinenko

3b500c694d

Move SDBM uniquer into the SDBM dialect

MLIRContext does not have to be aware of the SDBM unique data structures
    directly.  Move the SDBM storage uniquer from MLIRContext to the SDBM dialect
    instance.  Expressions that previously required a context to be constructed now
    require an instance of the dialect in order to access the uniquer.  While they
    could look up the dialect in the context, it would have introduced a rather
    expensive lookup into each construction.  Instead, the caller is expected to
    obtain the dialect instance and cache it.

--

PiperOrigin-RevId: 249245199

2019-06-01 19:54:43 -07:00

Alex Zinenko

6804cf2429

Move SDBM infrastructure into a new SDBM dialect

We now have sufficient extensibility in dialects to move attribute components
    such as SDBM out of the core IR into a dedicated dialect and make them
    optional.  Introduce an SDBM dialect and move the code.  This is a mostly
    non-functional change.

--

PiperOrigin-RevId: 249244802

2019-06-01 19:54:33 -07:00

3 Commits