6 Commits

Author	SHA1	Message	Date
Endre Fülöp	141cb8a1ee	[analyzer] Model iterator random incrementation symmetrically ... Summary: In case a pointer iterator is incremented in a binary plus expression (operator+), where the iterator is on the RHS, IteratorModeling should now detect, and track the resulting value. Reviewers: Szelethus, baloghadamsoftware Reviewed By: baloghadamsoftware Subscribers: rnkovacs, whisperity, xazax.hun, baloghadamsoftware, szepet, a.sidorin, mikhail.ramalho, Szelethus, donat.nagy, dkrupp, Charusso, steakhal, martong, ASDenysPetrov, cfe-commits Tags: #clang Differential Revision: https://reviews.llvm.org/D83190	2020-08-04 11:04:12 +02:00
Adam Balogh	a59d4ae431	[Analyzer] Hotfix for various crashes in iterator checkers ... The patch that introduces handling iterators implemented as pointers may cause crash in some projects because pointer difference is mistakenly handled as pointer decrement. (Similair case for iterators implemented as class instances are already handled correctly.) This patch fixes this issue. The second case that causes crash is comparison of an iterator implemented as pointer and a null-pointer. This patch contains a fix for this issue as well. The third case which causes crash is that the checker mistakenly considers all integers as nonloc::ConcreteInt when handling an increment or decrement of an iterator implemented as pointers. This patch adds a fix for this too. The last case where crashes were detected is when checking for success of an std::advance() operation. Since the modeling of iterators implemented as pointers is still incomplete this may result in an assertion. This patch replaces the assertion with an early exit and adds a FIXME there. Differential Revision: https://reviews.llvm.org/D83295	2020-07-16 20:49:33 +02:00
Adam Balogh	c79745ed48	[Analyzer] Quick fix for broken tests on Windows	2020-07-01 12:52:47 +02:00
Adam Balogh	9e63b190af	[Analyzer] Handle pointer implemented as iterators in iterator checkers ... Iterators are an abstraction of pointers and in some data structures iterators may be implemented by pointers. This patch adds support for iterators implemented as pointers in all the iterator checkers (including iterator modeling). Differential Revision: https://reviews.llvm.org/D82185	2020-07-01 09:04:28 +02:00
Adam Balogh	ea563daae5	[Analyzer] Fix errors in iterator modeling ... There is major a bug found in iterator modeling: upon adding a value to or subtracting a value from an iterator the position of the original iterator is also changed beside the result. This patch fixes this bug. To catch such bugs in the future we also changed the tests to look for regular expressions including an end-of-line symbol (`$`) so we can prevent false matches where only the tested prefix matches. Another minor bug is that when printing the state, all the iterator positions are printed in a single line. This patch also fixes this. Differential Revision: https://reviews.llvm.org/D82385	2020-07-01 09:04:28 +02:00
Adam Balogh	eb90692d8a	[Analyzer] Rename test `iterator-modelling.cpp` to `iterator-modeling.cpp` ... Typo fix.	2020-03-30 09:23:35 +02:00