Rafael Espindola
8bab889b0f
Convert getSymbolSection to return an ErrorOr.
...
This function can actually fail since the symbol contains an index to the
section and that can be invalid.
llvm-svn: 244375
2015-08-07 23:27:14 +00:00
Davide Italiano
810329490a
[llvm-cxxdump] Don't rely on global state
...
Differential Revision: http://reviews.llvm.org/D11227
llvm-svn: 242509
2015-07-17 06:18:36 +00:00
Rafael Espindola
ed067c45d4
Return ErrorOr from getSymbolAddress.
...
It can fail trying to get the section on ELF and COFF. This makes sure the
error is handled.
llvm-svn: 241366
2015-07-03 18:19:00 +00:00
Rafael Espindola
5d0c2ffadf
Return ErrorOr from SymbolRef::getName.
...
This function can really fail since the string table offset can be out of
bounds.
Using ErrorOr makes sure the error is checked.
Hopefully a lot of the boilerplate code in tools/* can go away once we have
a diagnostic manager in Object.
llvm-svn: 241297
2015-07-02 20:55:21 +00:00
Rafael Espindola
96d071cd0c
Don't return error_code from function that never fails.
...
llvm-svn: 241021
2015-06-29 23:29:12 +00:00
Rafael Espindola
6bf322101b
Make computeSymbolSizes never fail.
...
On ELF that was already the case since getting the size of a symbol
never fails.
On MachO and COFF we could fail trying to get the section of a symbol. But
we don't really need the section, just the section number to know if two
symbols are in the same section or not.
llvm-svn: 240580
2015-06-24 19:57:32 +00:00
Rafael Espindola
a4a4093ed8
Compute correct symbol sizes for MachO and COFF.
...
Before this would dump from the symbol start to the end of the section.
llvm-svn: 240367
2015-06-23 02:20:37 +00:00
Rafael Espindola
5eb02e45e3
Simplify another function that doesn't fail.
...
llvm-svn: 238703
2015-06-01 00:27:26 +00:00
Richard Trieu
46f2cc9e44
Change range-based for-loop to use const auto&. No functionality change.
...
llvm-svn: 234974
2015-04-15 03:17:49 +00:00
Richard Trieu
6b1aa5f5e1
Change range-based for-loops to be -Wrange-loop-analysis clean.
...
No functionality change.
llvm-svn: 234963
2015-04-15 01:21:15 +00:00
Benjamin Kramer
16132e6faa
Purge unused includes throughout libSupport.
...
NFC.
llvm-svn: 232976
2015-03-23 18:07:13 +00:00
David Majnemer
f45bbd0da3
llvm-cxxdump: Rename llvm-vtabledump to llvm-cxxdump
...
llvm-vtabledump has grown enough functionality not related to vtables
that it deserves a name which is more descriptive.
llvm-svn: 232301
2015-03-15 01:30:58 +00:00