5 Commits

Author	SHA1	Message	Date
Michael Benfield	cf49cae278	[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable ... These are intended to mimic warnings available in gcc. Differential Revision: https://reviews.llvm.org/D100581	2021-06-01 15:38:48 -07:00
Arthur Eubanks	3a0b6dc3e8	Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable" ... This reverts commit 14dfb3831c. More false positives, see D100581.	2021-05-17 12:16:10 -07:00
Michael Benfield	14dfb3831c	[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable ... These are intended to mimic warnings available in gcc. Reviewed By: aeubanks Differential Revision: https://reviews.llvm.org/D100581	2021-05-17 11:02:26 -07:00
Arthur Eubanks	6d8d133862	Revert "[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable" ... This reverts commit 9b0501abc7. False positives reported in D100581.	2021-04-28 12:47:18 -07:00
Michael Benfield	9b0501abc7	[Clang] -Wunused-but-set-parameter and -Wunused-but-set-variable ... These are intended to mimic warnings available in gcc. -Wunused-but-set-variable is triggered in the case of a variable which appears on the LHS of an assignment but not otherwise used. For instance: void f() { int x; x = 0; } -Wunused-but-set-parameter works similarly, but for function parameters instead of variables. In C++, they are triggered only for scalar types; otherwise, they are triggered for all types. This is gcc's behavior. -Wunused-but-set-parameter is controlled by -Wextra, while -Wunused-but-set-variable is controlled by -Wunused. This is slightly different from gcc's behavior, but seems most consistent with clang's behavior for -Wunused-parameter and -Wunused-variable. Reviewed By: aeubanks Differential Revision: https://reviews.llvm.org/D100581	2021-04-26 15:09:03 -07:00