llvm-project

Commit Graph

Author	SHA1	Message	Date
Vitaly Buka	81b293ba36	[tests][sanitizers] Don't reflow comments This lets us to apply ColumnLimit without breaking "RUN:" lines.	2021-08-03 12:54:00 -07:00
Fangrui Song	2fec8860d8	[sanitizer] Set IndentPPDirectives: AfterHash in .clang-format Code patterns like this are common, `#` at the line beginning (https://google.github.io/styleguide/cppguide.html#Preprocessor_Directives), one space indentation for if/elif/else directives. ``` #if SANITIZER_LINUX # if defined(__aarch64__) # endif #endif ``` However, currently clang-format wants to reformat the code to ``` #if SANITIZER_LINUX #if defined(__aarch64__) #endif #endif ``` This significantly harms readability in my review. Use `IndentPPDirectives: AfterHash` to defeat the diagnostic. clang-format will now suggest: ``` #if SANITIZER_LINUX # if defined(__aarch64__) # endif #endif ``` Unfortunately there is no clang-format option using indent with 1 for just preprocessor directives. However, this is still one step forward from the current behavior. Reviewed By: #sanitizers, vitalybuka Differential Revision: https://reviews.llvm.org/D100238	2021-05-03 13:49:41 -07:00
Vitaly Buka	a7b079534a	[compiler-rt] Use "ColumnLimit: 0" instead of "clang-format off" in tests Reviewers: eugenis, jfb Subscribers: kubamracek, dberris, llvm-commits Differential Revision: https://reviews.llvm.org/D55152 llvm-svn: 348061	2018-12-01 01:24:29 +00:00

Author

SHA1

Message

Date

Vitaly Buka

81b293ba36

[tests][sanitizers] Don't reflow comments

This lets us to apply ColumnLimit without breaking "RUN:" lines.

2021-08-03 12:54:00 -07:00

Fangrui Song

2fec8860d8

[sanitizer] Set IndentPPDirectives: AfterHash in .clang-format

Code patterns like this are common, `#` at the line beginning
(https://google.github.io/styleguide/cppguide.html#Preprocessor_Directives),
one space indentation for if/elif/else directives.
```
#if SANITIZER_LINUX
# if defined(__aarch64__)
# endif
#endif
```

However, currently clang-format wants to reformat the code to
```
#if SANITIZER_LINUX
#if defined(__aarch64__)
#endif
#endif
```

This significantly harms readability in my review.  Use `IndentPPDirectives:
AfterHash` to defeat the diagnostic. clang-format will now suggest:

```
#if SANITIZER_LINUX
#  if defined(__aarch64__)
#  endif
#endif
```

Unfortunately there is no clang-format option using indent with 1 for
just preprocessor directives. However, this is still one step forward
from the current behavior.

Reviewed By: #sanitizers, vitalybuka

Differential Revision: https://reviews.llvm.org/D100238

2021-05-03 13:49:41 -07:00

Vitaly Buka

a7b079534a

[compiler-rt] Use "ColumnLimit: 0" instead of "clang-format off" in tests

Reviewers: eugenis, jfb

Subscribers: kubamracek, dberris, llvm-commits

Differential Revision: https://reviews.llvm.org/D55152

llvm-svn: 348061

2018-12-01 01:24:29 +00:00

3 Commits