Commit Graph

67 Commits

Author SHA1 Message Date
Petr Hosek f3f5f1209e Allow building both shared and static library
This change allows building both shared and static version of libunwind
in a single build, sharing object files between both versions.

Differential Revision: https://reviews.llvm.org/D23233

llvm-svn: 278067
2016-08-08 22:55:48 +00:00
Eugene Zelenko 5608df9b6a CMakeLists.txt cleanups: synchronize version and CMake minimum required version with rest of LLVM, consistent spacing.
Differential revision: https://reviews.llvm.org/D23094

llvm-svn: 278029
2016-08-08 17:56:28 +00:00
Saleem Abdulrasool f7e4524910 unwind: disable executable stacks
Similar to compiler-rt, ensure that we disable executable stacks for the custom
assembly.

llvm-svn: 277868
2016-08-05 21:35:28 +00:00
Ed Maste 1ed39291a5 libunwind: correct return code in unwinding trace log message
llvm-svn: 277215
2016-07-29 21:24:19 +00:00
Oliver Stannard 1224c809f1 [libunwind][ARM] Add support for Thumb1 targets
The Thumb1 version of the code for saving and restoring the unwind
context has a few bugs which prevent it from working:
* It uses the STM instruction without writeback, which is not valid for Thumb1
  (It was introduced in Thumb2).
* It only saves/restores the low 8 registers, the sp and the lr, so if a
  program uses r8-r12 they will not be correctly restored when throwing an
  exception.

There aren't currently any Thumb1 build-bots to test this, but we have
been successfully running the libc++abi and libc++ test suites on
Cortex-M0 models, as well as some other test suites that use C++
exceptions on a downstream version of libunwind with this patch applied.

Differential Revision: https://reviews.llvm.org/D22292

llvm-svn: 276625
2016-07-25 09:21:56 +00:00
Eric Fiselier 19f802ff68 [libunwind] Properly align _Unwind_Exception.
Summary: _Unwind_Exception is required to be double word aligned. Currently the struct is under aligned.

Reviewers: mclow.lists, compnerd, kledzik, emaste

Subscribers: emaste, cfe-commits

Differential Revision: https://reviews.llvm.org/D22543

llvm-svn: 276215
2016-07-20 23:56:42 +00:00
Eric Fiselier de337b876f Update .arcconfig
llvm-svn: 276214
2016-07-20 23:56:17 +00:00
Ed Maste 41020b94a3 libunwind: limit stack usage in unwind cursor
Obtained from FreeBSD SVN r302475

Differential Revision:	https://reviews.llvm.org/D22570

llvm-svn: 276128
2016-07-20 15:19:09 +00:00
Ed Maste 5c5e51459f libunwind: sync some coments with NetBSD's version
NetBSD's system unwinder is a modified version of LLVM's libunwind.
Slightly reduce diffs by updating comments to match theirs where
appropriate.

llvm-svn: 275997
2016-07-19 17:28:38 +00:00
Ed Maste c073b1bac9 libunwind: Use conventional DWARF capitalization in comments and errors
llvm-svn: 275996
2016-07-19 17:15:50 +00:00
Asiri Rathnayake 0bdb5f971b [PATCH] [libunwind][ehabi] Use early returns where possible.
Just a minor code cleanup. NFC.

llvm-svn: 274840
2016-07-08 12:13:31 +00:00
Asiri Rathnayake f33c3423ec [libunwind][ARM] Improve unwinder stack usage - Make WMMX support optional
These registers are only available on a limited set of ARM targets (those
based on XScale). Other targets should not have to pay the cost of these.

This patch shaves off about ~300 bytes of stack usage and ~1KB of code-size.

Differential revision: http://reviews.llvm.org/D21991
Reviewers: bcraig, compnerd

Change-Id: I2d7a1911a193bd70b123e78747e1a7d1482463c7
llvm-svn: 274744
2016-07-07 10:55:39 +00:00
Asiri Rathnayake af914fa2db [libunwind] Improve unwinder stack usage - III
Implement the same optimization committed under r271004 on non-EHABI,
non-SJLJ unwinder as well.

Change-Id: I7f80ed91a75d1e778b50ba87cf8fb68658a083c7
llvm-svn: 272680
2016-06-14 15:51:01 +00:00
Asiri Rathnayake b3698ba361 [libunwind] Remove unused code.
The whole file is guarded with #if _LIBUNWIND_ARM_EHABI, and then in the
middle we have these two blocks, which render them pretty unused. An
artefact of a refactoring it seems.

NFC.

llvm-svn: 271737
2016-06-03 20:57:48 +00:00
Eric Fiselier b1403c9d99 Attempt to fix libunwind build
llvm-svn: 271466
2016-06-02 01:50:10 +00:00
Eric Fiselier b7a373971d Add status/warning message for 32 bit builds
llvm-svn: 271462
2016-06-02 01:19:52 +00:00
Eric Fiselier 0447bde044 [libunwind] Allow target flags to affect CMake configuration tests
Summary:
This patch changes the libunwind CMake so that it adds certain target flags like '-m32' or '--gcc-toolchain' before including config-ix.cmake.
Since these flags can affect things like check_library_exists([...]) they needed to be added before the tests are performed.

Additionally this patch adds LIBUNWIND_BUILD_32_BITS which defaults to LLVM_BUILD_32_BITS.

This patch fixes:

https://llvm.org/bugs/show_bug.cgi?id=27950
https://llvm.org/bugs/show_bug.cgi?id=27959

Reviewers: jroelofs, danalbert, bcraig, rmaprath, compnerd

Subscribers: cfe-commits

Differential Revision: http://reviews.llvm.org/D20889

llvm-svn: 271458
2016-06-02 01:02:10 +00:00
Asiri Rathnayake 45e59f7198 [libunwind] Improve unwinder stack usage - II
unwind_phase1 and unwind_phase2 allocate their own copies of unw_cursor_t buffers
on the stack. This can blow-up stack usage of the unwinder depending on how these
two functions get inlined into _Unwind_RaiseException. Clang seems to inline
unwind_phase1 into _Unwind_RaiseException but not unwind_phase2, thus creating
two unw_cursor_t buffers on the stack.

One way to work-around this problem is to mark both unwind_phase1 and
unwind_phase2 as noinline. This patch takes the less compiler-dependent approach
and explicitly allocate a unw_cursor_t buffer and pass that into unwind_phase1
and unwind_phase2 functions.

A follow-up patch will replicate this behavior for the non-EHABI and non-SJLJ
implementations.

Reviewers: jroelofs, bcraig.

Differential revision: http://reviews.llvm.org/D20320

llvm-svn: 271004
2016-05-27 15:41:45 +00:00
Asiri Rathnayake 85624c5de3 [libunwind] Disable cross-unwinding by default.
Cross unwinding requires larger sizes for unw_context_t and unw_cursor_t
buffers (large enough to hold the VRS of any architecture). This is not
desirable for the most common situation where libunwind is used for native
unwinding only.

This patch makes native unwinding the default build configuration. This
will start testing the tigher (compile-time) bounds of unw_context_t
and unw_cursor_t buffers for each architecture.

Change-Id: Ic61c476a75603ca4812959c233cfe56f83dc0b00
llvm-svn: 270972
2016-05-27 08:29:27 +00:00
Asiri Rathnayake 88fe85071d Use size_t to store the results of sizeof calculations.
NFC.

llvm-svn: 270927
2016-05-26 21:56:04 +00:00
Asiri Rathnayake c6a4ab0ce3 Fix gcc libunwind build.
r270692 seems to have broken gcc builds of libunwind. This is because
statements like:
  static_assert(check_fit<Registers_or1k, unw_context_t>::does_fit,
                "or1k registers do not fit into unw_context_t");
Do not work when static_assert is a macro taking two parameters, the
extra comma separating the template parameters confuses the pre-processor.
The fix is to change those statements to:
  static_assert((check_fit<Registers_or1k, unw_context_t>::does_fit),
                "or1k registers do not fit into unw_context_t");

Also fixed a gcc warning about a trivial un-intended narrowing.

Differential revision: http://reviews.llvm.org/D20119

llvm-svn: 270925
2016-05-26 21:45:54 +00:00
Asiri Rathnayake 54387eef07 Introduce a native-only unwinder build.
Currently libunwind is built to support cross-unwinding [1] by default, which
requires the buffers unw_context_t and unw_cursor_t to be large enough to hold
the vritual register set (VRS) of any supported architecture. This is not
desirable for some platforms where the stack usage of the unwinder needs
to be kept to a minimum (e.g. bare-metal targets). The current patch introduces
a native-only (-DLIBUNWIND_ENABLE_CROSS_UNWINDING=OFF) unwinder variant that
adopts strict sizes for the buffers unw_context_t and unw_cursor_t depending
on the target architecture.

[1] http://www.nongnu.org/libunwind/man/libunwind(3).html#section_4

Change-Id: I380fff9a56c16a0fc520e3b1d8454a34b4a48373
llvm-svn: 270692
2016-05-25 12:36:34 +00:00
Saleem Abdulrasool 9a6a8eaf07 unwind: remove last instance of -Wexpansion-to-defined
This unifies the definition of _LIBUNWIND_BUILD_SJLJ_APIS.  It also further
generalises the definition to allow building these APIs on non-Apple targets
when `-fsjlj-excceptions` is used.  The header is now clean of macros which
expand to defined checks.

llvm-svn: 267509
2016-04-26 01:11:29 +00:00
Saleem Abdulrasool 2d59e711a7 unwind: remove unnecessary header
Availablity.h is not used within config.h.  The locations which use the
availability infrastructure already include the necessary header(s).  NFC.

llvm-svn: 267365
2016-04-24 21:01:04 +00:00
Saleem Abdulrasool 03a061ffeb unwind: unify _LIBUNWIND_ABORT
Rather than use the `__assert_rtn` on libSystem based targets and a local
`assert_rtn` function on others, expand the function definition into a macro
which will perform the writing to stderr and then abort.  This unifies the
definition and behaviour across targets.

Ensure that we flush stderr prior to aborting.

llvm-svn: 267364
2016-04-24 21:00:59 +00:00
Saleem Abdulrasool 39d86f44cb unwind: unify some more macros
The macros were defined identically across both cases.  Unify the definitions to
have a single definition for _LIBUWNIND_{HIDDEN,EXPORT} and _LIBUNWIND_LOG.
NFC.

llvm-svn: 267169
2016-04-22 17:11:05 +00:00
Saleem Abdulrasool 0195c5e796 unwind: remove another instance of -Wexpansion-to-defined
Remove the use of undefined behaviour in the c preprocessor by always defining
the value according to the state that was being checked.  NFC.

llvm-svn: 266927
2016-04-20 22:18:50 +00:00
Saleem Abdulrasool cb06f7511c unwind: unify the definition of _LIBUNWIND_SUPPORT_FRAME_APIS
Unify the definition of the _LIBUNWIND_SUPPORT_FRAME_APIS macro.  This is in
preparation to remove another instance of -Wexpansion-to-defined.  NFC.

llvm-svn: 266926
2016-04-20 22:18:47 +00:00
Saleem Abdulrasool a0ec6a58f5 unwind: remove a second instance of -Wexpansion-to-defined
Remove the use of undefined behaviour in the c preprocessor by always defining
the value according to the state that was being checked.  NFC.

llvm-svn: 266916
2016-04-20 20:54:55 +00:00
Saleem Abdulrasool 87bd085e88 unwind: remove an instance of -Wexpansion-to-defined
This follows the pattern in the Apple clause duplicating a tuple of definitions.
However, it will define them to a value rather than a defined check to remove
the `-Wexpansion-to-defined` warning (which may be treated as an error).

This also opens the door to unifying the two code paths into one.

NFC.

llvm-svn: 266915
2016-04-20 20:54:51 +00:00
Saleem Abdulrasool 62f3726365 unwind: unify _LIBUNWIND_SUPPORT_DWARF_UNWIND
Join the two paths for this macro.  At the end of the day, the difference was
that MIPS and ARM on Apple have different behaviour.  This is a setup change to
remove an instance of -Wexpansion-to-defined.  NFC.

llvm-svn: 266913
2016-04-20 20:53:40 +00:00
Renato Golin a6a92a4421 [AArch64] Fix libunwind build when using GNU assembler
Use x29 and x30 for fp and lr respectively.

This does not change the code generation with integrated asm
but using x30 and x29 helps compile the code with gnu as. Currently gas
fails to assemble this code with errors as below.

Error: operand X should be an integer register.

Newer versions of binutils should be fixed, but enough exists in the wild
to make this change harmless and worthy.

Patch by Khem Raj.

llvm-svn: 260595
2016-02-11 21:22:57 +00:00
Kamil Rytarowski c94bd04802 Introduce NetBSD support
Current FreeBSD and NetBSD code is compatible.

llvm-svn: 260001
2016-02-06 18:19:29 +00:00
Kamil Rytarowski d08eabfeb5 Adapt LLVM_CMAKE_PATH for recent cmake path changes
Current LLVM installs CMake files under lib/cmake/llvm.

llvm-svn: 259994
2016-02-06 16:23:18 +00:00
Evgeniy Stepanov 9b44fa87f3 Replace cmake check for printf with a check for fopen.
Printf is a builtin, and the check fails with -Werror because of a clang
warning about an incompatible redeclaration.

llvm-svn: 255188
2015-12-10 00:47:08 +00:00
Peter Zotov b0342a66a0 Make it possible to use libunwind without heap.
This patch allows to use libunwind on bare-metal systems that do not
include malloc/free by conditionally turning off nonessential
functionality that requires these functions.

The disabled functionality includes:

  * the .cfi_remember_state and .cfi_restore_state instructions;
  * the DWARF FDE cache.

The .cfi_{remember,restore}_state instructions don't seem to be used
by contemporary compilers. None of the LLVM backends emit it.

The DWARF FDE cache is bypassed if _LIBUNWIND_NO_HEAP is defined.
Specifically, entries are never added to it, so the search begins
and ends at the statically allocated, empty initial cache.

Such heap-less libunwind on a bare metal system is successfully used
in the ARTIQ project[1], and it is my hope that it will be useful
elsewhere.

[1]: http://m-labs.hk/artiq

Differential Revision: http://reviews.llvm.org/D11897

llvm-svn: 252452
2015-11-09 06:57:29 +00:00
Ed Maste 5f1896a1ab Add FreeBSD _Unwind_Ptr typedef
Differential Revision:	http://reviews.llvm.org/D13820

llvm-svn: 250541
2015-10-16 19:40:09 +00:00
Vasileios Kalintiris 8518eb54f3 unwind: Allow the building of libunwind for MIPS.
Summary:
Currently, libunwind doesn't support MIPS. However, with this patch
we do allow the library to build, and we warn the user about the lack of
support for MIPS. Also, the dummy unw_getcontext() implementation for MIPS just
traps on function entry in order to avoid any confusion with silent/weird
failures at runtime.

This allows us to test an LLVM-based toolchain without the dependency on a
GCC toolchain. Of course, C++ exception handling and other things that depend
on stack unwinding will not work until we add a proper implementation of the
stub functions.

Reviewers: compnerd, logan

Subscribers: dsanders, llvm-commits

Differential Revision: http://reviews.llvm.org/D13160

llvm-svn: 248673
2015-09-26 18:26:01 +00:00
Saleem Abdulrasool 520aaa2f7d unwind: cleanup -Wunused-parameter
Cleanup a number of `-Wunused-parameter` warnings.  NFC.

llvm-svn: 246528
2015-09-01 04:29:03 +00:00
Peter Zotov ce4c5c9849 [libunwind] Add support for OpenRISC 1000.
This patch makes no assumptions on ABI past the ABI defined in
the OpenRISC 1000 spec except that the DWARF register numbers will
be 0-31 for registers r0-r31, which is true for both gcc and
clang at the moment.

llvm-svn: 246413
2015-08-31 05:26:37 +00:00
Peter Zotov 43ad01462a [libunwind] Remove unused includes.
llvm-svn: 246143
2015-08-27 06:58:31 +00:00
Saleem Abdulrasool fddd0e66de unwind: fix invalid memory access
Fix out-of-bounds array access when setting arm float registers.

Patch by Leandro Graciá Gil!

llvm-svn: 245665
2015-08-21 03:21:31 +00:00
Ed Maste ef766a7e70 Enable zero-cost exceptions on non-Apple arm64 platforms
Use the canonical __aarch64__ predefined macro for 64-bit ARM. Apple-
specific cases are left as __arm64__. Also add an #error for unsupported
architectures to catch this sort of case in the future.

Differential Revision: http://reviews.llvm.org/D12005

llvm-svn: 244893
2015-08-13 14:21:03 +00:00
Ed Maste 76050da17e Correct sense of unwind return address register range assertion
I encountered this on FreeBSD/arm64, and then found the same issue was
reported by Daniil Troshkov.

llvm-svn: 244892
2015-08-13 13:45:45 +00:00
Tanya Lattner d93178de50 Revert test commit.
llvm-svn: 244297
2015-08-06 23:31:37 +00:00
Tanya Lattner 901f3c7bc0 Test commit
llvm-svn: 244296
2015-08-06 23:30:28 +00:00
Renato Golin 14c3c4bb85 [ARM/Unwind] Fix wrong usage of write-back on register save
The register save routine in libunwind was using write-back addressing
mode to r0 for thumb, when that was not only different from the ARM
version and more importantly the register restore, but also saving the
wrong address.

Patch by Manuel Freiberger.

Fixes PR24331.

llvm-svn: 244237
2015-08-06 18:15:17 +00:00
Tanya Lattner c1452f80cf Update to new lists.llvm.org
llvm-svn: 244005
2015-08-05 04:01:47 +00:00
Renato Golin 57cb9919c5 [libunwind] Flip order of extern "C" and attribute(visibility)
GCC doesn't seems to like having the attribute before extern, but
Clang accepts it either way. This patch makes it compile on both.

llvm-svn: 243147
2015-07-24 19:29:05 +00:00
Logan Chien ff8fbf9f90 unwind: Fix libc++abi and libgcc build.
To build libc++abi without libunwind, we should make sure that all
function calls to _Unwind_{Get,Set}{GR,IP}() are inlined as function
calls to _Unwind_VRS_{Get,Set}().  Otherwise, libc++abi.so will fail to
link since libgcc does not provide these symbol at all.

This commit fixes the problem by providing both the inlined version and
exported version.

llvm-svn: 243073
2015-07-24 00:16:48 +00:00