3 Commits

Author	SHA1	Message	Date
CJ Johnson	a568411444	[clang-tidy] Update bugprone-stringview-nullptr to consistently prefer the empty string when passing arguments to constructors/functions ... Previously, function(nullptr) would have been fixed with function({}). This unfortunately can change overload resolution and even become ambiguous. T(nullptr) was already being fixed with T(""), so this change just brings function calls in line with that. Differential Revision: https://reviews.llvm.org/D117840	2022-01-20 18:08:40 -05:00
CJ Johnson	7e29da875c	Add support for return values in bugprone-stringview-nullptr ... bugprone-stringview-nullptr was not initially written with tests for return statements. After landing the check, the thought crossed my mind to add such tests. After writing them, I realized they needed additional handling in the matchers. Differential Revision: https://reviews.llvm.org/D115121	2022-01-12 16:53:13 -05:00
CJ Johnson	6a9487df73	Add new clang-tidy check for string_view(nullptr) ... Checks for various ways that the `const CharT*` constructor of `std::basic_string_view` can be passed a null argument and replaces them with the default constructor in most cases. For the comparison operators, braced initializer list does not compile so instead a call to `.empty()` or the empty string literal are used, where appropriate. This prevents code from invoking behavior which is unconditionally undefined. The single-argument `const CharT*` constructor does not check for the null case before dereferencing its input. The standard is slated to add an explicitly-deleted overload to catch some of these cases: wg21.link/p2166 https://reviews.llvm.org/D114823 is a companion change to prevent duplicate warnings from the `bugprone-string-constructor` check. Reviewed By: ymandel Differential Revision: https://reviews.llvm.org/D113148	2021-12-02 13:25:28 +00:00