llvm-project

Commit Graph

Author	SHA1	Message	Date
Reid Kleckner	0404605dda	Expand aggregate arguments more often on 32-bit Windows Before this change, we would pass all non-HFA record arguments on Windows with byval. Byval often blocks optimizations and results in bad code generation. Windows now uses the existing workaround that other x86_32 platforms use. I also expanded the workaround to handle C++ records with constructors on Windows. On non-Windows platforms, we have to keep generating the same LLVM IR prototypes if we want our bitcode to be ABI compatible. Otherwise we will encounter mismatch issues like PR21573. Essentially fixes PR27522 in Clang instead of LLVM. Reviewers: hans Differential Revision: http://reviews.llvm.org/D19756 llvm-svn: 268261	2016-05-02 17:41:07 +00:00
Saleem Abdulrasool	aca550fdb5	CodeGen: make i686-windows-itanium more similar to msvc The itanium environment follows the system calling convention for structures. Pass small aggregates via registers. llvm-svn: 222680	2014-11-24 20:14:29 +00:00
Saleem Abdulrasool	ec5c624550	CodeGen: tweak struct ABI handling Cygwin and MinGW fail to conform to the underlying system's structure passing ABI. Make the check more precise to ensure that we correctly generate code for the itanium environment. llvm-svn: 222626	2014-11-23 02:16:24 +00:00

Author

SHA1

Message

Date

Reid Kleckner

0404605dda

Expand aggregate arguments more often on 32-bit Windows

Before this change, we would pass all non-HFA record arguments on
Windows with byval. Byval often blocks optimizations and results in bad
code generation. Windows now uses the existing workaround that other
x86_32 platforms use.

I also expanded the workaround to handle C++ records with constructors
on Windows. On non-Windows platforms, we have to keep generating the
same LLVM IR prototypes if we want our bitcode to be ABI compatible.
Otherwise we will encounter mismatch issues like PR21573.

Essentially fixes PR27522 in Clang instead of LLVM.

Reviewers: hans

Differential Revision: http://reviews.llvm.org/D19756

llvm-svn: 268261

2016-05-02 17:41:07 +00:00

Saleem Abdulrasool

aca550fdb5

CodeGen: make i686-windows-itanium more similar to msvc

The itanium environment follows the system calling convention for structures.
Pass small aggregates via registers.

llvm-svn: 222680

2014-11-24 20:14:29 +00:00

Saleem Abdulrasool

ec5c624550

CodeGen: tweak struct ABI handling

Cygwin and MinGW fail to conform to the underlying system's structure passing
ABI.  Make the check more precise to ensure that we correctly generate code for
the itanium environment.

llvm-svn: 222626

2014-11-23 02:16:24 +00:00

3 Commits