llvm-project

Commit Graph

Author	SHA1	Message	Date
Christian Sigg	81d5412439	Simplify setting up LLVM as bazel external repo Only require one intermediate repository instead of two. Fewer parameters in llvm_config. Second attempt of https://reviews.llvm.org/D107714, this time also updating `third_party_build` and `deps_impl` paths. Reviewed By: GMNGeoffrey Differential Revision: https://reviews.llvm.org/D108274	2021-08-19 09:37:26 +02:00
Michael McLoughlin	b4f8a000f6	[Bazel] Change external_zlib attribute to string When using `llvm_zlib_external` rule with `external_zlib` attribute set to a label referring to the main repository, like `@//third_party/zlib`, it will be replaced with `//third_party/zlib` after template substitution. This will then attempt to find `//third_party/zlib` within the local repository `@llvm_zlib//third_party/zlib`, which does not exist, rather than the intended reference back to the main repository. The issue appears to be that the conversion of `Label` type to string with `str(repository_ctx.attr.external_zlib)`, which is causing the main repository qualifier to be lost. This diff fixes the issue by changing the `external_zlib` attribute to `attr.string` type rather than `attr.label`. In future a more elegant solution may be possible that preserves use of the `Label` type, depending on resolution of the issue https://github.com/bazelbuild/bazel/issues/13731. Ported from Github PR https://github.com/google/llvm-bazel/pull/236. Reviewed By: GMNGeoffrey Differential Revision: https://reviews.llvm.org/D106606	2021-07-22 16:02:37 -07:00
Geoffrey Martin-Noble	4aeb2e60df	Introduce a Bazel build configuration This patch introduces configuration for a Bazel BUILD in a side directory in the monorepo. This is following the approval of https://github.com/llvm/llvm-www/blob/main/proposals/LP0002-BazelBuildConfiguration.md As detailed in the README, the Bazel BUILD is not supported by the community in general, and is maintained only by interested parties. It follows the requirements of the LLVM peripheral tier: https://llvm.org/docs/SupportPolicy.html#peripheral-tier. This is largely copied from https://github.com/google/llvm-bazel, with a few filepath tweaks and the addition of the README. Reviewed By: echristo, keith, dblaikie, kuhar Differential Revision: https://reviews.llvm.org/D90352	2021-06-22 12:47:43 -07:00

Author

SHA1

Message

Date

Christian Sigg

81d5412439

Simplify setting up LLVM as bazel external repo

Only require one intermediate repository instead of two.
Fewer parameters in llvm_config.

Second attempt of https://reviews.llvm.org/D107714, this time also updating `third_party_build` and `deps_impl` paths.

Reviewed By: GMNGeoffrey

Differential Revision: https://reviews.llvm.org/D108274

2021-08-19 09:37:26 +02:00

Michael McLoughlin

b4f8a000f6

[Bazel] Change external_zlib attribute to string

When using `llvm_zlib_external` rule with `external_zlib` attribute set to a
label referring to the main repository, like `@//third_party/zlib`, it will be
replaced with `//third_party/zlib` after template substitution. This will then
attempt to find `//third_party/zlib` within the local repository
`@llvm_zlib//third_party/zlib`, which does not exist, rather than the intended
reference back to the main repository. The issue appears to be that the
conversion of `Label` type to string with
`str(repository_ctx.attr.external_zlib)`, which is causing the main repository
qualifier to be lost.

This diff fixes the issue by changing the `external_zlib` attribute to
`attr.string` type rather than `attr.label`.

In future a more elegant solution may be possible that preserves use of the
`Label` type, depending on resolution of the issue
https://github.com/bazelbuild/bazel/issues/13731.

Ported from Github PR https://github.com/google/llvm-bazel/pull/236.

Reviewed By: GMNGeoffrey

Differential Revision: https://reviews.llvm.org/D106606

2021-07-22 16:02:37 -07:00

Geoffrey Martin-Noble

4aeb2e60df

Introduce a Bazel build configuration

This patch introduces configuration for a Bazel BUILD in a side
directory in the monorepo.

This is following the approval of
https://github.com/llvm/llvm-www/blob/main/proposals/LP0002-BazelBuildConfiguration.md

As detailed in the README, the Bazel BUILD is not supported
by the community in general, and is maintained only by interested
parties. It follows the requirements of the LLVM peripheral tier:
https://llvm.org/docs/SupportPolicy.html#peripheral-tier.

This is largely copied from https://github.com/google/llvm-bazel,
with a few filepath tweaks and the addition of the README.

Reviewed By: echristo, keith, dblaikie, kuhar

Differential Revision: https://reviews.llvm.org/D90352

2021-06-22 12:47:43 -07:00

3 Commits