1827415be4
Do not assume RLIM_INFINITY is always (rlim_t)-1in sanitizers code
...
Differential Revision: http://reviews.llvm.org/D5212
llvm-svn: 217308
2014-09-06 07:52:51 +00:00
dcb98e5dcc
Intercept sigfillset() and sigemptyset() for sanitizers needs on FreeBSD
...
Differential Revision: http://reviews.llvm.org/D5206
llvm-svn: 217307
2014-09-06 07:46:55 +00:00
eead048ee9
Enable sanitizers' libignore on FreeBSD
...
Differential Revision: http://reviews.llvm.org/D5205
llvm-svn: 217306
2014-09-06 07:41:22 +00:00
62063b46fc
Use "-gline-tables-only" instead of "-g" in sanitizer test suites.
...
We are interested in verifying that -gline-tables-only provides enough
debug information for verbose error reports and symbolized stack traces.
llvm-svn: 217284
2014-09-05 22:05:32 +00:00
869342c1cb
[ASan] disable zero_page_pc.cc on Android.
...
Bug: https://code.google.com/p/address-sanitizer/issues/detail?id=336
llvm-svn: 217228
2014-09-05 06:26:08 +00:00
1fb81720ec
[asan] relax the assertion around array cookie load; still need to extract a reproducer where this assertion fails...
...
llvm-svn: 217215
2014-09-05 01:16:30 +00:00
f537aeaea1
[ASan] Remove the call to GetPageSizeCached from fast path of FastPoisonShadow
...
llvm-svn: 217194
2014-09-04 20:47:27 +00:00
d147590492
[asan] trying to de-flake new_array_cookie_uaf_test.cc
...
llvm-svn: 217177
2014-09-04 18:02:59 +00:00
cc0d7eeb6d
profile: Avoid name collisions between instrumentation and runtime
...
The naming scheme we're using for counters in profile data shares a
prefix with some fixed names we use for the runtime, notably
__llvm_profile_data_begin and _end. Embarrassingly, this means a
function called begin() can't be instrumented.
This modifies the runtime names so as not to collide with the
instrumentation.
llvm-svn: 217166
2014-09-04 15:45:31 +00:00
7c3d581e8a
[ASan] Remove the check for a double-SEGV from zero_page_pc.cc
...
Looks like the second crash doesn't happen on Mac.
llvm-svn: 217165
2014-09-04 15:40:25 +00:00
2132b704ff
Intercept _exit() for sanitizers' needs on FreeBSD
...
Differential Revision: http://reviews.llvm.org/D5171
llvm-svn: 217156
2014-09-04 14:24:27 +00:00
3c821c0200
Fix building sanitizer_linux_libcdep.cc on FreeBSD
...
Differential Revision: http://reviews.llvm.org/D5166
llvm-svn: 217148
2014-09-04 13:58:59 +00:00
e9ca1c72be
[msan] Fix fork test on centos-6.5.
...
Missing <atomic> header.
llvm-svn: 217142
2014-09-04 11:07:42 +00:00
bb91e02efd
[msan] Make origin tracking fork-safe.
...
Chained origins make plain memory stores async-signal-unsafe.
We already disable it inside signal handlers.
This change grabs all origin-related locks before fork() and releases
them after fork() to avoid a deadlock in the child process.
llvm-svn: 217140
2014-09-04 10:36:14 +00:00
9d24aa0fa8
[ASan] allow deadly signals to be received in signal handlers
...
(previously ASan would just crash upon the second SEGV)
Other tools do not use this code yet.
llvm-svn: 217137
2014-09-04 09:34:22 +00:00
2428359e23
Fixup test case after r217079
...
llvm-svn: 217111
2014-09-03 23:46:12 +00:00
fb5d6852c6
[asan] remove debug print
...
llvm-svn: 217101
2014-09-03 22:58:03 +00:00
c8d8ca0bd6
Fix fast stack unwind on ARM to support code generated with GCC.
...
http://reviews.llvm.org/D4692
Patch by Maxim Ostapenko!
llvm-svn: 217079
2014-09-03 21:10:44 +00:00
f8cfdd9207
tsan: handle early signals
...
The second part of the fix of
https://code.google.com/p/thread-sanitizer/issues/detail?id=71
llvm-svn: 217031
2014-09-03 12:25:22 +00:00
f1741f52ad
[msan] Fix origin_history_per_stack_limit=0 behavior.
...
It disables the per-stack limit.
llvm-svn: 217030
2014-09-03 12:15:59 +00:00
26411d6929
tsan: more precise handling of atexit callbacks
...
Fixes issue https://code.google.com/p/thread-sanitizer/issues/detail?id=74
llvm-svn: 216906
2014-09-02 14:22:31 +00:00
8bbb17dcc3
tsan: disable getpwent interceptors
...
There interceptors do not seem to be strictly necessary for tsan.
But we see cases where the interceptors consume 70% of execution time.
Memory blocks passed to fgetgrent_r are "written to" by tsan several times.
First, there is some recursion (getgrnam_r calls fgetgrent_r), and each
function "writes to" the buffer. Then, the same memory is "written to"
twice, first as buf and then as pwbufp (both of them refer to the same addresses).
llvm-svn: 216904
2014-09-02 12:51:11 +00:00
1841219abd
tsan: restructure signal handling to allow recursive handling
...
Fixes issue
https://code.google.com/p/thread-sanitizer/issues/detail?id=71
llvm-svn: 216903
2014-09-02 12:27:45 +00:00
dc1caa7cb8
tsan: address comments in r214912
...
See http://reviews.llvm.org/D4794
llvm-svn: 216900
2014-09-02 09:34:34 +00:00
3ae9193371
[libsanitizer] Fix the Android build.
...
llvm-svn: 216885
2014-09-01 15:38:16 +00:00
21202ba8dd
[asan] Update asan_device_setup to support Android L Preview.
...
llvm-svn: 216884
2014-09-01 15:37:50 +00:00
a909e493f1
[libsanitizer] Make sanitizer_unwind_posix.cc a libcdep source file.
...
Guard the source with #if SANITIZER_POSIX to fix compilation on Windows.
use it only in
llvm-svn: 216882
2014-09-01 13:07:50 +00:00
34fb3799a3
tsan: fix false positive related to signal handlers
...
Users expect synchronization between sigaction and arrival
of the signal. See the test for details.
llvm-svn: 216878
2014-09-01 12:46:42 +00:00
4d84996186
[ASan] Small refactoring - split the slow unwinding logic into sanitizer_unwind_posix.cc
...
This allows the slow unwinder to be used on OSX (it's disabled for now, see
https://code.google.com/p/address-sanitizer/issues/detail?id=137 for details)
llvm-svn: 216877
2014-09-01 12:43:03 +00:00
aa8fa60ba8
tsan: unbreak windows build
...
Currently it fails with:
# Testing race detector.
race_windows_amd64.syso:gotsan.cc:(.text+0x4d89): undefined reference to `__imp_SymGetModuleBase64'
race_windows_amd64.syso:gotsan.cc:(.text+0x4d90): undefined reference to `__imp_SymFunctionTableAccess64'
race_windows_amd64.syso:gotsan.cc:(.text+0x4dd8): undefined reference to `__imp_StackWalk64'
x86_64-w64-mingw32/bin/ld.exe: race_windows_amd64.syso
: bad reloc address 0x10 in section `.data'
collect2.exe: error: ld returned 1 exit status
llvm-svn: 216875
2014-09-01 11:44:59 +00:00
c148f7c3af
[asan] enable poison_array_cookie back
...
llvm-svn: 216705
2014-08-29 01:16:18 +00:00
ac77055272
[asan] introduce __asan_load_cxx_array_cookie: check that the array cookie address is properly poisoned and return the cookie value. If not, return 0 to avoid infinite loop of DTORs (in case of use-after-free). Calls to this function will be inserted by clang (separate change)
...
llvm-svn: 216692
2014-08-28 22:28:04 +00:00
1e3b338606
[asan] disable poison_array_cookie while I am investigating a false positive on chromium (I suspect that LLVM looses nosanitizer metadata; no test yet)
...
llvm-svn: 216684
2014-08-28 20:24:05 +00:00
f77d20b1a9
[ASan/Win] Add a test case for r216663 [-Zl vs LIBCMT vs asan_win_uar_thunk]
...
llvm-svn: 216665
2014-08-28 13:20:23 +00:00
737370da20
[ASan/Win] Add the -Zl flag to avoid /DEFAULTLIB:libcmt directive in the asan_win_uar_thunk object file
...
This directive results in 'symbol already defined' when linking DLLs that use -MD
llvm-svn: 216663
2014-08-28 12:28:04 +00:00
2164fa3b9b
[ubsan] Follow-up for r216657: fixed the line numbers in the test.
...
llvm-svn: 216661
2014-08-28 10:25:17 +00:00
53cce89a81
[UBSan] Temporarily disable checks for stack traces in UBSan reports on Darwin
...
to make the tests green.
Slow stack unwinding is disabled in libsanitizer on Darwin now.
llvm-svn: 216657
2014-08-28 09:25:06 +00:00
83061238d4
[ASan] Whitespace fix. No functionality change.
...
llvm-svn: 216544
2014-08-27 13:43:18 +00:00
5d321d759d
[asan] Add asprintf negative test.
...
llvm-svn: 216542
2014-08-27 12:46:58 +00:00
6add9fe958
[ASan/Win] Enable building the MD runtime by default
...
llvm-svn: 216534
2014-08-27 10:17:20 +00:00
8f4e736080
[asan] Restore asan-rt name on linux back to pre-r216380.
...
There is no reason to have different library names for shared and static
cases on linux. It also breaks Android where we install the shared asan-rt
library into the system and should keep the old name.
This change reverts most of r216380 limiting it to win32 targets only.
llvm-svn: 216533
2014-08-27 09:46:54 +00:00
9455c5ab81
[asan] add a test for poison_array_cookie=1
...
llvm-svn: 216494
2014-08-26 22:05:12 +00:00
08347ca4fd
[lsan] Implement the public allocator interface in standalone LSan.
...
llvm-svn: 216459
2014-08-26 14:28:28 +00:00
93a2906e80
[lsan] Implement __sanitizer_print_stack_trace() in standalone LSan.
...
llvm-svn: 216454
2014-08-26 12:52:41 +00:00
47030475a0
[ASan/Win] Disable warning C4391: incorrect return type for intrinsic function
...
This warning makes it a bit hard to define strlen and wcslen interceptors in an elegant yet portable way
llvm-svn: 216450
2014-08-26 12:33:00 +00:00
81885731a8
[ASan/Win] Rename asan_dll_thunk.cc to asan_win_dll_thunk.cc
...
llvm-svn: 216448
2014-08-26 10:21:37 +00:00
6903e10ddf
[ASan/Win] Add an extra thunk.lib to handle stack-use-after-return option
...
With this patch, "check-asan" passes all the tests with both MT and MD ASan RTL if you set COMPILER_RT_BUILD_SHARED_ASAN to ON
(PR20214)
llvm-svn: 216447
2014-08-26 10:08:24 +00:00
74bd6bc9f9
[sanitizer] move mlock interceptor from asan/tsan/msan to common; no functionality change intended
...
llvm-svn: 216407
2014-08-25 20:57:59 +00:00
dc8caada51
[ASan/Win] Add /DEBUG to the MD RTL link flags
...
llvm-svn: 216387
2014-08-25 16:45:53 +00:00
2311f4dfaa
[ASan] Replace CMake if/APPEND/endif with append_if
...
llvm-svn: 216386
2014-08-25 16:40:39 +00:00
0a88b25c43
[ASan/Win] Intercept memory allocation functions in the MD CRT
...
llvm-svn: 216382
2014-08-25 13:19:05 +00:00
ea3ce790dc
[ASan] Rename the ASan dynamic RT
...
Reviewed at http://reviews.llvm.org/D5026
llvm-svn: 216380
2014-08-25 11:44:06 +00:00
2ccbc621df
[UBSan] Add support for printing backtraces to all UBSan handlers
...
llvm-svn: 216289
2014-08-22 21:42:04 +00:00
ea2402ebf4
[ubsan] Follow-up for r216263: fix the expected line number.
...
llvm-svn: 216266
2014-08-22 12:44:16 +00:00
220ddacf8d
[ASan/Win] Land the trivial bits of -MD RTL support (PR20214)
...
llvm-svn: 216265
2014-08-22 12:38:07 +00:00
f2d24473fe
[ASan] Use check_library_exists to determine if libc/libstdc++ are available
...
llvm-svn: 216264
2014-08-22 12:26:34 +00:00
66ae9712c5
[ubsan] Do not run Function/function.cpp on Darwin where -fsanitize=function is not supported.
...
llvm-svn: 216263
2014-08-22 11:09:10 +00:00
373863d31e
Follow-up for r215436: use SIZE_T for strlen and wcslen interceptors.
...
llvm-svn: 216184
2014-08-21 16:12:46 +00:00
a14ef30443
[ASan] Turns out we should always intercept __cxa_throw
...
At least check-asan works with this change.
If the change breaks anything, we'll need to add:
a) a comment describing why we have to use INTERCEPT_FUNCTION rather than
ASAN_INTERCEPT_FUNC
and
b) a test case.
llvm-svn: 216177
2014-08-21 13:33:39 +00:00
6d2022b2e0
Fix latent bug in try_compile macro and use CMAKE_EXE_LINKER_FLAGS
...
when testing for supported architectures, as suggested by Andy Gibbs.
llvm-svn: 216083
2014-08-20 17:12:58 +00:00
82ff058cf9
DFSan's set label function should avoid writing to the shadow memory when the write would not change the value in memory.
...
When writing a label to shadow memory, don't write if the value is already set to the value being written. This dramatically reduces real memory consumption in programs with sparse use of labels.
Test Plan: It would be nice to test that unnecessary writes are skipped, but I do not see how a unit test could do this.
Patch by Sam Kerner!
Differential Revision: http://reviews.llvm.org/D4894
llvm-svn: 215961
2014-08-19 01:47:33 +00:00
2e39027931
[LSan] Parse common flags from LSAN_OPTIONS even if LSan is combined with
...
another sanitizer.
A user may run both LSan and LSan+ASan. It is weird to pass path to leak
suppression file (or other common sanitizer flags, like "verbosity") in
"LSAN_OPTIONS" in the first case and in "ASAN_OPTIONS" in the second case.
llvm-svn: 215949
2014-08-18 23:39:47 +00:00
00c02b297a
Add regression test for PR15823
...
llvm-svn: 215941
2014-08-18 22:11:14 +00:00
591d15272e
[TSan] Add -lpthread to the test which uses pthread_ functions
...
llvm-svn: 215939
2014-08-18 22:09:17 +00:00
8da47ac82e
profile: Improve error messages on bad GCDA files
...
llvm-svn: 215933
2014-08-18 20:47:32 +00:00
4834653872
sanitizer_printf.cc: guard the va_copy hack on _MSC_VER
...
llvm-svn: 215932
2014-08-18 20:23:16 +00:00
a2d4b09a55
Revert "[ASan/Win] Remove a hack that seems not to be required with VS2013 anymore" (r215708)
...
This is still needed for VS2012.
llvm-svn: 215930
2014-08-18 19:55:35 +00:00
cd21e2f7e4
[TSan] Initialize flags as early as possible. Disables back coredump, accidentally enabled in r215479. Add a test.
...
llvm-svn: 215763
2014-08-15 19:53:51 +00:00
48e21c07c1
Follow-up to r215724: fix a lint warning
...
llvm-svn: 215725
2014-08-15 16:10:02 +00:00
5c84264194
[ASan/Win] Introduce a new macro for malloc-like function attributes; also, clang-format the definitions of these functions
...
llvm-svn: 215724
2014-08-15 16:08:53 +00:00
3e00116dc1
[ASan/Win] Remove one more reference to __interception::GetRealFunctionAddress (follow-up to r215707)
...
llvm-svn: 215722
2014-08-15 15:41:03 +00:00
f8b1cd210d
[ASan/Win] We don't really need to use .CRT to call __asan_init when using -MD
...
llvm-svn: 215719
2014-08-15 14:44:17 +00:00
cc01fad1d9
[ASan/Win] Remove a hack that seems not to be required with VS2013 anymore
...
llvm-svn: 215708
2014-08-15 13:45:23 +00:00
750f1cf9e4
[ASan/Win] Remove old, unused and non-functional code that will be re-written soon
...
llvm-svn: 215707
2014-08-15 12:56:52 +00:00
893beb96a2
[ASan/Win] Slightly update&relax test expectations to work with both -MT and -MD (in progress, PR20214) CRTs
...
llvm-svn: 215641
2014-08-14 13:11:39 +00:00
7040f13639
[ASan/Win] Mark tests that require -MT asan_dll_thunk as such
...
llvm-svn: 215638
2014-08-14 13:02:51 +00:00
5f86aaa27b
tsan: fix unaligned memory access routine
...
It was possimitically handling an aligned 8-byte access as 2 4-byte accesses.
llvm-svn: 215546
2014-08-13 13:20:23 +00:00
de443c5002
[UBSan] Add returns-nonnull sanitizer.
...
Summary:
This patch adds a runtime check verifying that functions
annotated with "returns_nonnull" attribute do in fact return nonnull pointers.
It is based on suggestion by Jakub Jelinek:
http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140623/223693.html .
Test Plan: regression test suite
Reviewers: rsmith
Reviewed By: rsmith
Subscribers: cfe-commits
Differential Revision: http://reviews.llvm.org/D4849
llvm-svn: 215485
2014-08-13 00:26:40 +00:00
5a32f79af3
[MSan] Disable coredump for 64-bit binaries.
...
llvm-svn: 215482
2014-08-12 22:37:47 +00:00
34e2b280da
[TSan] Share the code the setup code calling getrlim/setrlim with sanitizer_common
...
llvm-svn: 215481
2014-08-12 22:31:19 +00:00
d2d2457823
[Sanitizer] Make disable_coredump a common flag and use it in TSan
...
llvm-svn: 215479
2014-08-12 22:07:48 +00:00
b9ec65cd4d
[Sanitizer] Kill deprecated allocator interfaces in ASan, MSan and TSan in favor of
...
a unified interface in <sanitizer/allocator_interface.h>.
llvm-svn: 215469
2014-08-12 20:28:20 +00:00
a03feadeb2
Fix the CMake build when setting MACOSX_DEPLOYMENT_TARGET
...
If we don't reset CMAKE_OSX_DEPLOYMENT_TARGET, it will end up in
CFLAGS together with the -mmacosx-version-min that we set,
and the compiler errors about the conflict.
llvm-svn: 215468
2014-08-12 20:03:33 +00:00
6963686c47
[ASan] Use more appropriate return types for strlen/wcslen to avoid MSVC warnings
...
llvm-svn: 215436
2014-08-12 11:02:53 +00:00
de1718d355
[ASan/Win] Fix PR18987: warning about overriding '/MD' with '/MT'
...
llvm-svn: 215435
2014-08-12 09:44:56 +00:00
968a358974
[ASan] Add new options for asan_symbolize.py script.
...
The patch adds new features in asan-symbolizer script which are helpful for using ASan on embedded systems:
1) add cross-compile prefix for binutils
2) define path to sysroot with sanitized binaries
Features are enabled by command line options.
The patch also extends command line interface with help option.
Reviewed in http://reviews.llvm.org/D4703 .
Patch by Maria Guseva!
llvm-svn: 215381
2014-08-11 20:02:49 +00:00
266ba5586d
Fix build on some architectures caused by r215247.
...
llvm-svn: 215380
2014-08-11 19:57:56 +00:00
a0d65971d4
builtins: add signature to some assembly routines
...
Add a helpful description and a signature for the functions implemented in
assembly for the integral math routines. NFC.
llvm-svn: 215296
2014-08-09 20:17:43 +00:00
6063983c30
builtins: correct __umodsi3, __udivsi3 on ARM
...
When building the builtins for a modern CPU (idiv support), __umodsi3 was
completely incorrect as it would behave as __udivmosi3, which takes a tertiary
parameter which is a pointer.
__udivsi3 was also incorrect, returning the remainder in r1. Although this
would not result in any crash or invalid behaviour as r1 is a caller saved
register in AAPCS, this is unnecessary. Simply perform the division ignoring
the remainder.
llvm-svn: 215295
2014-08-09 20:17:37 +00:00
408d2152c4
Fixup Android tests build rules
...
llvm-svn: 215264
2014-08-09 00:23:11 +00:00
68b9e74592
[CMake] Determine which compiler-rt libraries are supported on
...
a given platform in a top-level CMakeLists.txt to use it both
in lib/ and in test/ subdirectories. Move architecture/platform
checks to config-ix.
llvm-svn: 215247
2014-08-08 22:01:20 +00:00
255958391d
[ASan/Win] Print out a big warning and continue without checking for success if SymInitialize() fails
...
llvm-svn: 215203
2014-08-08 13:25:55 +00:00
7a27160780
Support getting process maps for sanitizers needs on FreeBSD in 32-bit mode
...
Differential Revision: http://reviews.llvm.org/D4807
llvm-svn: 215185
2014-08-08 06:21:09 +00:00
f5c1f8ac84
[sanitizer] Intercept timerfd_settime, timerfd_gettime.
...
llvm-svn: 215112
2014-08-07 14:21:42 +00:00
37e069c2ac
[msan] Fix fcvt interceptor.
...
fcvt() result can be heap-allocated and must be unpoisoned.
llvm-svn: 215106
2014-08-07 12:45:55 +00:00
c68a37c531
Add FreeBSD support to the address sanitizer's malloc_context_size.cc test case
...
Differential Revision: http://reviews.llvm.org/D4665
llvm-svn: 215081
2014-08-07 04:58:41 +00:00
71b471fa09
[TSan] Try to fix Go runtime build
...
llvm-svn: 215000
2014-08-06 23:13:23 +00:00
a37ad099e8
Segregate FreeBSD-specific parts from sanitizer_procmaps_linux.cc
...
Differential Revision: http://reviews.llvm.org/D4555
llvm-svn: 214955
2014-08-06 10:16:52 +00:00
70db9d4d72
tsan: allocate vector clocks using slab allocator
...
Vector clocks is the most actively allocated object in tsan runtime.
Current internal allocator is not scalable enough to handle allocation
of clocks in scalable way (too small caches). This changes transforms
clocks to 2-level array with 512-byte blocks. Since all blocks are of
the same size, it's possible to cache them more efficiently in per-thread caches.
llvm-svn: 214912
2014-08-05 18:45:02 +00:00
0575694729
[ASan/Win] Handle SEH exceptions even with -GS
...
This is a follow-up to r213654, r213656, r213667 and r213668.
llvm-svn: 214861
2014-08-05 13:26:26 +00:00
Viktor Kutuzov